Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Feb 14, 2025

Description

Removing the SRP video (saving 7.5 mb) and replaced with new designs
here
In the future we are doing a bigger redesign. This is a small step
towards it

Related issues

Fixes:

Manual testing steps

  1. Fresh install of the app
  2. Create a new wallet and going through onboarding flow, make sure the
    new design is there and fits on all devices
  3. Afterwards goto settings and goto "Security and Privacy" to make sure
    its removed altogether (no design)

Screenshots/Recordings

Larger Devices

iPhone 16

Smaller Devices

iPhone SE

after-iPhone-SE.mp4

Pixel 2

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. a1d4e5f

## **Description**

Removing the SRP video (saving 7.5 mb) and replaced with new designs
[here](https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=1-117&t=SrTBBEz0dgAQsaoU-1)
In the future we are doing a bigger redesign. This is a small step
towards it

## **Related issues**

Fixes:

## **Manual testing steps**

1. Fresh install of the app
2. Create a new wallet and going through onboarding flow, make sure the
new design is there and fits on all devices
3. Afterwards goto settings and goto "Security and Privacy" to make sure
its removed altogether (no design)

## **Screenshots/Recordings**

### Larger Devices
iPhone 16

<img
src="https://github.com/user-attachments/assets/a470060d-292f-46fc-acbe-2d3eea859557"
width="250px" />

### Smaller Devices

iPhone SE


https://github.com/user-attachments/assets/f2f45941-1b1d-4f2b-8151-c0028183f1f0

Pixel 2

<img
src="https://github.com/user-attachments/assets/94ebea2e-100b-469a-afbc-f61369e2ee5f"
width="250px" />

### **Before**

<img
src="https://github.com/user-attachments/assets/a9c9011c-a466-4d1b-bcac-fcf930e1c5c1"
width="250px" />


### **After**

<img
src="https://github.com/user-attachments/assets/20f44bf9-17fe-440e-984e-69ce18a2b70f"
width="250px" />


## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github bot requested review from a team as code owners February 14, 2025 00:13
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Feb 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9132b2f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c1787473-810e-4ff3-a63f-b12d78d1c010

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sethkfman sethkfman merged commit 25a2cd7 into release/7.41.0 Feb 14, 2025
35 of 38 checks passed
@sethkfman sethkfman deleted the runway-cherry-pick-7.41.0-1739491977 branch February 14, 2025 05:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants