Skip to content

Conversation

@sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Feb 13, 2025

Description

PR to fix account selector balance

Related issues

Fixes: #13476

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2025-02-13.at.16.07.26.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Feb 13, 2025
@sahar-fehri sahar-fehri marked this pull request as ready for review February 13, 2025 15:09
@sahar-fehri sahar-fehri requested a review from a team as a code owner February 13, 2025 15:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: badb21f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/95ae78c2-34f7-4361-adee-adff357e2be6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

@sleepytanya sleepytanya added the QA Passed QA testing has been completed and passed label Feb 13, 2025
@sleepytanya
Copy link
Contributor

Balance in the Account selector is correctly updated:
builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1f4a161-9a70-46e0-8513-5fc1c2fad360?tab=artifacts

Screen_Recording_20250213_105754_MetaMask.mp4

@sahar-fehri sahar-fehri changed the title fix: fix account selector balance fix: cp-7.41.0 fix account selector balance Feb 14, 2025
@sahar-fehri sahar-fehri added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 00dd0f1 Feb 14, 2025
54 of 58 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-account-selector-balance branch February 14, 2025 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. QA Passed QA testing has been completed and passed release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: When switching between views the balance in the Accounts modal displays the previous value for that account

6 participants