Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(runway): cherry-pick fix: improve assets perfs + fix blurred balances and prices #13179

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

runway-github[bot]
Copy link
Contributor

@runway-github runway-github bot commented Jan 24, 2025

Description

Related issues

Fixes: #12724

Manual testing steps

  1. Build android project locally
  2. Add your account or create new one
  3. switch btw network ( the perfs should be good )
  4. switch btw popular network and current network on the token list and
    check the perfs
  5. the list of assets should be displayed quickly

Screenshots/Recordings

Before

After

Screen.Recording.2025-01-06.at.16.18.39.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. 08f48cd

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman requested a review from a team as a code owner January 24, 2025 20:47
@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 24, 2025
@sethkfman sethkfman mentioned this pull request Jan 24, 2025
7 tasks
Copy link
Contributor

github-actions bot commented Jan 24, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 97ad201
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7d6afe88-d012-441d-92fb-95c70b3c81ab

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 50692ad
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/88bd43f8-bd04-4372-b837-44a59dd9dc49

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sethkfman sethkfman merged commit f97f63f into release/7.39.0 Jan 24, 2025
35 of 37 checks passed
@sethkfman sethkfman deleted the cherry-pick-08f48cd branch January 24, 2025 23:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-runway-bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants