chore(runway): cherry-pick fix: app opened event #13175
Merged
+63
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![runway-github[bot]](https://avatars.githubusercontent.com/in/86225?s=60&v=4){kind=small}
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** - Makes app opened event fire on deeplinks and on normal app opening - Adds unit test for the change and removes deprecated (not even working) test - Refactors TrackingEvent to get rid of private and getter and setter preventing events comparison - Adds EventBuilder unit test to ensure events equality check works (non regression) - Adds a warning comment in the code, just for devs to know about the risk of reusing events, I bothered me during tests fix, so better safe than sorry. - Fixes Ramp and unit test that was failing now that TrackingEvent is properly comparable - Removes useless ramp anonymous events list constant that was not properly mocked (revealed by the TrackingEvent change) - Removes useless ramp anonymous logic - Removes ramp useless interaction manager as trackEvent already is async on SDK side ## **Related issues** Fixes MetaMask/mobile-planning#2109 ## **Manual testing steps** 1. Open app 2. check in mixpanel that you receive an App Opened event 3. check there's no anonynmous App Opened event but only a normal one with user Id 4. check that you have the event by opening the app with or without deepling attribution ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
working) test
preventing events comparison
regression)
risk of reusing events, I bothered me during tests fix, so better safe
than sorry.
properly comparable
properly mocked (revealed by the TrackingEvent change)
async on SDK side
Related issues
Fixes https://github.com/MetaMask/mobile-planning/issues/2109
Manual testing steps
with user Id
deepling attribution
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. e2638cc