Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix edit network and delete network with tokenNetworkFilter #13141

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jan 23, 2025

Description

PR to fix issue when a user edits a network or deletes a network. The token network filter is not correctly set.

Related issues

Fixes: #13133 and #13134

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Edit issue:

Screen.Recording.2025-01-23.at.15.36.54.mov

Delete issue:

Screen.Recording.2025-01-23.at.15.38.54.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Unik0rnMaggie
Copy link
Contributor

The fix works:

Edit.Network.Name.fix.mov
Delete.Network.fix.mov

@Unik0rnMaggie Unik0rnMaggie added the QA Passed A successful QA run through has been done label Jan 23, 2025
@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9149e05
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7f2da21d-7a33-48e9-85c6-e697dade7d47

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri force-pushed the fix/fix-network-edit-delete-does-not-preserve-tokenNetwork-filter branch from 8a78a75 to f369018 Compare January 24, 2025 13:03
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
@sahar-fehri sahar-fehri marked this pull request as ready for review January 24, 2025 13:17
@sahar-fehri sahar-fehri requested a review from a team as a code owner January 24, 2025 13:17
Copy link
Contributor

github-actions bot commented Jan 24, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8ad5925
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58bb25f2-93a7-4ca3-a84d-6bb7d6b0e341

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri requested a review from a team as a code owner January 24, 2025 16:23
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2aa37e9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bcfd78c9-7688-4949-8db1-806fdd745a15

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
@sahar-fehri sahar-fehri added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 2623279 Jan 27, 2025
39 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-network-edit-delete-does-not-preserve-tokenNetwork-filter branch January 27, 2025 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: When editing a popular network name, the token list does not update
8 participants