-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix edit network and delete network with tokenNetworkFilter #13141
fix: fix edit network and delete network with tokenNetworkFilter #13141
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
The fix works: Edit.Network.Name.fix.movDelete.Network.fix.mov |
Bitrise❌❌❌ Commit hash: 9149e05 Note
Tip
|
8a78a75
to
f369018
Compare
Bitrise✅✅✅ Commit hash: 8ad5925 Note
|
Bitrise✅✅✅ Commit hash: 2aa37e9 Note
|
app/components/Views/NetworkSelector/RpcSelectionModal/RpcSelectionModal.tsx
Show resolved
Hide resolved
…e-tokenNetwork-filter
…e-tokenNetwork-filter
Quality Gate passedIssues Measures |
Description
PR to fix issue when a user edits a network or deletes a network. The token network filter is not correctly set.
Related issues
Fixes: #13133 and #13134
Manual testing steps
Screenshots/Recordings
Before
After
Edit issue:
Screen.Recording.2025-01-23.at.15.36.54.mov
Delete issue:
Screen.Recording.2025-01-23.at.15.38.54.mov
Pre-merge author checklist
Pre-merge reviewer checklist