Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add primaryType field in signature metrics #13132

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Add primaryType field in signature metrics #13132

merged 2 commits into from
Jan 23, 2025
+286 −137

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 23, 2025

Description

Add eip712_primary_type property to Signature * events on mobile

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3857

Manual testing steps

  1. Go to test dapp
  2. Submit types v4 request
  3. Check metrics create to have field eip712_primary_type

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jan 23, 2025
@jpuri jpuri requested review from a team as code owners January 23, 2025 05:54
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 643cfff
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b6897761-2d83-4348-aa66-170a0e86d430

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
97.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

digiwand
digiwand approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Lgtm

@jpuri jpuri added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 7bb6077 Jan 23, 2025
39 of 40 checks passed
@jpuri jpuri deleted the primary_type_metrics branch January 23, 2025 10:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

Assignees
No one assigned
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpuri @digiwand @metamaskbot