Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix assert e2e test for Address advanced gas fees test #13126

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: Fix assert e2e test for Address advanced gas fees test #13126

merged 1 commit into from
Jan 22, 2025
+3 −3

Conversation

OGPoyraz
Copy link
Member

Description

This PR aims to fix broken e2e test

Related issues

Fixes: #13125

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner January 22, 2025 21:24
@OGPoyraz OGPoyraz linked an issue Jan 22, 2025 that may be closed by this pull request
E2E: Address advanced gas fees test failure #13125
Closed
9 tasks
@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise No QA Needed Apply this label when your PR does not need any QA effort. labels Jan 22, 2025
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 73c0b8e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4c6175b7-761e-4c33-8076-253e4b97bdd6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cortisiko
cortisiko approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing! 🙏

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 7bb25a6 Jan 22, 2025
48 checks passed
@OGPoyraz OGPoyraz deleted the 13125-e2e-address-advanced-gas-fees-test-failure branch January 22, 2025 22:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E: Address advanced gas fees test failure
3 participants
@OGPoyraz @cortisiko @metamaskbot