chore(runway): cherry-pick fix: ensure marketing consent is explicitly tracked as boolean #13093
+30
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![runway-github[bot]](https://avatars.githubusercontent.com/in/86225?s=60&v=4){kind=small}
…y tracked as boolean (#12926) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Currently, when users decline marketing consent during onboarding, the `has_marketing_consent` property is not being set at all in the analytics. This creates inconsistent data where we can't properly track users who explicitly opted out of marketing. This PR modifies the OptinMetrics component to explicitly set `has_marketing_consent` to either `true` or `false` based on the user's choice, ensuring we have complete analytics data for all user decisions regarding marketing consent. ## **Related issues** Fixes: MetaMask/mobile-planning#2086 ## **Manual testing steps** 1. Fresh install the app 2. Go through onboarding until you reach the "Help us improve MetaMask" screen 3. Test both scenarios: - Accept metrics but decline marketing consent checkbox - Accept both metrics and marketing consent 4. Verify in analytics that `has_marketing_consent` is properly set to `false` in first case and `true` in second case ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** Analytics data missing `has_marketing_consent` property when user declines marketing consent ### **After** Analytics data showing explicit `has_marketing_consent: false` when user declines marketing consent ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when users decline marketing consent during onboarding, the
has_marketing_consentproperty is not being set at all in theanalytics. This creates inconsistent data where we can't properly track
users who explicitly opted out of marketing.
This PR modifies the OptinMetrics component to explicitly set
has_marketing_consentto eithertrueorfalsebased on the user'schoice, ensuring we have complete analytics data for all user decisions
regarding marketing consent.
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2086
Manual testing steps
screen
has_marketing_consentis properly set tofalsein first case andtruein second caseScreenshots/Recordings
Before
Analytics data missing
has_marketing_consentproperty when userdeclines marketing consent
After
Analytics data showing explicit
has_marketing_consent: falsewhen userdeclines marketing consent
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. 7139a15