Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adding e2e test cases for signature pages #13053

Merged
merged 20 commits into from
Jan 23, 2025
Merged

chore: Adding e2e test cases for signature pages #13053

merged 20 commits into from
Jan 23, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 17, 2025 •
edited
Loading

Description

  • Adding e2e for re-designed signature pages.
  • Adding new pipeline for re-designed confirmations.

Related issues

Fixes: #13052
Fixes: #13054
Fixes: #13055
Fixes: #13055

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jan 17, 2025
@jpuri jpuri requested review from a team as code owners January 17, 2025 12:44
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title chore: Adding e2e test cases for personal sign page chore: Adding e2e test cases for signature pages Jan 17, 2025
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0fdb474
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/730e6dc7-466f-4208-9544-2bfe9025be4d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 17, 2025
@jpuri jpuri enabled auto-merge January 17, 2025 15:38
@jpuri jpuri disabled auto-merge January 17, 2025 15:38
@jpuri jpuri requested a review from cortisiko January 17, 2025 15:38
cortisiko
cortisiko requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpuri These are well-written tests 🥇... I have one question: Should we remove the old signature tests: https://github.com/MetaMask/metamask-mobile/tree/main/e2e/specs/confirmations/signatures seems to be a bit redundant running the same tests twice.

e2e/specs/confirmations/signatures-redesigned/signatures.spec.js Outdated Show resolved Hide resolved
@jpuri
Copy link
Contributor Author

jpuri commented Jan 20, 2025

@jpuri These are well-written tests 🥇... I have one question: Should we remove the old signature tests: https://github.com/MetaMask/metamask-mobile/tree/main/e2e/specs/confirmations/signatures seems to be a bit redundant running the same tests twice.

Hey @cortisiko : we will soon get rid of old confirmation code and these old e2e will also go away with it. We had a discussion in team about it and we will prefer to keep 2 set of e2e till there is 2 set of implementation for the functionality.

@jpuri jpuri requested a review from cortisiko January 20, 2025 10:01
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 692f694
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f3d0c1e3-afe5-4956-b1c0-17809fb6a4f9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 20, 2025
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 13bbd77
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cb875dbf-f55d-4212-9f2a-140907f9f15c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 75caae8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e30ac3af-7938-40b6-8a0a-0da4618421f8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b7d3680
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/515e5d0e-c24d-41bb-8a22-fab79ff3b5a7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5e68279
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d0ac1e7c-fcd3-49ea-b73b-6790d06fb152

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cortisiko
cortisiko approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

@jpuri jpuri enabled auto-merge January 23, 2025 17:36
@jpuri jpuri added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit c40c8fd Jan 23, 2025
42 checks passed
@jpuri jpuri deleted the personal_sign_e2e branch January 23, 2025 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@cortisiko cortisiko cortisiko approved these changes

@OGPoyraz OGPoyraz Awaiting requested review from OGPoyraz

Assignees
No one assigned
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
6 participants
@jpuri @codecov-commenter @OGPoyraz @cortisiko @pedronfigueiredo @metamaskbot