-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore(deps): bump elliptic to ^6.6.0
#12979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12979 +/- ##
==========================================
+ Coverage 60.89% 60.91% +0.01%
==========================================
Files 1917 1920 +3
Lines 42708 42742 +34
Branches 5788 5795 +7
==========================================
+ Hits 26007 26035 +28
- Misses 14937 14943 +6
Partials 1764 1764 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
The audit job seems to be passing on |
|
|
The merge queue failure seems to be an install script error tied to the |



Description
This PR bumps
ellipticin the dependency tree to mitigate the following security advisories:The closer version that mitigates all the above advisories is
6.6.0.Currently on
main, these are the versions we have forelliptic:The added resolution forces the package on
^6.6.0which currently resolves to6.6.1Related issues
Related: MetaMask/core#4847
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist