refactor: remove global network usage from transaction confirmations

[matthewwalsh0]

Description

Remove all global network references from the transaction confirmations and confirmations in general.

Note that some exceptions remain in the send components as these transactions are triggered internally so cannot rely on a dApp selected network.

Specifically:

• Add component properties:
  • AddressElement > chainId
  • AddressList > chainId
  • SendFlowAddressFrom > chainId
• Add selectors:
  • selectConversionRateByChainId
  • selectProviderTypeByChainId
  • selectRpcUrlByChainId
  • selectContractExchangeRatesByChainId
• Update linting rule to apply to entire app/components/Views/confirmations directory.

Related issues

Fixes: #2025

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a02277f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ce8ca728-42de-4f5f-be81-564bb46c79b4

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9f6436d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/330a40a2-3bc3-4cd2-8dcc-a213b00e6769

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c5f31a3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f0ca795c-c66b-407f-8a8b-83942968cc03

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 81.25000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 60.01%. Comparing base (faf5340) to head (ca78031).
Report is 35 commits behind head on main.

Files with missing lines	Patch %	Lines
...imulation/components/ValueDisplay/ValueDisplay.tsx	54.28%	6 Missing and 10 partials ⚠️
app/components/Views/confirmations/Send/index.js	62.50%	3 Missing ⚠️
app/components/Views/Settings/Contacts/index.js	0.00%	1 Missing ⚠️
...nents/Views/confirmations/SendFlow/SendTo/index.js	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12955      +/-   ##
==========================================
+ Coverage   59.83%   60.01%   +0.18%     
==========================================
  Files        1873     1900      +27     
  Lines       42121    42557     +436     
  Branches     5473     5615     +142     
==========================================
+ Hits        25204    25542     +338     
- Misses      15235    15286      +51     
- Partials     1682     1729      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5c642c1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db7eec49-f819-4bcb-a3eb-2f1e51f9152f

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ca78031
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ed715f21-6726-4477-b77b-38147c1a9534

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 07fdf51
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c85d3ed3-b8c4-4ddc-ade0-9d00299bd6ff

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.9% Coverage on New Code
0.6% Duplication on New Code

See analysis details on SonarQube Cloud

[EtherWizard33]

for wallet-ux, the two lines in app/components/Views/Settings/Contacts/index.js
LGTM