-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: invoke_snap RPC requests inside the built-in browser #12923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invoke_snap RPC requests inside the built-in browser #12923
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12923 +/- ##
==========================================
+ Coverage 58.85% 59.72% +0.86%
==========================================
Files 1851 1865 +14
Lines 41739 42017 +278
Branches 5397 5458 +61
==========================================
+ Hits 24566 25093 +527
+ Misses 15502 15245 -257
- Partials 1671 1679 +8 ☔ View full report in Codecov by Sentry. |
…nvoke-snap-rpc-calls-in-mm-browser
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
BUG:
The invoke_snap RPC calls kept failing, returning a
RPC Error: Property 'handleSnapRequest' doesn't exist
.FIX:
The
handleSnapRequest
import was code-fenced as part of the keyring snap, but should be available to all snaps. I moved the relevant import outside of the codefence.Related issues
Fixes: https://infura.atlassian.net/issues/MDD-117 / https://consensys.slack.com/archives/C027M10HGEA/p1736428038068929
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist