Skip to content

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Jan 10, 2025

Description

BUG:
The invoke_snap RPC calls kept failing, returning a RPC Error: Property 'handleSnapRequest' doesn't exist.

FIX:
The handleSnapRequest import was code-fenced as part of the keyring snap, but should be available to all snaps. I moved the relevant import outside of the codefence.

Related issues

Fixes: https://infura.atlassian.net/issues/MDD-117 / https://consensys.slack.com/archives/C027M10HGEA/p1736428038068929

Manual testing steps

  1. Visit this preview in the MM browser: https://metamask-docs-git-snap-debugging-branch-consensys-ddffed67.vercel.app/developer-tools/faucet/
  2. (optional) Press the "Debug Test" button, it should complete
  3. Press the "Connect MetaMask" button, it should complete

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-notifications DEPRECATED: Use "team-assets" instead label Jan 10, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.72%. Comparing base (9d6908b) to head (6e12d2a).
Report is 58 commits behind head on main.

Files with missing lines Patch % Lines
app/core/Engine/Engine.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12923      +/-   ##
==========================================
+ Coverage   58.85%   59.72%   +0.86%     
==========================================
  Files        1851     1865      +14     
  Lines       41739    42017     +278     
  Branches     5397     5458      +61     
==========================================
+ Hits        24566    25093     +527     
+ Misses      15502    15245     -257     
- Partials     1671     1679       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review January 10, 2025 11:54
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team January 10, 2025 11:54
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Requires smoke E2E testing label Jan 10, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 80be0b0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/780f1371-d7dc-4a5b-bf16-cb874034ee74

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jan 10, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 42d72bb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d9524322-3828-4240-baac-bd5bd75af726

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 27e7cf4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f8557afd-0e22-40a1-aa80-2fe720392e20

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Jan 10, 2025
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025
@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit d35a2a0 Jan 10, 2025
42 of 43 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the fix-invoke-snap-rpc-calls-in-mm-browser branch January 10, 2025 14:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Requires smoke E2E testing team-notifications DEPRECATED: Use "team-assets" instead
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants