Skip to content

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Jan 7, 2025

Description

This PR removes the MM_POOLED_STAKING_UI_ENABLED feature flag, removed related usages in the codebase, and updates breaking tests. We no longer need this feature flag as pooled-staking is live.

Related issues

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 added Run Smoke E2E Requires smoke E2E testing and removed team-identity labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 811f258
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46d68023-eadd-4919-b4f3-156ee7625753

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Matt561 Matt561 force-pushed the feat/remove-pooled-staking-feature-flag branch 4 times, most recently from 2fb430f to 5ddf025 Compare January 8, 2025 18:07
@Matt561 Matt561 force-pushed the feat/remove-pooled-staking-feature-flag branch from 5ddf025 to 6fa36d8 Compare January 8, 2025 18:13
@Matt561 Matt561 added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6fa36d8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/098e3ea8-f1e1-4bbe-a971-23a6dd7ccf7a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Matt561 Matt561 marked this pull request as ready for review January 8, 2025 21:32
@Matt561 Matt561 requested review from a team as code owners January 8, 2025 21:32
@Matt561 Matt561 requested a review from a team January 8, 2025 21:32
@Matt561 Matt561 requested a review from amitabh94 January 8, 2025 21:55
amitabh94
amitabh94 previously approved these changes Jan 8, 2025
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tommasini
tommasini previously approved these changes Jan 10, 2025
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pooled staking alive <3

@Matt561 Matt561 dismissed stale reviews from tommasini and amitabh94 via e527c97 January 10, 2025 21:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.78%. Comparing base (6b68dd7) to head (561c1e7).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...nts/UI/AssetOverview/TokenDetails/TokenDetails.tsx 0.00% 0 Missing and 1 partial ⚠️
...ents/UI/Stake/components/StakingEarnings/index.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12852      +/-   ##
==========================================
+ Coverage   59.72%   59.78%   +0.05%     
==========================================
  Files        1865     1867       +2     
  Lines       42011    42039      +28     
  Branches     5458     5456       -2     
==========================================
+ Hits        25093    25133      +40     
+ Misses      15239    15234       -5     
+ Partials     1679     1672       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Matt561 Matt561 removed the Run Smoke E2E Requires smoke E2E testing label Jan 10, 2025
@Matt561 Matt561 added the Run Smoke E2E Requires smoke E2E testing label Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e527c97
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b63628f7-fc29-4e96-b685-d2400e7d9fd1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Matt561 Matt561 added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jan 13, 2025
@Matt561 Matt561 added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 561c1e7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f3c20077-ef9c-4c02-81cb-5aff520a4d9d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@Matt561 Matt561 enabled auto-merge January 14, 2025 15:25
@Matt561 Matt561 added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 261975f Jan 14, 2025
40 of 41 checks passed
@Matt561 Matt561 deleted the feat/remove-pooled-staking-feature-flag branch January 14, 2025 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Requires smoke E2E testing team-stake
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants