Skip to content

fix: Fix padding on Android browser search #12665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix: Fix padding on Android browser search #12665

merged 3 commits into from
Jan 10, 2025
+63 −65

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Dec 12, 2024

Description

This PR fixes a padding issue on the BrowserUrlModal screen for Android

Related issues

Fixes: Thread - https://consensys.slack.com/archives/C02U025CVU4/p1733763228960359

Manual testing steps

  1. On Android, go to browser tab
  2. Tap on the address bar
  3. Notice that the search bar now respects the top notch for Android

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner December 12, 2024 18:24
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added team-mobile-platform Mobile Platform team No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 12, 2024
@Cal-L Cal-L enabled auto-merge December 12, 2024 18:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8ff83dc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5fb77a71-6e3d-4bcf-9410-02aa91629c7c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sethkfman
sethkfman previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EtherWizard33
Copy link
Contributor

EtherWizard33 commented Dec 12, 2024 •
edited
Loading

@sethkfman oops, sorry I missclicked the reset review there
but while i'm here, it looks like some e2e tests might benefit from this fix so i'm keeping an eye on the PR being merged

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Cal-L Cal-L added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 8873337 Jan 10, 2025
36 of 37 checks passed
@Cal-L Cal-L deleted the fix/padding-android-browser-search branch January 10, 2025 21:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 10, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@sethkfman sethkfman Awaiting requested review from sethkfman

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Requires smoke E2E testing team-mobile-platform Mobile Platform team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cal-L @EtherWizard33 @sethkfman @tommasini @metamaskbot