Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update some @metamask/notification-services-controller imports #12614

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

Prithpal-Sooriya
Copy link
Contributor

Description

update some imports to not use the dist folder, and use the subpath imports. We will make a larger PR that will sweep across the rest of the imports

Related issues

Fixes: N/A

Manual testing steps

This feature is not released and this just changes how we import some files.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

update some imports to not use the dist folder, and use the subpath imports. We will make a larger PR that will sweep across the rest of the imports
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner December 9, 2024 16:13
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications DEPRECATED: Use "team-assets" instead label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

mathieuartu
mathieuartu previously approved these changes Dec 9, 2024
cmd-ob
cmd-ob previously approved these changes Dec 9, 2024
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a34db21
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1f7d3d38-2859-4f9c-b1db-1234c76037e7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as draft December 12, 2024 12:06
@Prithpal-Sooriya Prithpal-Sooriya dismissed stale reviews from mathieuartu and cmd-ob via 5f45f49 December 16, 2024 15:54
@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5f45f49
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ffb614b9-e365-4c2a-8351-6f2163c450b6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review December 16, 2024 16:24
@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 529dc1b Dec 16, 2024
39 of 40 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the refactor-cleanup-notification-imports branch December 16, 2024 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications DEPRECATED: Use "team-assets" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants