Skip to content

chore: bump react-native-linear-gradient library #12553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 5, 2024
Merged

chore: bump react-native-linear-gradient library #12553

merged 5 commits into from
Dec 5, 2024
+8 −8

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Dec 4, 2024 •
edited
Loading

Description

When trying to update rn version the following warning appeared:

warn Known bad packages are found in 'package.json':
        react-native-linear-gradient@<2.6.0: This package causes significant degradation in app start up time prior to 2.6.0.

This library was updated to latest: https://github.com/react-native-linear-gradient/react-native-linear-gradient

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Requires smoke E2E testing team-tiger Tiger team (for tech debt reduction + performance improvements) labels Dec 4, 2024
@tommasini tommasini requested a review from a team December 4, 2024 18:03
@tommasini tommasini requested a review from a team as a code owner December 4, 2024 18:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9079494
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b7c6826f-658b-4959-9080-80e563c23871

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@socket-security Socket Security
Copy link

socket-security bot commented Dec 4, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-native-linear-gradient@2.8.3 None 0 118 kB fbluemle.oss

🚮 Removed packages: npm/react-native-linear-gradient@2.5.6

View full report↗︎

@tommasini tommasini marked this pull request as draft December 4, 2024 18:16
Cal-L
Cal-L previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c5de3b5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/633d0920-f0ce-4b0e-851e-100dc5c6f84b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini changed the title chore: remove unused library react-native-linear-gradient chore: bump react-native-linear-gradient library Dec 4, 2024
@tommasini tommasini marked this pull request as ready for review December 4, 2024 18:56
@tommasini tommasini removed the Run Smoke E2E Requires smoke E2E testing label Dec 4, 2024
@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: beada6e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3276a4a4-a4a8-4d72-8b32-8b8552ac96db

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini enabled auto-merge December 4, 2024 21:25
@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Dec 4, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tommasini tommasini added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit edbef4d Dec 5, 2024
36 checks passed
@tommasini tommasini deleted the chore/remove-rn-linear-gradient-library branch December 5, 2024 18:08
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Requires smoke E2E testing team-mobile-platform Mobile Platform team team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommasini @Cal-L @metamaskbot