Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Chore/12435 mvp handle engine does not exist #12538

Merged
merged 45 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
188fe55
Trigger on nav ready action
Cal-L Nov 27, 2024
c849f8a
Create ReduxService to manage Redux store
Cal-L Dec 2, 2024
fc90452
Move service initialization into sagas
Cal-L Dec 2, 2024
369c615
Update EngineService to use ReduxService
Cal-L Dec 2, 2024
149c8e4
Update Authentication service to use ReduxService
Cal-L Dec 2, 2024
469530b
Update AppStateListener service to use ReduxService
Cal-L Dec 2, 2024
f8c307f
Update LockManager service to use ReduxService
Cal-L Dec 2, 2024
3e91633
Move AssetPollingProvider to post login
Cal-L Dec 3, 2024
f597189
Start services when events are ready
Cal-L Dec 3, 2024
e4ca0c8
Use types and enums in navigation reducer and actions
Cal-L Dec 3, 2024
c07e908
Use types and enums for user reducer and actions
Cal-L Dec 3, 2024
6cca04c
Set store earlier
Cal-L Dec 3, 2024
8055bdb
Add TODO for gate keeping based on service availability
Cal-L Dec 3, 2024
58cdb78
Clean up user and navigation reducers
Cal-L Dec 3, 2024
7f002ae
Give function space
Cal-L Dec 3, 2024
944ea95
Abstract user actions
Cal-L Dec 3, 2024
5bcbce5
Abstract navigation actions
Cal-L Dec 3, 2024
62d6627
Update redux service import
Cal-L Dec 3, 2024
9151194
Merge branch 'main' of github.com:MetaMask/metamask-mobile into chore…
Cal-L Dec 4, 2024
e285646
Fix optional field for user actions
Cal-L Dec 4, 2024
a513f72
Fix AppStateEventListener tests
Cal-L Dec 4, 2024
6953422
Fix tests for Authentication service
Cal-L Dec 4, 2024
92edb61
Merge branch 'main' into chore/12435-mvp-handle-engine-does-not-exist
Cal-L Dec 4, 2024
4bd362b
Fix test on services
Cal-L Dec 4, 2024
0564f50
Merge branch 'chore/12435-mvp-handle-engine-does-not-exist' of github…
Cal-L Dec 4, 2024
1f6f7f5
Fix EngineService tests
Cal-L Dec 4, 2024
631c2a2
Fix lint issues
Cal-L Dec 5, 2024
ae28f8d
Rename to AccountsController folder
Cal-L Dec 5, 2024
58d9da7
Update codeowners
Cal-L Dec 5, 2024
c9812c4
Fix saga test lint
Cal-L Dec 5, 2024
b04a400
Navigate to vault recovery when Engine fails to initialize and write …
Cal-L Dec 5, 2024
b5101d0
Write test for start app service saga
Cal-L Dec 5, 2024
24642b5
Create tests for ReduxService
Cal-L Dec 5, 2024
5e7b222
Update initial root state with navigation state
Cal-L Dec 5, 2024
90d560f
Fix unit test
Cal-L Dec 5, 2024
a7624d6
Merge branch 'main' into chore/12435-mvp-handle-engine-does-not-exist
Cal-L Dec 5, 2024
67ed731
Merge branch 'main' of github.com:MetaMask/metamask-mobile into chore…
Cal-L Dec 5, 2024
b8c8a7c
:erge branch 'chore/12435-mvp-handle-engine-does-not-exist' of github…
Cal-L Dec 5, 2024
0ca5a5e
Merge branch 'main' of github.com:MetaMask/metamask-mobile into chore…
Cal-L Dec 5, 2024
6cb3a58
Remove call from app start service in sagas
Cal-L Dec 5, 2024
b15913a
Move updatecontrollers into try block
Cal-L Dec 6, 2024
6fe65a9
Update type import
Cal-L Dec 6, 2024
e6673ce
Merge branch 'main' of github.com:MetaMask/metamask-mobile into chore…
Cal-L Dec 6, 2024
f184150
Merge branch 'main' of github.com:MetaMask/metamask-mobile into chore…
Cal-L Dec 6, 2024
a81a617
Merge from main
Cal-L Dec 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix optional field for user actions
  • Loading branch information
Cal-L committed Dec 4, 2024
commit e285646d5eaf974706562c2a5ef710b15d0cf8ed
4 changes: 2 additions & 2 deletions app/actions/user/index.ts
Cal-L marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ export function lockApp(): LockAppAction {
};
}

export function authSuccess(bioStateMachineId: string): AuthSuccessAction {
export function authSuccess(bioStateMachineId?: string): AuthSuccessAction {
return {
type: UserActionType.AUTH_SUCCESS,
payload: { bioStateMachineId },
};
}

export function authError(bioStateMachineId: string): AuthErrorAction {
export function authError(bioStateMachineId?: string): AuthErrorAction {
return {
type: UserActionType.AUTH_ERROR,
payload: { bioStateMachineId },
Expand Down
4 changes: 2 additions & 2 deletions app/actions/user/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ export enum UserActionType {
export type LockAppAction = Action<UserActionType.LOCKED_APP>;

export type AuthSuccessAction = Action<UserActionType.AUTH_SUCCESS> & {
payload: { bioStateMachineId: string };
payload: { bioStateMachineId?: string };
};

export type AuthErrorAction = Action<UserActionType.AUTH_ERROR> & {
payload: { bioStateMachineId: string };
payload: { bioStateMachineId?: string };
};

export type InterruptBiometricsAction =
Expand Down
1 change: 0 additions & 1 deletion app/core/LockManagerService/index.ts
Cal-L marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ class LockManagerService {
#handleAppStateChange = async (nextAppState: AppStateStatus) => {
// Don't auto-lock.
const lockTime = ReduxService.store.getState().settings.lockTime;
console.log('lockTime', lockTime);
if (
lockTime === -1 || // Lock timer isn't set.
nextAppState === 'inactive' || // Ignore inactive state.
Expand Down