Skip to content

chore(deps): bump @metamask/{swaps, gas-fee}-controller #12368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 26, 2024
Merged

chore(deps): bump @metamask/{swaps, gas-fee}-controller #12368

merged 7 commits into from
Nov 26, 2024

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Nov 21, 2024 •
edited
Loading

Description

This PR bumps @metamask/swaps-controller to ^11.0.0 and @metamask/gas-fee-controller to ^21.0.0 (to match swaps-controller's peer dependency requirements). See package changelogs for details on changes:

Related issues

Related to: #11910

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito mentioned this pull request Nov 21, 2024
Closed
12 tasks
@socket-security
Copy link

socket-security bot commented Nov 21, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/gas-fee-controller@21.0.0 None +1 324 kB metamaskbot
npm/@metamask/swaps-controller@11.0.0 None 0 280 kB metamaskbot

🚮 Removed packages: npm/@metamask/eth-block-tracker@9.0.3, npm/@metamask/eth-json-rpc-infura@9.1.0, npm/@metamask/gas-fee-controller@18.0.0, npm/@metamask/network-controller@19.0.0, npm/@metamask/swaps-controller@10.0.0

View full report↗︎

@mikesposito mikesposito marked this pull request as ready for review November 21, 2024 11:12
@mikesposito mikesposito requested a review from a team as a code owner November 21, 2024 11:12
@mikesposito mikesposito requested a review from a team November 21, 2024 11:12
@mikesposito mikesposito requested a review from a team as a code owner November 21, 2024 11:12
@mikesposito mikesposito self-assigned this Nov 21, 2024
@mikesposito mikesposito requested a review from a team November 21, 2024 11:14
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d1de7b6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17120551-4325-4280-b7a2-63754a9038f9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini reviewed Nov 21, 2024
View reviewed changes
@mikesposito mikesposito changed the title chore(deps): bump @metamask/swaps-controller to ^11.0.0 chore(deps): bump @metamask/{swaps, gas-fee}-controller Nov 26, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Gudahtt
Gudahtt approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like no patches are affected, and this removes some peer dependency warnings. None of the breaking changes in these ranges appear to require changes either.

sethkfman
sethkfman approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Glad to see these type-expect-error ignore disappear

@mikesposito mikesposito added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit e7cff66 Nov 26, 2024
36 of 37 checks passed
@mikesposito mikesposito deleted the mikesposito/deps/bump-swaps-controller-to-11 branch November 26, 2024 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@sethkfman sethkfman sethkfman approved these changes

@mcmire mcmire Awaiting requested review from mcmire

@tommasini tommasini Awaiting requested review from tommasini

Assignees

@mikesposito mikesposito

Labels

release-7.37.0 Issue or pull request that will be included in release 7.37.0 team-wallet-framework

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mikesposito @mcmire @Gudahtt @sethkfman @tommasini @metamaskbot