Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable confirm button if transactionMeta is undefined #12273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OGPoyraz
Copy link
Member

Description

This PR adds disabled button condition when transactionMeta is undefined.

Related issues

Fixes: #11537

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. team-confirmations Push issues to confirmations team labels Nov 13, 2024
@OGPoyraz OGPoyraz requested review from a team as code owners November 13, 2024 12:38
},
));
} catch (error) {
Logger.error(error, 'error while adding transaction (Confirm)');
Copy link
Member

@matthewwalsh0 matthewwalsh0 Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If their experience is ultimately broken, can we instead show the standard error modal including the error and then exit the confirmation?

If there is no underlying transaction metadata, then how can the confirmation function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, added navigation back to recent screen on error.

Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
40.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sentry] TypeError: undefined is not an object (evaluating 'n.chainId')
2 participants