-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(deps): eth-json-rpc-middleware@4.3.0->^7.0.1 #11973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/checkpoint-store@1.1.0, npm/deferred-leveldown@1.2.2, npm/eth-json-rpc-errors@1.1.1, npm/eth-json-rpc-middleware@4.3.0, npm/ethereum-common@0.2.0, npm/ethereumjs-account@2.0.5, npm/ethereumjs-block@1.7.1, npm/ethereumjs-common@1.5.2, npm/ethereumjs-vm@2.6.0, npm/fake-merkle-patricia-tree@1.0.1, npm/fetch-ponyfill@4.1.0, npm/level-codec@7.0.1, npm/level-errors@1.0.5, npm/level-iterator-stream@1.3.1, npm/level-ws@0.0.0, npm/levelup@1.3.9, npm/memdown@1.4.1, npm/rustbn.js@0.2.0, npm/safe-event-emitter@1.0.1, npm/semaphore@1.1.0 |
b00520b to
c414e9a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c414e9a to
e5369c6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
e5369c6 to
7b22336
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7b22336 to
86dbcf7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
## **Description** Bump `eth-json-rpc-filters` ## **Related issues** - #11973 #### Blocking - #11968 ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
86dbcf7 to
286da2f
Compare
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
286da2f to
56589fb
Compare
network access ok |
|
|
|



Description
Previously,
eth-json-rpc-middlewareis pinned to4.3.0(2019-10-05).This bumps to
^7.0.1(2021-03-26), with intention to follow up with further upgrade as follow-up.Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist