Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds useChainId hook to all other UI components #11837

Closed
wants to merge 6 commits into from
Closed

feat: adds useChainId hook to all other UI components #11837

wants to merge 6 commits into from
+29 −36

Conversation

andreahaku
Copy link
Contributor

@andreahaku andreahaku commented Oct 17, 2024 •
edited
Loading

Description

Adds support for useChainId hook to all the others UI components

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/85/views/2?pane=issue&itemId=82943990

Related PRs

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@andreahaku andreahaku changed the title fatt: adds useChhainIdhook to all other UI components feat: adds useChhainIdhook to all other UI components Oct 17, 2024
@andreahaku andreahaku changed the base branch from main to feature/adds_useChainId_components_views October 17, 2024 13:07
@andreahaku andreahaku changed the title feat: adds useChhainIdhook to all other UI components feat: adds useChainIdhook to all other UI components Oct 17, 2024
@andreahaku andreahaku self-assigned this Oct 17, 2024
@andreahaku andreahaku changed the title feat: adds useChainIdhook to all other UI components feat: adds useChainId hook to all other UI components Oct 21, 2024
@andreahaku andreahaku added Code Impact - Low Minor code change that can safely applied to the codebase Priority - Low Task with low priority labels Oct 21, 2024
@andreahaku andreahaku marked this pull request as ready for review October 21, 2024 12:04
@andreahaku andreahaku requested review from a team as code owners October 21, 2024 12:04
@andreahaku andreahaku added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5415e6a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7662e49a-5128-4445-9333-daa12f0d7ea1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

This was referenced Oct 21, 2024
Closed
Closed
Closed
Closed
@andreahaku andreahaku added Priority - Medium Task with medium priority and removed Priority - Low Task with low priority labels Oct 21, 2024
@sahar-fehri sahar-fehri removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 23, 2024
@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3a521f8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/024a80ea-061e-4aca-b434-8cb70adb6677

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri
Copy link
Contributor

Changes LGTM! Thank you 🙏 But seems like build is failing in e2e tests?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@andreahaku andreahaku added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 24c82d5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1531e6cd-0010-496c-865d-cfd56834c5ec

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

@github-actions github-actions bot closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiniteflower infiniteflower infiniteflower approved these changes

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

Assignees

@andreahaku andreahaku

Labels
Code Impact - Low Minor code change that can safely applied to the codebase Priority - Medium Task with medium priority Run Smoke E2E Triggers smoke e2e on Bitrise stale Issues that have not had activity in the last 90 days team-wallet-ux
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreahaku @sahar-fehri @brianacnguyen @infiniteflower