chore(js-ts): Convert app/core/Vault.js to TypeScript

[devin-ai-integration]

Description

This PR converts the file app/core/Vault.js to TypeScript (app/core/Vault.ts). The conversion includes:

• Adding type annotations to functions and variables
• Converting for loops to for...of loops where appropriate
• Adding an interface for LedgerBridgeKeyringOptions
• Handling unknown types with appropriate comments and type assertions

Changes Made

• Renamed Vault.js to Vault.ts
• Added type annotations to function parameters and return types
• Converted any types to more specific types where possible
• Added comments explaining the use of unknown types where necessary
• Updated import statements to include required types from @metamask/keyring-controller

Notes

Some types remain as unknown or use type assertions due to the complexity of the KeyringController and its methods. Further investigation into the @metamask/keyring-controller package may be needed to fully type these areas.

Testing

• yarn lint:tsc passes without errors
• yarn lint passes without errors (warnings are present but ignored as per instructions)

Link to Devin run

https://preview.devin.ai/devin/f1d5b69e820749a3b70eea9f0b1d87a9

This Devin run was requested by naveen

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dd6113c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5e738709-ef81-4fce-af8d-8864b97329d0

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate failed

Failed conditions
20.3% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud