Skip to content

Conversation

@salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 9, 2024

Description

fix design ui for the multi rpc modal

Related issues

Fixes:

Manual testing steps

  1. this Modal is not called yet , it's require the network controller v21 to be used
  2. the use of this modal will be done on this PR

Screenshots/Recordings

Before

After

Screenshot 2024-10-04 at 11 44 15

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested review from a team as code owners October 9, 2024 20:38
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the salim/fix-multi-rpc-modal-design branch from 1eb2b07 to 7e38ed2 Compare October 9, 2024 20:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7e38ed2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f4d462df-c8af-49b1-ac4a-4827f12f105b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

/**
* Optional button props
*/
buttonProps?: ButtonBaseProps;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its better to use ButtonProps

Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested RE button props

@salimtb salimtb closed this Dec 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants