-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ledger account selection screen add hd options to sync with extension #10755
Conversation
…gerSelectAccount screen.
…ns-sync-with-extension
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
…s requirement to use new design pattern.
…s requirement to use new design pattern. Split the OptionsSheet to difference route components.
…extension' into feat/10678-hd-options-sync-with-extension
|
|
…nected to not ledger account.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10755 +/- ##
==========================================
+ Coverage 52.75% 52.92% +0.16%
==========================================
Files 1534 1549 +15
Lines 36777 37025 +248
Branches 4335 4376 +41
==========================================
+ Hits 19403 19596 +193
- Misses 16058 16104 +46
- Partials 1316 1325 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
This PR is to add hd path selection drop down to Ledger Account selector screen to sync with Extension ledger features.
this PR has added following changes:
hd path
selection drop down list intoLedgerSelectAccount.ts
Related issues
Fixes: #10678
Manual testing steps
ledger live
path in drop down in metamask extensionNext
orPrevious
button and cnofirm that the account lists are same in both mobile and extensions.BIP44
orlegacy address
list in both extensions and mobile. make sure mobile list matched the extensions list in both selection.unlock
to make sure all accounts can be imported correctly.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist