Android OnPress Event Issue

[sethkfman]

What is this about?

Issue Summary:

Users of MetaMask mobile app, on Android, have been facing intermittent issues with button taps within scrollable views not being registered correctly. This problem seems to stem from a broader issue with React Native's handling of touchables in scrollable components, particularly after the integration of the new architecture (Fabric).

Related GitHub Issues:

• Main Issue: #18147 - Button taps not being registered intermittently in scrollable views on Android.
• Related Issues:
  • #17269 - Similar button interaction issues.
  • #18456 - Flagged as a release blocker.
  • #18458 - Another critical issue related to button taps.

Root Cause Analysis (RCA):

• Integration of Fabric: The issues became prominent after the integration of React Native's new architecture, Fabric, as outlined in PR #15363, which suggests that the new architecture might be affecting touchable functionality in scrollable areas.
• React Native Issues: Several issues have been reported in the React Native repository indicating problems with touchables:
  • react-native#34999
  • react-native#36710
  • react-native#51621 which links to a PR (react-native#51835) that supposedly fixes the issue.

Current Status:

• Mitigations: The MetaMask team has attempted to implement various mitigation measures to address the button tap issues, including tweaks in touchable configurations. However, these efforts have not fully resolved the problem, with intermittent failures still reported.
• Need for Permanent Fix: The team has recognized that the mitigation measures are temporary and that a permanent solution should likely come from adjustments or fixes within the React Native framework itself, particularly the verification and potential integration of the changes proposed in react-native#51835.

Actions Taken:

• Efforts are ongoing to address these issues, with multiple PRs submitted for potential fixes and mitigations. The team is actively discussing the problem and testing solutions, as seen in the conversation threads and pull requests linked above.
  This summarizes the primary concerns and actions regarding the button tap issues in MetaMask's mobile application as they relate to recent developments and discussions within the team and the broader React Native community.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

• Engineering (needed in most cases)
• Design
• Product
• QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• Security
• Legal
• Marketing
• Management (please specify)
• Other (please specify)

References

No response