[Bug]: Duplicate accounts in the vault break some user actions

[mikesposito]

Describe the bug

Duplicating accounts should now be impossible, though existing users with duplicates in the vault will be able to log in, but won't have a functioning wallet.

Expected behavior

Duplicates in the vault shouldn't break wallet functionality, and shouldn't be visible in the accounts menu

Screenshots/Recordings

No response

Steps to reproduce

1. Switch to a release branch older than 7.41.0, build locally, and install the app on an emulator or phisical testing device.
2. Onboard with an SRP of which we know the second account (child guilt hollow arrive average popular nasty soon summer like scheme diary pill country rapid)
3. Import an account that is part of the mnemonic ( 0x80842b7e3cfb1118e86a427cdec418e3b4179ef5bbbfd71c02a76349831c8a8b which is the account at index 2 of the above SRP)
4. Add a new account on the main HD
5. Switch to the 7.46.0 branch, and refresh the app on the device
6. Unlock the wallet, you should see duplicates in your accounts list and you won't be able to add new accounts

Error messages or log output

May be visible in the logs:

KeyringController - The account you are trying to import is a duplicate

Detection stage

In production (default)

Version

<7.47.0

Build type

None

Device

All

Operating system

iOS, Android

Additional context

No response

Severity

No response

[github-actions]

Hi @mikesposito,

This issue has been closed. Please complete this RCA form:
https://docs.google.com/forms/d/e/1FAIpQLSdnPbJISzFlR_aQD2uRpnMKSoGAopuTd_yeZK7J4Q5GzgbsOA/viewform?entry.340898780=15437&entry.1228565618=&entry.1698032149=team-wallet-framework