Skip to content

Commit

Permalink
chore: Remove unnecessary resolutions (#8803)
Browse files Browse the repository at this point in the history 
## **Description**

A number of resolutions were found to have zero impact upon the
lockfile, i.e. they were completely ineffectual. They still pose a risk
of breaking in the future as dependencies are added and updated, so
these unnecessary resolutions have been removed.

## **Related issues**

N/A

## **Manual testing steps**

N/A, the `yarn.lock` file should suffice as evidence that this has no
affect upon the application or tests or anything.

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [x] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
@Gudahtt
Gudahtt authored Mar 1, 2024
1 parent 178cf04 commit e0698b6
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 34 deletions.
21 changes: 1 addition & 20 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -111,56 +111,37 @@
"minimatch": "5.1.0",
"**/nanoid": "^3.1.31",
"**/json-schema": "^0.4.0",
"@sentry/react-native/**/xmldom": "^0.6.0",
"@sentry/**/simple-plist": "^1.3.1",
"@sideway/formula": "3.0.1",
"react-native/**/simple-plist": "^1.3.1",
"react-native-svg/**/nth-check": "^2.0.1",
"**/set-value": "^4.0.1",
"**/pac-resolver": "^5.0.0",
"**/ansi-regex": "^5.0.1",
"**/immer": "^9.0.6",
"**/node-fetch": "^2.6.7",
"**/node-notifier": "^8.0.1",
"**/cookiejar": "2.1.4",
"**/lodash": "^4.17.21",
"**/ua-parser-js": "^0.7.33",
"**/elliptic": "^6.5.4",
"**/y18n": "^3.2.2",
"pubnub/**/netmask": "^2.0.1",
"**/vm2": ">=3.9.17",
"**/xml2js": ">=0.5.0",
"**/optimist/minimist": "^1.2.5",
"react-native-level-fs/**/bl": "^1.2.3",
"react-native-level-fs/levelup/semver": "^5.7.2",
"@metamask/contract-metadata": "^2.1.0",
"@metamask/approval-controller": "3.4.0",
"@exodus/react-native-payments/validator": "^13.7.0",
"react-devtools-core": "4.28.4",
"**/got": "^11.8.5",
"**/qs": "6.10.3",
"simple-get": "4.0.1",
"shell-quote": "1.7.3",
"socket.io-parser": "4.2.3",
"**/plist": "3.0.5",
"**/minimist": "1.2.6",
"**/hermes-engine": "0.10.0",
"@metamask/**/cross-fetch": "2.2.6",
"react-native-gesture-handler/**/cross-fetch": "3.1.5",
"@storybook/addon-actions/**/prismjs": "^1.27.0",
"@storybook/addon-actions/**/highlight.js": "^10.4.1",
"react-native-svg-asset-plugin/sharp": "^0.30.5",
"detox/**/moment": "^2.29.4",
"d3-color": "3.1.0",
"**/fast-xml-parser": "4.2.4",
"tough-cookie": "4.1.3",
"crypto-js": "4.2.0",
"browserify-sign": "4.2.2",
"@metamask/preferences-controller": "^4.0.0",
"axios": "1.6.0",
"@metamask/assets-controllers/babel-runtime/regenerator-runtime": "^0.13.8",
"react-native-ble-plx": "3.1.1",
"follow-redirects": "1.15.4"
"react-native-ble-plx": "3.1.1"
},
"dependencies": {
"@consensys/ledgerhq-metamask-keyring": "^0.0.7",
Expand Down
28 changes: 14 additions & 14 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5765,7 +5765,7 @@
dependencies:
"@hapi/hoek" "^9.0.0"

"@sideway/formula@3.0.1", "@sideway/formula@^3.0.0":
"@sideway/formula@^3.0.0":
version "3.0.1"
resolved "https://registry.yarnpkg.com/@sideway/formula/-/formula-3.0.1.tgz#80fcbcbaf7ce031e0ef2dd29b1bfc7c3f583611f"
integrity sha512-/poHZJJVjx3L+zVD6g9KgHfYnb443oi7wLu/XKojDviHy6HOEOA6z1Trk5aR1dGcmPenJEgb2sK2I80LeS3MIg==
Expand Down Expand Up @@ -11968,7 +11968,7 @@ browserify-rsa@^4.0.0, browserify-rsa@^4.1.0:
bn.js "^5.0.0"
randombytes "^2.0.1"

browserify-sign@4.2.2, browserify-sign@^4.0.0, browserify-sign@^4.0.4:
browserify-sign@^4.0.0, browserify-sign@^4.0.4:
version "4.2.2"
resolved "https://registry.yarnpkg.com/browserify-sign/-/browserify-sign-4.2.2.tgz#e78d4b69816d6e3dd1c747e64e9947f9ad79bc7e"
integrity sha512-1rudGyeYY42Dk6texmv7c4VcQ0EsvVbLwZkA+AQB7SxvXxmcD93jcHie8bzecJ+ChDlmAm2Qyu0+Ccg5uhZXCg==
Expand Down Expand Up @@ -13120,7 +13120,7 @@ cookie@0.5.0:
resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.5.0.tgz#d1f5d71adec6558c58f389987c366aa47e994f8b"
integrity sha512-YZ3GUyn/o8gfKJlnlX7g7xq4gyO6OSuhGPKaaGssGB2qgDUS0gPgtTvoyZLTt9Ab6dC4hfc9dV5arkvc/OCmrw==

cookiejar@2.1.4, cookiejar@^2.1.1:
cookiejar@^2.1.1:
version "2.1.4"
resolved "https://registry.yarnpkg.com/cookiejar/-/cookiejar-2.1.4.tgz#ee669c1fea2cf42dc31585469d193fef0d65771b"
integrity sha512-LDx6oHrK+PhzLKJU9j5S7/Y3jM/mUHvD/DeI1WQmJn652iPC5Y4TBzC9l+5OMOXlyTTA+SmVUPm0HQUwpD5Jqw==
Expand Down Expand Up @@ -16255,7 +16255,7 @@ fast-url-parser@1.1.3:
dependencies:
punycode "^1.3.2"

fast-xml-parser@4.2.4, fast-xml-parser@^4.0.12, fast-xml-parser@^4.1.3:
fast-xml-parser@^4.0.12, fast-xml-parser@^4.1.3:
version "4.2.4"
resolved "https://registry.yarnpkg.com/fast-xml-parser/-/fast-xml-parser-4.2.4.tgz#6e846ede1e56ad9e5ef07d8720809edf0ed07e9b"
integrity sha512-fbfMDvgBNIdDJLdLOwacjFAPYt67tr31H9ZhWSm45CDAxvd0I6WTlSOUo7K2P/K5sA5JgMKG64PI3DMcaFdWpQ==
Expand Down Expand Up @@ -16551,7 +16551,7 @@ focus-lock@^0.10.1:
dependencies:
tslib "^2.0.3"

follow-redirects@1.15.4, follow-redirects@^1.15.0:
follow-redirects@^1.15.0:
version "1.15.4"
resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.15.4.tgz#cdc7d308bf6493126b17ea2191ea0ccf3e535adf"
integrity sha512-Cr4D/5wlrb0z9dgERpUL3LrmPKVDsETIJhaCMeDfuFYcqa5bldGV6wBsAN6X/vxlXQtFBMrXdXxdL8CbDTGniw==
Expand Down Expand Up @@ -17173,7 +17173,7 @@ gopd@^1.0.1:
dependencies:
get-intrinsic "^1.1.3"

got@^11.0.2, got@^11.8.1, got@^11.8.5:
got@^11.0.2, got@^11.8.1:
version "11.8.5"
resolved "https://registry.yarnpkg.com/got/-/got-11.8.5.tgz#ce77d045136de56e8f024bebb82ea349bc730046"
integrity sha512-o0Je4NvQObAuZPHLFoRSkdG2lTgtcynqymzg2Vupdx6PorhaT5MCbIyXG6d4D94kk8ZG57QeosgdiqfJWhEhlQ==
Expand Down Expand Up @@ -20913,7 +20913,7 @@ moment-timezone@^0.5.26, moment-timezone@^0.x:
dependencies:
moment ">= 2.9.0"

moment@2.29.4, "moment@>= 2.9.0", moment@^2.19.3, moment@^2.24.0, moment@^2.29.4:
moment@2.29.4, "moment@>= 2.9.0", moment@^2.19.3, moment@^2.24.0:
version "2.29.4"
resolved "https://registry.yarnpkg.com/moment/-/moment-2.29.4.tgz#3dbe052889fe7c1b2ed966fcb3a77328964ef108"
integrity sha512-5LC9SOxjSc2HF6vO2CyuTDNivEdoz2IvyJJGj6X8DJ0eFyfszE0QiEd+iXmBvUP3WHxSjFH/vIsA0EN00cgr8w==
Expand Down Expand Up @@ -21142,7 +21142,7 @@ neo-async@^2.5.0, neo-async@^2.6.0, neo-async@^2.6.2:
resolved "https://registry.yarnpkg.com/neo-async/-/neo-async-2.6.2.tgz#b4aafb93e3aeb2d8174ca53cf163ab7d7308305f"
integrity sha512-Yd3UES5mWCSqR+qNT93S3UoYUkqAZ9lLg8a7g9rimsWmYGK8cVToA4/sF3RrshdyV3sAGMXVUmpMYOw+dLpOuw==

netmask@^2.0.1, netmask@^2.0.2:
netmask@^2.0.2:
version "2.0.2"
resolved "https://registry.yarnpkg.com/netmask/-/netmask-2.0.2.tgz#8b01a07644065d536383835823bc52004ebac5e7"
integrity sha512-dBpDMdxv9Irdq66304OLfEmQ9tbNRFnFTuZiLo+bD+r332bBmMJ8GBLXklIXXgxd3+v9+KUnZaUR5PJMa75Gsg==
Expand Down Expand Up @@ -22738,7 +22738,7 @@ printj@~1.1.0:
resolved "https://registry.yarnpkg.com/printj/-/printj-1.1.2.tgz#d90deb2975a8b9f600fb3a1c94e3f4c53c78a222"
integrity sha512-zA2SmoLaxZyArQTOPj5LXecR+RagfPSU5Kw1qP+jkWeNlrq+eJZyY2oS68SU1Z/7/myXM4lo9716laOFAVStCQ==

prismjs@^1.27.0, prismjs@^1.8.4:
prismjs@^1.8.4:
version "1.28.0"
resolved "https://registry.yarnpkg.com/prismjs/-/prismjs-1.28.0.tgz#0d8f561fa0f7cf6ebca901747828b149147044b6"
integrity sha512-8aaXdYvl1F7iC7Xm1spqSaY/OJBpYW3v+KJ+F17iYxvdc8sfjW194COK5wVhMZX45tGteiBQgdvD/nhxcRwylw==
Expand Down Expand Up @@ -23288,7 +23288,7 @@ react-colorful@^5.1.2:
resolved "https://registry.yarnpkg.com/react-colorful/-/react-colorful-5.6.1.tgz#7dc2aed2d7c72fac89694e834d179e32f3da563b"
integrity sha512-1exovf0uGTGyq5mXQT0zgQ80uvj2PCwvF8zY1RN9/vbJVSjSo3fsB/4L3ObbF7u70NduSiK4xu4Y6q1MHoUGEw==

react-devtools-core@4.28.4, react-devtools-core@^4.26.1:
react-devtools-core@^4.26.1:
version "4.28.4"
resolved "https://registry.yarnpkg.com/react-devtools-core/-/react-devtools-core-4.28.4.tgz#fb8183eada77093f4c2f9830e664bf22255abe27"
integrity sha512-IUZKLv3CimeM07G3vX4H4loxVpByrzq3HvfTX7v9migalwvLs9ZY5D3S3pKR33U+GguYfBBdMMZyToFhsSE/iQ==
Expand Down Expand Up @@ -25395,7 +25395,7 @@ simple-get@4.0.1, simple-get@^3.0.3, simple-get@^4.0.0, simple-get@^4.0.1:
once "^1.3.1"
simple-concat "^1.0.0"

simple-plist@^1.1.0, simple-plist@^1.3.1:
simple-plist@^1.1.0:
version "1.3.1"
resolved "https://registry.yarnpkg.com/simple-plist/-/simple-plist-1.3.1.tgz#16e1d8f62c6c9b691b8383127663d834112fb017"
integrity sha512-iMSw5i0XseMnrhtIzRb7XpQEXepa9xhWxGUojHBL43SIpQuDQkh3Wpy67ZbDzZVr6EKxvwVChnVpdl8hEVLDiw==
Expand Down Expand Up @@ -25513,7 +25513,7 @@ socket.io-client@^4.5.1, socket.io-client@^4.5.3:
engine.io-client "~6.4.0"
socket.io-parser "~4.2.1"

socket.io-parser@4.2.3, socket.io-parser@~4.2.1:
socket.io-parser@~4.2.1:
version "4.2.3"
resolved "https://registry.yarnpkg.com/socket.io-parser/-/socket.io-parser-4.2.3.tgz#926bcc6658e2ae0883dc9dee69acbdc76e4e3667"
integrity sha512-JMafRntWVO2DCJimKsRTh/wnqVvO4hrfwOqtO7f+uzwsQMuxO6VwImtYxaQ+ieoyshWOTJyV0fA21lccEXRPpQ==
Expand Down Expand Up @@ -27345,7 +27345,7 @@ vm-browserify@1.1.2:
resolved "https://registry.yarnpkg.com/vm-browserify/-/vm-browserify-1.1.2.tgz#78641c488b8e6ca91a75f511e7a3b32a86e5dda0"
integrity sha512-2ham8XPWTONajOR0ohOKOHXkm3+gaBmGut3SRuu75xLd/RRaY6vqgh8NBYYk7+RW3u5AtzPQZG8F10LHkl0lAQ==

vm2@>=3.9.17, vm2@^3.9.17:
vm2@^3.9.17:
version "3.9.19"
resolved "https://registry.yarnpkg.com/vm2/-/vm2-3.9.19.tgz#be1e1d7a106122c6c492b4d51c2e8b93d3ed6a4a"
integrity sha512-J637XF0DHDMV57R6JyVsTak7nIL8gy5KH4r1HiwWLf/4GBbb5MKL5y7LpmF4A8E2nR6XmzpmMFQ7V7ppPTmUQg==
Expand Down Expand Up @@ -28067,7 +28067,7 @@ xmlbuilder@~11.0.0:
resolved "https://registry.yarnpkg.com/xmlbuilder/-/xmlbuilder-11.0.1.tgz#be9bae1c8a046e76b31127726347d0ad7002beb3"
integrity sha512-fDlsI/kFEx7gLvbecc0/ohLG50fugQp8ryHzMTuW9vSa1GJ0XYWKnhsUx7oie3G98+r56aTQIUB4kht42R3JvA==

xmldom@^0.6.0, xmldom@^0.x:
xmldom@^0.x:
version "0.6.0"
resolved "https://registry.yarnpkg.com/xmldom/-/xmldom-0.6.0.tgz#43a96ecb8beece991cef382c08397d82d4d0c46f"
integrity sha512-iAcin401y58LckRZ0TkI4k0VSM1Qg0KGSc3i8rU+xrxe19A/BN1zHyVSJY7uoutVlaTSzYyk/v5AmkewAP7jtg==
Expand Down

0 comments on commit e0698b6

Please sign in to comment.