Skip to content

Commit 9e3d268

Browse files
authored
fix: Duplicate key in Settings and Privacy (#11664)
## **Description** ``` ERROR Warning: Encountered two children with the same key, `0x89`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version. ``` ## **Related issues** Fixes: No issue, found while developing ## **Manual testing steps** 1. Add Polygon, and add a custom RPC Polygon 2. Go to Network Settings 3. Should not see duplicate key error in logs ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 368fc19 commit 9e3d268

File tree

1 file changed

+2
-2
lines changed
  • app/components/Views/Settings/IncomingTransactionsSettings

1 file changed

+2
-2
lines changed

app/components/Views/Settings/IncomingTransactionsSettings/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ const IncomingTransactionsSettings = () => {
9494
supportedNetworks[chainId as keyof typeof supportedNetworks].domain;
9595
return (
9696
<NetworkCell
97-
key={chainId}
97+
key={`${nickname}-${chainId}`}
9898
name={name}
9999
chainId={chainId as EtherscanSupportedHexChainId}
100100
imageSource={image}
@@ -116,7 +116,7 @@ const IncomingTransactionsSettings = () => {
116116
supportedNetworks[chainId as keyof typeof supportedNetworks].domain;
117117
return (
118118
<NetworkCell
119-
key={chainId}
119+
key={`${name}-${chainId}`}
120120
name={name}
121121
chainId={chainId as keyof typeof supportedNetworks}
122122
imageSource={imageSource as ImageSourcePropType}

0 commit comments

Comments
 (0)