fix: Duplicate key in Settings and Privacy

[gambinish]

Description

ERROR  Warning: Encountered two children with the same key, `0x89`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.

Related issues

Fixes: No issue, found while developing

Manual testing steps

1. Add Polygon, and add a custom RPC Polygon
2. Go to Network Settings
3. Should not see duplicate key error in logs

Screenshots/Recordings

N/A

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8917aed
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/530ba2fc-4578-4ea8-ae7d-e935550b9340

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[tommasini]

LGTM! I believe this will change by Network Controller upgrade!

[andreahaku]

LGTM

[NicolasMassart]

should line 712 also be fixed?

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0aa3794
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e7bad620-aadf-4976-aa3c-f40a4bbe999b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.13%. Comparing base (bda40a6) to head (46d323f).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11664      +/-   ##
==========================================
+ Coverage   54.02%   54.13%   +0.11%     
==========================================
  Files        1679     1687       +8     
  Lines       38500    38533      +33     
  Branches     4702     4703       +1     
==========================================
+ Hits        20798    20859      +61     
+ Misses      16266    16236      -30     
- Partials     1436     1438       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NicolasMassart]

Looks good to me. Thanks!

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 46d323f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0d8a6aa5-bb63-4fb8-89b2-14f51e5a0f9c

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud