fix: Remove stateless "non-controllers" from background engine state (#12348)

## **Description**

The engine context and background state currently include three
"non-controllers" with empty/non-existent state:
`AssetsContractController`, `NftDetectionController`,
`TokenDetectionController`.

These should be included in the engine context, but excluded from any
representations of background state. This is not a disruptive change, as
there are no downstream references to the state objects or state
properties of these non-controllers.

For more information on non-controllers, see:
-
https://github.com/MetaMask/decisions/blob/main/decisions/core/0001-messaging-non-controllers.md
-
https://github.com/MetaMask/decisions/blob/messaging-components-abstraction/decisions/core/0004-messaging-components-abstraction.md#background

## **Related issues**

- Blocks #10441
- This ticket will remove non-controller entries from the engine
datamodel and state getter method.

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: MajorLift

app/core/Engine/Engine.ts

@@ -2050,7 +2050,6 @@ export default {
     const {
       AccountTrackerController,
       AddressBookController,
-      AssetsContractController,
       NftController,
       TokenListController,
       CurrencyRateController,
@@ -2066,8 +2065,6 @@ export default {
       SwapsController,
       GasFeeController,
       TokensController,
-      TokenDetectionController,
-      NftDetectionController,
       ///: BEGIN:ONLY_INCLUDE_IF(preinstalled-snaps,external-snaps)
       SnapController,
       SubjectMetadataController,
@@ -2096,7 +2093,6 @@ export default {
     return {
       AccountTrackerController,
       AddressBookController,
-      AssetsContractController,
       NftController,
       TokenListController,
       CurrencyRateController: modifiedCurrencyRateControllerState,
@@ -2112,8 +2108,6 @@ export default {
       SmartTransactionsController,
       SwapsController,
       GasFeeController,
-      TokenDetectionController,
-      NftDetectionController,
       ///: BEGIN:ONLY_INCLUDE_IF(preinstalled-snaps,external-snaps)
       SnapController,
       SubjectMetadataController,

app/core/Engine/types.ts

@@ -158,7 +158,6 @@ import {
   AccountsControllerEvents,
   AccountsControllerState,
 } from '@metamask/accounts-controller';
-import { BaseState } from '@metamask/base-controller';
 import { getPermissionSpecifications } from '../Permissions/specifications.js';
 
 /**
@@ -325,7 +324,6 @@ export type EngineContext = RequiredControllers & Partial<OptionalControllers>;
 export interface EngineState {
   AccountTrackerController: AccountTrackerControllerState;
   AddressBookController: AddressBookControllerState;
-  AssetsContractController: BaseState;
   NftController: NftControllerState;
   TokenListController: TokenListState;
   CurrencyRateController: CurrencyRateState;
@@ -340,8 +338,6 @@ export interface EngineState {
   SwapsController: SwapsControllerState;
   GasFeeController: GasFeeState;
   TokensController: TokensControllerState;
-  TokenDetectionController: BaseState;
-  NftDetectionController: BaseState;
   ///: BEGIN:ONLY_INCLUDE_IF(preinstalled-snaps,external-snaps)
   SnapController: PersistedSnapControllerState;
   SnapsRegistry: SnapsRegistryState;

app/core/EngineService/EngineService.ts

@@ -68,14 +68,6 @@ class EngineService {
         name: 'TokensController',
         key: `${engine.context.TokensController.name}:stateChange`,
       },
-      {
-        name: 'TokenDetectionController',
-        key: `${engine.context.TokenDetectionController.name}:stateChange`,
-      },
-      {
-        name: 'NftDetectionController',
-        key: 'NftDetectionController:stateChange',
-      },
       {
         name: 'KeyringController',
         key: `${engine.context.KeyringController.name}:stateChange`,

app/selectors/types.ts

@@ -1,9 +1,7 @@
 import {
   AccountTrackerControllerState,
   CurrencyRateState,
-  NftDetectionController,
   NftControllerState,
-  TokenDetectionController,
   TokenListState,
   TokenRatesControllerState,
   TokensControllerState,
@@ -12,7 +10,6 @@ import {
 import SwapsController from '@metamask/swaps-controller';
 import { NetworkState } from '@metamask/network-controller';
 import { AddressBookControllerState } from '@metamask/address-book-controller';
-import { BaseState } from '@metamask/base-controller';
 import { KeyringControllerMemState } from '@metamask/keyring-controller';
 import { PreferencesState } from '@metamask/preferences-controller';
 import { PhishingControllerState } from '@metamask/phishing-controller';
@@ -29,7 +26,6 @@ export interface EngineState {
     backgroundState: {
       AccountTrackerController: AccountTrackerControllerState;
       AddressBookController: AddressBookControllerState;
-      AssetsContractController: BaseState;
       NftController: NftControllerState;
       TokenListController: TokenListState;
       CurrencyRateController: CurrencyRateState;
@@ -47,8 +43,6 @@ export interface EngineState {
       ///: END:ONLY_INCLUDE_IF
       GasFeeController: GasFeeController;
       TokensController: TokensControllerState;
-      TokenDetectionController: TokenDetectionController;
-      NftDetectionController: NftDetectionController;
       ApprovalController: ApprovalControllerState;
       AccountsController: AccountsControllerState;
     };

app/util/sentry/__snapshots__/utils.test.ts.snap

@@ -44,7 +44,6 @@ exports[`captureSentryFeedback maskObject masks initial root state fixture 1`] =
         "pendingApprovalCount": "number",
         "pendingApprovals": "object",
       },
-      "AssetsContractController": {},
       "CurrencyRateController": {
         "currencyRates": {
           "ETH": {
@@ -87,7 +86,6 @@ exports[`captureSentryFeedback maskObject masks initial root state fixture 1`] =
         "allNfts": "object",
         "ignoredNfts": "object",
       },
-      "NftDetectionController": "object",
       "PermissionController": {},
       "PreferencesController": {
         "displayNftMedia": true,

app/util/sentry/utils.js

@@ -41,7 +41,6 @@ export const sentryStateMask = {
       ApprovalController: {
         [AllProperties]: false,
       },
-      AssetsContractController: {},
       CurrencyRateController: {
         currencyRates: true,
         currentCurrency: true,
@@ -137,9 +136,6 @@ export const sentryStateMask = {
           swapsUserFeeLevel: true,
         },
       },
-      TokenDetectionController: {
-        [AllProperties]: false,
-      },
       TokenListController: {
         preventPollingOnNetworkRestart: true,
         tokensChainsCache: {

app/util/sentry/utils.test.ts

@@ -192,7 +192,6 @@ describe('captureSentryFeedback', () => {
             pendingApprovalCount: 0,
             pendingApprovals: {},
           },
-          AssetsContractController: {},
           CurrencyRateController: {
             currencyRates: {
               ETH: {
@@ -240,7 +239,6 @@ describe('captureSentryFeedback', () => {
             allNfts: {},
             ignoredNfts: [],
           },
-          NftDetectionController: {},
           PermissionController: undefined,
           PreferencesController: {
             displayNftMedia: true,

e2e/fixtures/fixture-builder.js

@@ -82,7 +82,6 @@ class FixtureBuilder {
             AddressBookController: {
               addressBook: {},
             },
-            AssetsContractController: {},
             NftController: {
               allNftContracts: {},
               allNfts: {},
@@ -411,8 +410,6 @@ class FixtureBuilder {
               gasFeeEstimatesByChainId: {},
               nonRPCGasFeeApisDisabled: false,
             },
-            TokenDetectionController: {},
-            NftDetectionController: {},
             PermissionController: {
               subjects: {},
             },