Skip to content

fix: Remove stateless "non-controllers" from background engine state #12348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 1, 2024
Merged

fix: Remove stateless "non-controllers" from background engine state #12348

merged 7 commits into from
Dec 1, 2024
+0 −35

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Nov 20, 2024 •
edited
Loading

Description

The engine context and background state currently include three "non-controllers" with empty/non-existent state: AssetsContractController, NftDetectionController, TokenDetectionController.

These should be included in the engine context, but excluded from any representations of background state. This is not a disruptive change, as there are no downstream references to the state objects or state properties of these non-controllers.

For more information on non-controllers, see:

Related issues

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MajorLift MajorLift added team-wallet-framework team-tiger Tiger team (for tech debt reduction + performance improvements) labels Nov 20, 2024
@MajorLift MajorLift self-assigned this Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MajorLift MajorLift mentioned this pull request Nov 20, 2024
Merged
7 tasks
@MajorLift MajorLift force-pushed the jongsun/fix/background-state/241120-remove-noncontrollers branch from 5a7c4ec to 875457e Compare November 20, 2024 10:18
@MajorLift MajorLift added the Run Smoke E2E Requires smoke E2E testing label Nov 20, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@MajorLift MajorLift force-pushed the jongsun/fix/background-state/241120-remove-noncontrollers branch from 85c17e1 to b2d0f25 Compare November 20, 2024 15:36
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch 9 times, most recently from bb1f60a to 6846d79 Compare November 21, 2024 18:10
@MajorLift MajorLift closed this Nov 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@MajorLift MajorLift reopened this Nov 22, 2024
@MajorLift MajorLift force-pushed the jongsun/fix/background-state/241120-remove-noncontrollers branch from b2d0f25 to a5229a4 Compare November 22, 2024 17:32
@MajorLift MajorLift added Run Smoke E2E Requires smoke E2E testing team-tiger Tiger team (for tech debt reduction + performance improvements) and removed Run Smoke E2E Requires smoke E2E testing team-tiger Tiger team (for tech debt reduction + performance improvements) labels Nov 22, 2024
@MajorLift MajorLift changed the base branch from jongsun/fix-composable-controller to main November 22, 2024 17:35
@github-actions github-actions bot unlocked this conversation Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a5229a4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/18c382c2-05f2-4b8e-9588-1e5c0f749011

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

MajorLift
MajorLift commented Nov 22, 2024
View reviewed changes
Copy link
Contributor Author

@MajorLift MajorLift left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation: this fixes inconsistent treatment of non-controllers and their state objects/types.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 188dd6c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5bccc333-7e27-432b-9355-9d9b76a82bb7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MajorLift MajorLift added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 696dea8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e5a71919-7fd4-4876-9695-0803c5c81ba6

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MajorLift MajorLift force-pushed the jongsun/fix/background-state/241120-remove-noncontrollers branch from 696dea8 to f8da985 Compare November 26, 2024 11:59
@MajorLift MajorLift force-pushed the jongsun/fix/background-state/241120-remove-noncontrollers branch from f8da985 to 16da771 Compare November 26, 2024 12:00
@MajorLift MajorLift added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 16da771
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/18eaa37f-6fcc-409b-9d01-5ce34b56a135

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MajorLift MajorLift added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5e7c593
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/86c9c9ac-e2b9-4126-98a6-b2cda41c8ddd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mcmire
mcmire approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Gudahtt
Gudahtt approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job splitting up this work

Cal-L
Cal-L approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@MajorLift MajorLift added this pull request to the merge queue Dec 1, 2024
Merged via the queue into main with commit 1a83b1f Dec 1, 2024
43 checks passed
@MajorLift MajorLift deleted the jongsun/fix/background-state/241120-remove-noncontrollers branch December 1, 2024 08:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcmire mcmire mcmire approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@Cal-L Cal-L Cal-L approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

@MajorLift MajorLift

Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Requires smoke E2E testing team-tiger Tiger team (for tech debt reduction + performance improvements) team-wallet-framework
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MajorLift @mcmire @Gudahtt @Cal-L @tommasini @metamaskbot