Improve Korean translations #6268

bowbowbow · 2019-03-08T14:28:57Z

This PR adds missing strings and improves Korean translations.
@nujabes403 @x86kernel Would you review this?

Some of the key order was changed based on develop/app/_locales/en/messages.json.

nujabes403 · 2019-03-08T15:13:14Z

app/_locales/ko/messages.json

The postfix of $1 could be guaranteed as "를" instead of "을"?

Because $1 is "토큰 추가" in the metamask of develop branch, "를" is more natural as the postfix of "토큰 추가".

nujabes403 · 2019-03-08T15:14:02Z

app/_locales/ko/messages.json

Could you translate this one too?

How about $1에 업데이트 됨?

nujabes403 · 2019-03-08T17:05:09Z

app/_locales/ko/messages.json

Could you translate this one too?

How about 보내는 이?

It is difficult to find which screen "Transfer From" is displayed on, so I am not sure if it is a correct translation.

nujabes403 · 2019-03-08T17:05:40Z

app/_locales/ko/messages.json

How about "토큰 컨트랙트 주소"?

That's good :)

nujabes403 · 2019-03-08T17:06:09Z

app/_locales/ko/messages.json

이 구문을 "1Password" 같은 암호 관리자에 저장하세요.

I'll fix it

nujabes403 · 2019-03-08T17:06:24Z

app/_locales/ko/messages.json

How about "네트워크 변경"?

네트워크 변경 seems more natural.

nujabes403 · 2019-03-08T17:06:30Z

app/_locales/ko/messages.json

속소 -> 속도

I'll fix it. Thank you for finding typo.

nujabes403 · 2019-03-08T17:06:48Z

app/_locales/ko/messages.json

Please translate this one too.

How about 속도 향상?

nujabes403 · 2019-03-08T17:06:54Z

app/_locales/ko/messages.json

Please translate this one too.

How about 헉! 뭔가 잘못됐어요. ?

nujabes403 · 2019-03-08T17:07:36Z

app/_locales/ko/messages.json

This sentence doesn't have a word for Fiat

👍 I will fix it

nujabes403 · 2019-03-08T17:07:53Z

app/_locales/ko/messages.json

How about "초"?

nujabes403 · 2019-03-08T17:08:04Z

app/_locales/ko/messages.json

Please translate this one too.

How about 요청이 인정되기까지 대기중?

nujabes403 · 2019-03-08T17:08:52Z

app/_locales/ko/messages.json

How about "기록하세요."?

How about 기억하세요.?

nujabes403 · 2019-03-08T17:09:06Z

app/_locales/ko/messages.json

Please translate this one too.

I had translate this literally, but it got awkward. (우린 당신을 만나서 행복합니다.)

Why don't you just leave it there instead of translating it? It is natural enough to see such english sentence in Korea.

Yes you're right. Leave this sentence then :)

nujabes403 · 2019-03-08T17:09:13Z

app/_locales/ko/messages.json

Please translate this one too.

I'll change it to 가스 가격.

nujabes403 · 2019-03-08T17:09:22Z

app/_locales/ko/messages.json

Please translate this one too.

How about 가스 가격은 가스 1당 지불할 이더의 양을 명시합니다.?

That can be misunderstood for saying "이더" directly. I recommend to tell user the default unit of ether for paying gas price, for example, gwei.

That's a good point.

How about 가스 가격은 가스 1당 지불할 gwei 단위의 이더 수량을 명시합니다.?

nujabes403 · 2019-03-08T17:09:36Z

app/_locales/ko/messages.json

Please translate this one too.

How about 취소됨?

nujabes403 · 2019-03-08T17:09:39Z

app/_locales/ko/messages.json

Please translate this one too.

How about 베이직?

I don't know which context this is used in too..
How about letting it be without translating it.

nujabes403 · 2019-03-08T17:10:44Z

Thank you for your translation! It would be good for you to fill some missing translation also. :)

nujabes403 · 2019-03-09T07:16:28Z

@bowbowbow LGTM 👍👍👍🎉

cc.) @whymarrh :)

bowbowbow · 2019-03-11T16:48:33Z

@nujabes403
How can I solve the unsuccessful checks of circleci?
Failed test seems to be related to the npm environments. :)

whymarrh · 2019-03-11T18:24:09Z

@bowbowbow I'll take a look at the build, it might have been a temporary issue

whymarrh

Thanks @bowbowbow and @nujabes403 ❤️

* Fixes the 'Percentages row tracks and gutters' decpracation warning. (#6244) * Fix missing this reference in addtoken button onclick method (#6245) * Only call onRecipient and onSender methods if defined in sender-to-recipient (#6247) * Prevent advanced gas input arrows from setting value to < 0 (#6248) * Add privacy policy link to modal metrics opt-in (#6250) * Handle undefined gas limits and prices in transaction-breakdown.component (#6246) * Uppercase and context fixes on Spanish translation. * development - enhancement for sourcemap validator tool (#6277) * Nonmultiple notifications for batch txs * No longer check network when validating checksum addresses * Version 6.2.1 (#6251) * Remove line rather than comment out * Fixes the use of the browser back button on the reveal seed screen * GABA: Integrate AddressBookController (#5847) * gaba: integrate AddressBookController * pin gaba version and update lockfile * ci: Use cache version from circle environment var (#6286) * Allow npm to update the package-lock.json file * npm i -D ganache-core@2.5.3 * mascara - remove from project (#6283) * circleci - disable npm dep cache (#6288) * Centre all notification popups * ui - add missing PropTypes (#6287) * Improve Korean translations (#6268) * ci: Use npm ci for fast(er) installs * build - babel - move config to babelrc (#6284) * Patch/bump version (#6294) * Update Node minor version * ci: Skip updating npm@6 as it is default * Allow seed phrases with a trailing newline * Centre the notification in the current window (#6307) * Fixes popups not showing when screen size is odd (#6312) * Fix typos in English messages (#6317) * Add rollback script, move auto-changelog script (#6252) * Bump gaba version to avoid broken eth-contract-metadata * Fixing spelling of Ethereum in MetaMetrics copy (#6329) * Stop reloading dapps on network change allowing dapps to decide if it should refresh or not (#6330) * feat: `inpageProvider.autoRefreshOnNetworkChange` to allow dapps to control if it refreshes or not * feat: check the `autoRefreshOnNetworkChange` before a refresh * fix linting error * fix: use `window.ethereum` now `web3.ethereum` * Enable mobile sync (#6332) * enable mobile sync * remove mobile sync as a preference * Fix typo * Folder restructure (#6304) * Remove ui/app/keychains/ * Remove ui/app/img/ (unused images) * Move conversion-util to helpers/utils/ * Move token-util to helpers/utils/ * Move /helpers/*.js inside /helpers/utils/ * Move util tests inside /helpers/utils/ * Renameand move confirm-transaction/util.js to helpers/utils/ * Move higher-order-components to helpers/higher-order-components/ * Move infura-conversion.json to helpers/constants/ * Move all utility functions to helpers/utils/ * Move pages directory to top-level * Move all constants to helpers/constants/ * Move metametrics inside helpers/ * Move app and root inside pages/ * Move routes inside helpers/ * Re-organize ducks/ * Move reducers to ducks/ * Move selectors inside selectors/ * Move test out of test folder * Move action, reducer, store inside store/ * Move ui components inside ui/ * Move UI components inside ui/ * Move connected components inside components/app/ * Move i18n-helper inside helpers/ * Fix unit tests * Fix unit test * Move pages components * Rename routes component * Move reducers to ducks/index * Fix bad path in unit test * Hide gas price chart and prevent api call when not on ethereum networks. (#6300) Add missing translations in gas customization modal * Fix gas fee in the submitted step of the transaction details activity log. (#6301) * Fix oversized loading overlay on gas customization modal. (#6326) * Replaces the coinbase link in the deposit modal with one for wyre (#6302) * New settings page rebased (#6333) * New setting tab * Add InfoTab * Add Advanced tab * Add Security Tab * Finish mobile view * Make new setting page responsive * Fix linter * Fix y scrolling * Update link in network dropdown * Fix e2e tests * Remove duplicate translation key * Resolve merge conflict * Only change settings header in popup view. * Place mobile-sync button in advanced-tab of settings * Close transaction on close of notification window (#6340) * Cancel error rebased (#6341) * Check balance before showing cancel * Fix linter * Use existing helper methods for calculating increased cancel price * Add tooltip for disabled button * Lint fix for cancelError branch. * Disabling of cancel button should account for value of tx. * E2E - Dont close window notifications (#6349) * Dont close window notifications * Remove commented out lines in beta spec * Don't include tx value in calculation of balance sufficiency for cancel button disabling. (#6346) * enable privacy mode for first time users (#6347) * Version 6.3.0 (#6350)

nujabes403 reviewed Mar 8, 2019

View reviewed changes

nujabes403 previously approved these changes Mar 9, 2019

View reviewed changes

bowbowbow added 4 commits March 12, 2019 11:37

Improve Korean translations

f970b92

Improve Korean translations

1845354

Add missing strings

f567004

Revise after applying code review.

c69a2dd

whymarrh dismissed nujabes403’s stale review via c69a2dd March 12, 2019 14:07

whymarrh force-pushed the develop branch from faafaf3 to c69a2dd Compare March 12, 2019 14:07

whymarrh approved these changes Mar 12, 2019

View reviewed changes

whymarrh merged commit 4812fdb into MetaMask:develop Mar 12, 2019

Improve Korean translations #6268

Improve Korean translations #6268

Uh oh!

Conversation

bowbowbow commented Mar 8, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bowbowbow Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bowbowbow Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bowbowbow Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bowbowbow Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bowbowbow Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bowbowbow Mar 8, 2019 •

edited

Loading

bowbowbow Mar 8, 2019 •

edited

Loading

bowbowbow Mar 8, 2019 •

edited

Loading

bowbowbow Mar 8, 2019 •

edited

Loading

bowbowbow Mar 8, 2019 •

edited

Loading

bowbowbow Mar 9, 2019 •

edited

Loading