Check balance before showing cancel #6088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chikeichan
force-pushed
the
cancelError
branch
from
818bab1 to
a2f2894
Compare
chikeichan
force-pushed
the
cancelError
branch
from
a2f2894 to
cc8adc6
Compare
Contributor
Author
|
|
danjm
approved these changes
Feb 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to make sure that
selectedAccounthas enough balance to cover gas fee for cancel transaction. IfselectedAccountBalanceis less than the gas fee for canceling, it will not render the cancel button.fixes #5927