Skip to content

fix: improve balance fetcher perf#40513

Draft
salimtb wants to merge 1 commit intomainfrom
fix/improve-balance-fetcher
Draft

fix: improve balance fetcher perf#40513
salimtb wants to merge 1 commit intomainfrom
fix/improve-balance-fetcher

Conversation

@salimtb
Copy link
Contributor

@salimtb salimtb commented Mar 1, 2026

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 1, 2026

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (1 files, +1 -7)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-overview/
          • 📄 account-overview-tabs.tsx +1 -7

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -7)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-overview/
          • 📄 account-overview-tabs.tsx +1 -7

@github-actions github-actions bot added the size-M label Mar 1, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2026

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 1, 2026

Builds ready [45bdb48]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account361262504108482504
total361262504108482504
Confirm Txconfirm_tx604560366053660486053
total604560366053660486053
Bridge User Actionsbridge_load_page2132032269215226
bridge_load_asset_picker1971922003198200
bridge_search_token6956936982696698
total1103109211201011021120
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup13761148168610914441551
load1157947144110412311340
domContentLoaded1150929143510412241328
domInteractive271595182470
firstPaint178611237158210309
backgroundConnect19517724811200214
firstReactRender17113741826
initialActions1012112
loadScripts970757126010410431151
setupStore1375271420
numNetworkReqs312296212291
Power User HomeuiStartup17141373239218817702040
load11501012193216511321608
domContentLoaded11321006185415411151585
domInteractive3719169263686
firstPaint196741616174254431
backgroundConnect29125537723297329
firstReactRender21145562232
initialActions103113
loadScripts92180716301529051365
setupStore1686881628
numNetworkReqs55341482455118
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2192162212220221
srpButtonToSrpForm91899319293
confirmSrpToPwForm22212202222
pwFormToMetricsScreen15151601516
metricsToWalletReadyScreen16161601616
doneButtonToHomeScreen831573141633610061416
openAccountMenuToAccountListLoaded74906820805948578528059
total88688597907818990059078
Onboarding New WalletcreateWalletToSocialScreen2222202241223224
srpButtonToPwForm1101081142112114
createPwToRecoveryScreen999099
skipBackupToMetricsScreen39384013940
agreeButtonToOnboardingSuccess17161701717
doneButtonToAssetList56148969983556699
total9578821096849511096
Asset DetailsassetClickToPriceChart37344443644
total37344443644
Solana Asset DetailsassetClickToPriceChart45434824548
total45434824548
Import Srp HomeloginToHomeScreen20931890235716821992357
openAccountMenuAfterLogin41384324143
homeAfterImportWithNewWallet2289220823916823042391
total46464247532438247875324
Send TransactionsopenSendPageFromHome241236103536
selectTokenToSendFormLoaded21192212122
reviewTransactionToConfirmationPage8548498646855864
total9049039051905905
SwapopenSwapPageFromHome9487100596100
fetchAndDisplaySwapQuotes4655459247316147284731
total4756467948306348244830
🌐 Dapp Page Load Benchmarks

Current Commit: 45bdb48 | Date: 3/1/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 736ms (±39ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 81ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 41ms 1.02s 1.34s 1.10s 1.34s
domContentLoaded 736ms 39ms 711ms 1.01s 778ms 1.01s
firstPaint 81ms 11ms 64ms 176ms 88ms 176ms
firstContentfulPaint 81ms 11ms 64ms 176ms 88ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 447 Bytes (0.01%)
  • common: 20 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants