chore: bump RemoteFeatureFlagController#40480
Open
Prithpal-Sooriya wants to merge 9 commits intomainfrom
Open
Conversation
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| getMetaMetricsId: () => | ||
| initMessenger.call('MetaMetricsController:getMetaMetricsId'), | ||
| clientVersion: getBaseSemVerVersion(), | ||
| prevClientVersion, |
Contributor
Author
There was a problem hiding this comment.
New change from 4.1.0. See preview extension PR
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Comment on lines
+1977
to
+1979
| "globals": { | ||
| "TextEncoder": true | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
TextEncoded is now being used in this package version (code)
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (2 files, +7 -3)
🕵️ @MetaMask/extension-privacy-reviewers (1 files, +18 -0)
📜 @MetaMask/policy-reviewers (8 files, +24 -0)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🧪 @MetaMask/qa (4 files, +79 -6)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [9973c22]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json
Show resolved
Hide resolved
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [d4613a2]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
bergarces
previously approved these changes
Feb 27, 2026
…ore/bump-remote-feature-flag-controller
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [69a9694]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Author
|
@metamaskbot update-e2e-fixture |
Comment on lines
+3513
to
+3514
| localOverrides: {}, | ||
| rawRemoteFeatureFlags: {}, |
Contributor
Author
There was a problem hiding this comment.
RemoteFeatureFlagController 4.0.0 has added these additional state properties.
Contributor
Author
There was a problem hiding this comment.
This was modified by @metamaskbot to update fixtures.
| "feature2": false, | ||
| "feature3": { "name": "groupC", "value": "valueC" } | ||
| } | ||
| "feature3": { "name": "groupA", "value": "valueA" } |
Contributor
Author
There was a problem hiding this comment.
Need some confirmation here.
RemoteFeatureFlagController 4.0.0 changes the threshold implementation/logic, hence the changes to the state snapshots.
| "feature1": true, | ||
| "feature2": false, | ||
| "feature3": { "name": "groupC", "value": "valueC" } | ||
| "feature3": { "name": "groupA", "value": "valueA" } |
Contributor
Author
There was a problem hiding this comment.
Need some confirmation here.
RemoteFeatureFlagController 4.0.0 changes the threshold implementation/logic, hence the changes to the state snapshots.
| "feature2": false, | ||
| "feature3": { "name": "groupC", "value": "valueC" } | ||
| } | ||
| "feature3": { "name": "groupA", "value": "valueA" } |
Contributor
Author
There was a problem hiding this comment.
Need some confirmation here.
RemoteFeatureFlagController 4.0.0 changes the threshold implementation/logic, hence the changes to the state snapshots.
Comment on lines
+13
to
+14
| // E2E Fixtures setup has 4 identities (1 EVM, 1 Solana, 1 Bitcoin, 1 Tron) | ||
| const METAMASK_IDENTITIES = 4; |
Contributor
Author
There was a problem hiding this comment.
This baffled me.... Looking at the underlying logic and the fixtures, the test points to the number of identities, not accounts.
I'm not entirely sure why now this e2e test is failing though.
| name: 'groupC', | ||
| value: 'valueC', | ||
| name: 'groupA', | ||
| value: 'valueA', |
There was a problem hiding this comment.
Override test ineffective due to identical mock values
Low Severity
MOCK_REMOTE_FEATURE_FLAGS_RESPONSE.feature3 changed from groupC/valueC to groupA/valueA, which is now identical to MOCK_CUSTOMIZED_REMOTE_FEATURE_FLAGS.feature3. The E2E override test in remote-feature-flag.spec.ts validates {...MOCK_REMOTE_FEATURE_FLAGS_RESPONSE, ...MOCK_CUSTOMIZED_REMOTE_FEATURE_FLAGS}, which now produces the same result as the response alone. This makes the manifest-override test a no-op — it passes regardless of whether the override mechanism actually works. The customized mock needs a distinct value (e.g., groupB/valueB) to meaningfully test override behavior.
Contributor
Author
There was a problem hiding this comment.
Deleted this file as it has exports that are not used anywhere.
Comment on lines
+171
to
+172
| name: 'groupA', | ||
| value: 'valueA', |
Contributor
Author
There was a problem hiding this comment.
Need some confirmation here.
RemoteFeatureFlagController 4.0.0 changes the threshold implementation/logic, hence the changes were needed to this response constant.
…ore/bump-remote-feature-flag-controller
Contributor
Builds ready [7dc9f96]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Comment on lines
+72
to
+73
| 'data.RemoteFeatureFlagController.thresholdCache', | ||
| 'data.RemoteFeatureFlagController.rawRemoteFeatureFlags', |
Contributor
Author
There was a problem hiding this comment.
Excluding:
thresholdCacheuses the randomly generated address per run.rawRemoteFeatureFlagsseems to be the actual raw feature flag results from our server, any changes in LD would invalidate this.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| getMetaMetricsId: () => | ||
| initMessenger.call('MetaMetricsController:getMetaMetricsId'), | ||
| clientVersion: getBaseSemVerVersion(), | ||
| prevClientVersion, |
There was a problem hiding this comment.
Unit test missing assertion for new prevClientVersion parameter
Medium Severity
The init function now extracts prevClientVersion from persistedState?.AppMetadataController?.currentAppVersion and passes it to the RemoteFeatureFlagController constructor, but the test named "passes the proper arguments to the controller" was not updated to assert prevClientVersion. Since the mock's persistedState is {}, prevClientVersion is undefined, and toHaveBeenCalledWith silently ignores undefined properties — so the test passes without verifying the new parameter. A regression removing prevClientVersion would go undetected.
Triggered by project rule: MetaMask Extension - Cursor Rules
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [b4c42b3]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
add support for wildcard keys so we can still match statelogs as as much as possible.
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
|
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [cffeec7]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump
@metamask/remote-feature-flag-controllerfrom^3.0.0to^4.1.0Changelog
CHANGELOG entry: chore: bump RemoteFeatureFlagController
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2804
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Upgrades the remote feature flag dependency and updates initialization/state shape, which can affect feature gating behavior and persisted state compatibility. Risk is moderated by mostly test/fixture/policy updates but touches runtime flag fetching and controller config.
Overview
Bumps
@metamask/remote-feature-flag-controllerfrom^3.0.0to^4.1.0, including ayarn.lockupdate and LavaMoat policy changes to allow theTextEncoderglobal.Updates
RemoteFeatureFlagControllerinitialization to pass throughprevClientVersionfrom persistedAppMetadataControllerstate, and refreshes unit/E2E tests + fixtures for the controller’s expanded state shape (e.g.localOverrides,rawRemoteFeatureFlags,thresholdCache) and updated mock flag payloads.Improves E2E state-log validation by adding wildcard key support (e.g.
metamask.thresholdCache.*) and adjusts a metrics E2E assertion to match the fixture identity count.Written by Cursor Bugbot for commit cffeec7. This will update automatically on new commits. Configure here.