feat: some updates on the gator permission details #37768
+1,363
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (5 files, +451 -141)
|
Collaborator
Builds ready [48847d4]
UI Startup Metrics (1212 ± 115 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MoMannn
previously approved these changes
Nov 13, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ui/components/multichain/pages/gator-permissions/components/review-gator-permission-item.tsx
Outdated
Show resolved
Hide resolved
mj-kiwi
changed the title
Collaborator
Builds ready [ce94620]
UI Startup Metrics (1228 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/components/multichain/pages/gator-permissions/components/review-gator-permission-item.tsx
Show resolved
Hide resolved
ui/components/multichain/pages/gator-permissions/components/review-gator-permission-item.tsx
Outdated
Show resolved
Hide resolved
mj-kiwi
changed the title
Collaborator
Builds ready [23fd967]
UI Startup Metrics (1253 ± 90 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [8640a4d]
UI Startup Metrics (1261 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [3a00d0e]
UI Startup Metrics (1216 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [e09cd1c]
UI Startup Metrics (1257 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mj-kiwi
force-pushed
the
add-justification-field-to-revocation-details
branch
from
dc8b63b to
01f7100
Compare
Collaborator
Builds ready [dc4099b]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [662ce77]
UI Startup Metrics (1200 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/components/multichain/pages/gator-permissions/components/review-gator-permission-item.tsx
Show resolved
Hide resolved
Collaborator
Builds ready [2fd2d06]
UI Startup Metrics (1224 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
- Introduced `useGatorPermissionTokenInfo` hook to manage token info fetching logic. - Updated `ReviewGatorPermissionItem` component to utilize the new hook for token info. - Removed direct calls to `getGatorPermissionTokenInfo` and related state management. - Enhanced test coverage for the new hook, including various scenarios for token info retrieval. - Improved handling of native tokens and caching mechanisms for better performance.
Collaborator
Builds ready [c3b65be]
UI Startup Metrics (1229 ± 83 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…etrieval in PermissionItem
…in DisconnectPermissionsModal tests
Collaborator
Builds ready [0a2f776]
UI Startup Metrics (1205 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MoMannn
reviewed
Nov 25, 2025
| }, [accountText]); | ||
|
|
||
| // Handle copy button click | ||
| const handleCopyClick = useCallback(() => { |
Contributor
There was a problem hiding this comment.
There is an existing useCopyToClipboard hook that already handles a lot of things and an existing CopyIcon component. Better use those for consistency and reusage.
| color={TextColor.TextAlternative} | ||
| variant={TextVariant.BodyMd} | ||
| > | ||
| Justification |
Contributor
There was a problem hiding this comment.
Why are we handling the translation for this later? In other parts we have done it right away?
And if we are handling it seperatly, lets open an issue for that and here add a TODO comment for adding translation
| ? t('gatorPermissionUnknownTokenAmount') | ||
| : `${getDecimalizedHexValue(amountPerPeriod, decimals)} ${symbol}`, | ||
| value: loading | ||
| ? t('gatorPermissionUnknownTokenAmount') |
Contributor
There was a problem hiding this comment.
Maybe add a spinner here if in loading state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry: feat: add justification field to gator permission details
CHANGELOG entry: feat: add display account name and option to copy address
CHANGELOG entry: feat: show the time only if it's within 24 hours
CHANGELOG entry: fix: permission appears with "Unknown" amount issue
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Add justification field to gator permission details
Display account name and option to copy address
Show the time only if it's within 24 hours
Fix permission appears with "Unknown" amount issue
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces a token info hook and updates permission details to show justification, account name with copy/feedback, conditional date-time formatting, and resilient token metadata handling to avoid "Unknown amount".
useGatorPermissionTokenInfo: New hook to resolve token metadata (native/erc20) via cache/imported/API/on-chain with promise dedupe; exported fromui/hooks/gator-permissions.review-gator-permission-item.tsx: Uses the new hook; adds account name display with copy-to-clipboard and success feedback; shows justification in expanded view; renders "Unknown amount" while loading; keeps weekly amount/frequency and adds conditional time in dates.permission-item.tsx: Refactors to the new hook; surfaces loading as"Unknown amount"in summaries.convertTimestampToReadableDate: ShowsMM/dd/yyyy HH:mmonly if timestamp is within 24 hours; otherwiseMM/dd/yyyy.Written by Cursor Bugbot for commit 0a2f776. This will update automatically on new commits. Configure here.