Skip to content

Conversation

@XxdpavelxX
Copy link
Contributor

@XxdpavelxX XxdpavelxX commented Oct 31, 2025

Description

Ticket: https://consensyssoftware.atlassian.net/browse/INFRA-3041
Github-tools PR: MetaMask/github-tools#154

Summary of Changes

Prevented github-tools from appearing in PRs
File: github-tools/.github/workflows/stable-sync.yml
What: Added explicit cleanup commands to unstage and remove github-tools directory before pushing
Impact: The sync PR will no longer include a github-tools/ submodule or directory
Disabled package.json version bump for Extension
File: github-tools/.github/scripts/stable-sync.js
What: Removed the yarn version logic that bumped package.json version
Before: Extension ran yarn version to update the version
After: Extension now preserves package.json from stable branch (same as mobile)
Impact: No version bump will occur in the sync PR for either mobile or extension
Verified PR title format
File: github-tools/.github/workflows/stable-sync.yml (line 147)
What: Confirmed it already uses release: prefix (no change needed)
Format: "release: sync stable to main for version X.Y.Z"
Testing in Extension: consensys-test#209, https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/18951817173
Testing in Mobile: consensys-test/metamask-mobile-test-workflow#30, https://github.com/consensys-test/metamask-mobile-test-workflow/actions/runs/18951842114

Testing Post CR comments: consensys-test#212

Changelog

CHANGELOG entry: None

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Bumps stable-branch sync workflow to a new github-tools ref and ignores the github-tools/ directory.

  • CI/Workflows:
    • Update .github/workflows/stable-branch-sync.yml to use metamask/github-tools/.github/workflows/stable-sync.yml@79ce6e3 and set github-tools-version to 79ce6e3.
  • Repo hygiene:
    • Add github-tools/ to .gitignore.

Written by Cursor Bugbot for commit f8418e5. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label Oct 31, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [8b82d36]
UI Startup Metrics (1257 ± 82 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1257109214598213191417
load107995012848011361245
domContentLoaded107194412637911301232
domInteractive20135091847
firstPaint659155129344510891247
backgroundConnect23021631012233249
firstReactRender28187683245
getState2073972634
initialActions61436717
loadScripts8497281041789061003
setupStore1062431118
numNetworkReqs96327630
BrowserifyPower User HomeuiStartup21671707404770930324047
load1099864198335915331983
domContentLoaded1089857195535315181955
domInteractive291477215977
firstPaint84816919945149411994
backgroundConnect27618410272032631027
firstReactRender24223022530
getState17413229634178296
initialActions934611646
loadScripts874681161330512671613
setupStore1272761127
numNetworkReqs324179686190586686
WebpackStandard HomeuiStartup8827361297849101038
load65858593071672808
domContentLoaded65057891869664784
domInteractive171184111438
firstPaint19262928185172626
backgroundConnect24116992644
firstReactRender3017253243437
getState1262441520
initialActions3019237
loadScripts64657690767662778
setupStore125140131316
numNetworkReqs96358833
WebpackPower User HomeuiStartup17941496236732223142367
load75464410311349581031
domContentLoaded726625977123915977
domInteractive17133152431
firstPaint50984966305690966
backgroundConnect12634401135325401
firstReactRender27234452844
getState16714723622173236
initialActions1006017960
loadScripts721623967119902967
setupStore17694222394
numNetworkReqs330183581142550581
FirefoxBrowserifyStandard HomeuiStartup15321311197910715821719
load1295113415548013461429
domContentLoaded1294113415538013451429
domInteractive1183730545130196
firstPaint------
backgroundConnect4628199215280
firstReactRender28225972849
getState74384713
initialActions4232347
loadScripts1267111714527513171396
setupStore167214231357
numNetworkReqs96337729
BrowserifyPower User HomeuiStartup28002297419751630264197
load14511262172013815591720
domContentLoaded14511262172013815591720
domInteractive20696607130260607
firstPaint------
backgroundConnect2193513063133711306
firstReactRender41295784857
getState1437922639157226
initialActions11174171374
loadScripts13981231167011614691670
setupStore47816348110163
numNetworkReqs267169578118339578
WebpackStandard HomeuiStartup1599143120139316311839
load1370125516067414051545
domContentLoaded1370125516067414051545
domInteractive1083338453114202
firstPaint------
backgroundConnect4527122165383
firstReactRender332279153373
getState9411011814
initialActions41658310
loadScripts1342118415867313761526
setupStore1275481225
numNetworkReqs96326828
WebpackPower User HomeuiStartup28692227444375734054443
load15601287225329118862253
domContentLoaded15591287225329118852253
domInteractive1367928459179284
firstPaint------
backgroundConnect2813912353686891235
firstReactRender423183124683
getState1318527546137275
initialActions12193221693
loadScripts15051261204725617912047
setupStore32102065024206
numNetworkReqs291144610167467610
📊 Page Load Benchmark Results

Current Commit: 8b82d36 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±45ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±43ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 45ms 1.02s 1.42s 1.08s 1.42s
domContentLoaded 731ms 43ms 709ms 1.09s 759ms 1.09s
firstPaint 77ms 13ms 60ms 196ms 88ms 196ms
firstContentfulPaint 77ms 13ms 60ms 196ms 88ms 196ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 68 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@XxdpavelxX XxdpavelxX force-pushed the INFRA-3041-StableBranchSync branch from 306fcdf to f8418e5 Compare November 5, 2025 15:40
@XxdpavelxX XxdpavelxX self-assigned this Nov 5, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [f8418e5]
UI Startup Metrics (1234 ± 97 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1234107316559712781421
load105591614578511091222
domContentLoaded105091114368411041203
domInteractive211468121853
firstPaint60478147541710381169
backgroundConnect2322162618235243
firstReactRender23184952429
getState2097692336
initialActions705811637
loadScripts823700119182876986
setupStore1061821114
numNetworkReqs1367519671
BrowserifyPower User HomeuiStartup19981775271331623442713
load1050901172222412601722
domContentLoaded1040881168721912511687
domInteractive31151112655111
firstPaint70317817294599551729
backgroundConnect24022127817251278
firstReactRender28243733037
getState18716024426210244
initialActions62225622
loadScripts812661144121110161441
setupStore1593692436
numNetworkReqs1197225474243254
WebpackStandard HomeuiStartup86171813791108601128
load626570110994612892
domContentLoaded619564109391604877
domInteractive171278111540
firstPaint20758909197209629
backgroundConnect261293152859
firstReactRender30186593539
getState1151831316
initialActions41244511
loadScripts615562108289602865
setupStore1263241321
numNetworkReqs1367519870
WebpackPower User HomeuiStartup12931126173723115891737
load66156610101528521010
domContentLoaded644554992143828992
domInteractive221261154061
firstPaint36388995311564995
backgroundConnect60162617361261
firstReactRender25232812628
getState14110415919152159
initialActions514812148
loadScripts640551982140816982
setupStore1162771427
numNetworkReqs1096822449164224
FirefoxBrowserifyStandard HomeuiStartup14771309198012715341761
load1245112115238313101403
domContentLoaded1245112015228413101402
domInteractive1173440557121270
firstPaint------
backgroundConnect4725112205294
firstReactRender26223832731
getState9417518717
initialActions52678414
loadScripts1217110214978012711376
setupStore147185181332
numNetworkReqs1266515757
BrowserifyPower User HomeuiStartup25892212390847227503908
load14141190195821615371958
domContentLoaded14141190195821615361958
domInteractive248104782220396782
firstPaint------
backgroundConnect13135360106240360
firstReactRender443273104973
getState1499440472156404
initialActions10146121346
loadScripts13701165191621914931916
setupStore4452395764239
numNetworkReqs1346832588201325
WebpackStandard HomeuiStartup16821499210814117192055
load14221250177310714711661
domContentLoaded14221250177310714711660
domInteractive1013238046111169
firstPaint------
backgroundConnect57261632567120
firstReactRender31248083242
getState9417518715
initialActions61447525
loadScripts13861230172610014191615
setupStore178104171567
numNetworkReqs1366917866
WebpackPower User HomeuiStartup27152367355740231623557
load15951383193016017301930
domContentLoaded15951383193016017301930
domInteractive19786595144309595
firstPaint------
backgroundConnect864224852114248
firstReactRender39305074850
getState1469124745189247
initialActions3011705511170
loadScripts15601358188215416981882
setupStore3492135319213
numNetworkReqs1285731697232316
📊 Page Load Benchmark Results

Current Commit: f8418e5 | Date: 11/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.02s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 712ms (±35ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.02s 37ms 996ms 1.30s 1.04s 1.30s
domContentLoaded 712ms 35ms 689ms 977ms 732ms 977ms
firstPaint 75ms 10ms 60ms 160ms 84ms 160ms
firstContentfulPaint 75ms 10ms 60ms 160ms 84ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@XxdpavelxX XxdpavelxX changed the title INFRA-3041:Added github-tools to .gitignore chore: INFRA-3041-Added github-tools to .gitignore Nov 5, 2025
@XxdpavelxX XxdpavelxX added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit 468fef1 Nov 5, 2025
328 of 338 checks passed
@XxdpavelxX XxdpavelxX deleted the INFRA-3041-StableBranchSync branch November 5, 2025 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2025
@metamaskbot metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Nov 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.9.0 Issue or pull request that will be included in release 13.9.0 size-XS team-dev-ops DevOps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants