feat: preinstall EIP-7715 Gator Permissions snaps in Flask #36230

jeffsmale90 · 2025-09-23T09:59:34Z

Description

This PR adds @metamask/gator-permissions-snaps and @metamask/permissions-kernel-snap as preinstalled snaps in flask.

It also enables the Gator Permissions feature with GATOR_PERMISSIONS_SNAP env variable, and adds the gator-permissions build feature.

Changelog

CHANGELOG entry: Adds EIP-7715 Readable Permissions to MetaMask flask, allowing dapps to call wallet_requestExecutionPermissions

Related issues

Manual testing steps

Call wallet_requestExecutionPermissions with appropriate args, or use the Delegation Toolkit's experimental action to request a permission. This will allow the user to modify and / or approve the permission, but signing will fail until #36054 is merged.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-09-23T09:59:43Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-09-23T10:01:53Z

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (2 files, +16 -0)

📁 app/
- 📁 scripts/
  - 📁 constants/
    - 📄 snaps.ts +12 -0
📁 shared/
- 📁 lib/
  - 📁 snaps/
    - 📄 snaps.ts +4 -0

🧩 @MetaMask/extension-devs (1 files, +2 -2)

📁 lavamoat/
- 📁 build-system/
  - 📄 policy.json +2 -2

📜 @MetaMask/policy-reviewers (1 files, +2 -2)

📁 lavamoat/
- 📁 build-system/
  - 📄 policy.json +2 -2

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

🔗 @MetaMask/supply-chain (1 files, +2 -2)

📁 lavamoat/
- 📁 build-system/
  - 📄 policy.json +2 -2

- set up a new build feature 'gator-permissions' - add 'gator-permissions' to flask build type - add preinstall artifacts to snap constants - add gator permissions snaps to preinstalled snaps constant

Mrtenz · 2025-09-24T08:00:28Z

builds.yml

      - APPLE_FLASK_CLIENT_ID
      - GOOGLE_CLIENT_ID_REF: GOOGLE_FLASK_CLIENT_ID
      - APPLE_CLIENT_ID_REF: APPLE_FLASK_CLIENT_ID
+      - GATOR_PERMISSIONS_ENABLED: true


Is the environment variable needed? Ideally we can just use code fences.

Yeah, I wasn't aware of the ability to use fences when we initially introduced the feature!

We are aiming to get this into the flask release cut tomorrow. I'd be happy if we can accept both the env var and the fence, and open a second PR to replace all checks on the env var to use the fence instead.

WDYT?

Sounds good to me!

…into feat/preinstall_gator_snaps

socket-security · 2025-09-24T11:57:03Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@metamask/permissions-kernel-snap@0.3.0
@metamask/gator-permissions-snap@0.3.0
@metamask/delegation-utils@0.10.0
lodash.memoize@4.1.2
@metamask/delegation-abis@0.9.0
webauthn-p256@0.0.5
@metamask/delegation-toolkit@0.10.2
@metamask/profile-sync-controller@25.0.0 ⏵ 21.0.0	^-3	⁺¹	⁺¹
@metamask/auto-changelog@5.1.0 ⏵ 3.4.4	^-4		^-14
@noble/ciphers@0.5.3
zod@3.25.76

View full report

socket-security · 2025-09-24T11:57:05Z

Warning

MetaMask internal reviewing guidelines:

Do not ignore-all
Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
@SocketSecurity ignore npm/PACKAGE@VERSION

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		`zod@3.25.76` is a AI-detected potential code anomaly. Notes: No explicit network exfiltration, reverse shell, or credential theft is present in this fragment. However, the code assembles and compiles arbitrary code via the Function constructor and invokes passed-in functions immediately (twice). That behavior constitutes a strong dangerous primitive (arbitrary code execution) which can be abused if any inputs (strings or args) are attacker-controlled. Treat this module as risky in threat models where inputs are not fully trusted; review call sites and sanitize/validate inputs or avoid dynamic evaluation. Confidence: 1.00 Severity: 0.60 From: yarn.lock → `npm/zod@3.25.76` ℹ Read more on: This package \| This alert \| What is an AI-detected potential code anomaly? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/zod@3.25.76`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Ignoring alerts on:

@metamask/gator-permissions-snap@0.3.0

View full report

MoMannn · 2025-09-24T12:00:56Z

@SocketSecurity ignore @metamask/gator-permissions-snap@0.3.0 This is package that we produce and uses fetch for some API calls.

…into feat/preinstall_gator_snaps

metamaskbot · 2025-09-24T13:14:59Z

📊 Page Load Benchmark Results

Current Commit: cea9a62 | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±69ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 726ms (±67ms) 🟢 | historical mean value: 744ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	69ms	995ms	1.30s	1.25s	1.30s
domContentLoaded	726ms	67ms	689ms	985ms	931ms	985ms
firstPaint	76ms	12ms	56ms	180ms	88ms	180ms
firstContentfulPaint	76ms	12ms	56ms	180ms	88ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T13:15:04Z

Builds ready [cea9a62]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1193 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1193	1058	1458	72	1241	1316
			load	1028	918	1200	69	1078	1147
			domContentLoaded	1022	912	1191	68	1072	1143
			domInteractive	17	13	42	6	16	36
			firstPaint	671	135	1169	412	1046	1141
			backgroundConnect	209	197	250	6	211	217
			firstReactRender	24	18	42	5	25	37
			getState	14	5	126	13	15	31
			initialActions	6	0	77	12	5	13
			loadScripts	819	713	984	67	870	940
			setupStore	9	5	22	3	9	14
	Webpack	Home	uiStartup	1183	923	1421	115	1260	1338
			load	996	760	1241	109	1075	1118
			domContentLoaded	991	756	1238	109	1070	1114
			domInteractive	17	13	57	9	14	40
			firstPaint	161	66	313	61	202	267
			backgroundConnect	17	10	42	7	18	31
			firstReactRender	36	33	56	3	36	41
			getState	6	4	13	2	7	12
			initialActions	6	2	19	4	9	14
			loadScripts	988	754	1235	109	1067	1111
			setupStore	8	6	15	2	9	12
Firefox	Browserify	Home	uiStartup	1404	1232	1902	136	1489	1671
			load	1208	1075	1448	93	1285	1374
			domContentLoaded	1207	1075	1448	93	1284	1373
			domInteractive	101	35	353	58	107	248
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	18	130	15	32	46
			firstReactRender	29	23	50	5	32	41
			getState	9	3	220	22	6	24
			initialActions	5	0	183	19	3	15
			loadScripts	1186	1061	1429	91	1265	1348
			setupStore	11	5	101	15	9	35
	Webpack	Home	uiStartup	1600	1389	2167	172	1714	1946
			load	1362	1186	1824	144	1483	1622
			domContentLoaded	1362	1186	1824	144	1483	1621
			domInteractive	104	32	317	57	103	293
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	21	45	6	35	41
			firstReactRender	45	36	57	5	48	55
			getState	8	3	159	16	7	18
			initialActions	5	1	152	17	3	8
			loadScripts	1339	1161	1807	146	1461	1600
			setupStore	12	6	163	18	10	27

Benchmark value 209 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 218 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 941 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1671 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 248 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1946 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 248ms | Sum of p95 exceeds: 463.8ms
Sum of all benchmark exceeds: 711.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 126 Bytes (0%)
ui: 0 Bytes (0%)
common: 2.78 KiB (0.04%)

…te permission tests on flask.

metamaskbot · 2025-09-24T14:42:21Z

📊 Page Load Benchmark Results

Current Commit: dda9782 | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±70ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 728ms (±68ms) 🟢 | historical mean value: 743ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	70ms	996ms	1.31s	1.25s	1.31s
domContentLoaded	728ms	68ms	685ms	993ms	932ms	993ms
firstPaint	75ms	12ms	60ms	172ms	84ms	172ms
firstContentfulPaint	75ms	12ms	60ms	172ms	84ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T14:42:33Z

Builds ready [dda9782]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1207 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1207	1057	1347	65	1254	1307
			load	1040	918	1165	56	1084	1132
			domContentLoaded	1033	911	1161	56	1078	1123
			domInteractive	18	14	52	7	17	38
			firstPaint	685	138	1160	414	1063	1136
			backgroundConnect	214	202	238	6	217	227
			firstReactRender	26	18	52	7	28	44
			getState	12	5	36	6	14	25
			initialActions	5	0	80	8	6	16
			loadScripts	826	716	954	55	867	918
			setupStore	9	5	27	3	10	15
	Webpack	Home	uiStartup	1150	916	1388	110	1222	1283
			load	967	754	1204	103	1028	1107
			domContentLoaded	962	751	1199	104	1022	1102
			domInteractive	15	12	46	7	14	37
			firstPaint	152	64	357	60	173	288
			backgroundConnect	16	10	70	7	16	28
			firstReactRender	35	32	54	3	36	40
			getState	7	4	22	3	7	12
			initialActions	6	2	19	4	8	15
			loadScripts	959	748	1196	103	1019	1099
			setupStore	8	6	18	2	9	14
Firefox	Browserify	Home	uiStartup	1397	1227	1707	110	1484	1613
			load	1212	1073	1546	90	1284	1348
			domContentLoaded	1211	1073	1545	90	1284	1348
			domInteractive	104	34	317	55	109	237
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	19	110	13	33	46
			firstReactRender	30	23	48	6	32	41
			getState	6	3	40	5	6	13
			initialActions	4	1	87	9	4	10
			loadScripts	1189	1052	1525	88	1261	1330
			setupStore	11	5	123	14	9	34
	Webpack	Home	uiStartup	1654	1436	2278	161	1772	1933
			load	1406	1212	1713	142	1518	1653
			domContentLoaded	1406	1211	1713	142	1518	1652
			domInteractive	113	34	343	61	112	301
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	21	86	9	40	45
			firstReactRender	48	38	83	6	52	57
			getState	7	3	102	10	7	17
			initialActions	5	1	218	21	4	9
			loadScripts	1380	1186	1685	143	1497	1632
			setupStore	10	6	28	4	11	21

Benchmark value 214 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 237 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1654 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1406 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1406 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 113 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 49 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1381 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 301 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1632 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 379ms | Sum of p95 exceeds: 450.8ms
Sum of all benchmark exceeds: 829.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 2.71 KiB (0.03%)

test/e2e/flask/multichain-api/evm/wallet_sessionChanged.spec.ts

metamaskbot · 2025-09-24T16:04:26Z

📊 Page Load Benchmark Results

Current Commit: 4f42907 | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±69ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 731ms (±68ms) 🟢 | historical mean value: 743ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	69ms	1.00s	1.31s	1.25s	1.31s
domContentLoaded	731ms	68ms	691ms	990ms	933ms	990ms
firstPaint	76ms	13ms	60ms	192ms	84ms	192ms
firstContentfulPaint	76ms	13ms	60ms	192ms	84ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T16:04:39Z

Builds ready [4f42907]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1203 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1203	1060	1437	70	1252	1323
			load	1036	925	1186	63	1084	1136
			domContentLoaded	1030	917	1176	63	1079	1127
			domInteractive	17	13	46	6	16	36
			firstPaint	731	139	1181	401	1064	1133
			backgroundConnect	211	200	233	5	214	219
			firstReactRender	25	18	52	7	28	40
			getState	13	5	75	9	16	29
			initialActions	4	0	43	5	6	13
			loadScripts	825	720	971	61	872	925
			setupStore	9	6	26	3	10	14
	Webpack	Home	uiStartup	1160	924	1429	118	1238	1334
			load	974	760	1245	111	1054	1145
			domContentLoaded	970	755	1241	111	1047	1140
			domInteractive	16	12	46	8	14	41
			firstPaint	152	61	421	66	179	294
			backgroundConnect	16	11	35	6	15	29
			firstReactRender	36	33	65	5	36	53
			getState	7	4	20	3	7	11
			initialActions	6	2	25	4	8	14
			loadScripts	967	753	1238	111	1037	1138
			setupStore	8	6	20	2	9	13
Firefox	Browserify	Home	uiStartup	1421	1201	1839	122	1485	1669
			load	1228	1057	1634	87	1282	1364
			domContentLoaded	1227	1057	1633	87	1282	1364
			domInteractive	104	32	367	55	114	227
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	37	18	398	44	33	119
			firstReactRender	29	23	48	5	31	42
			getState	5	3	21	3	6	13
			initialActions	4	0	41	5	4	9
			loadScripts	1200	1039	1352	75	1257	1314
			setupStore	14	4	200	25	9	69
	Webpack	Home	uiStartup	1632	1405	2307	177	1720	2011
			load	1376	1186	1759	142	1465	1671
			domContentLoaded	1376	1186	1758	142	1465	1671
			domInteractive	111	34	360	67	102	295
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	22	65	9	39	48
			firstReactRender	48	38	64	6	51	62
			getState	7	3	78	8	7	13
			initialActions	8	1	168	26	4	11
			loadScripts	1352	1155	1735	143	1437	1652
			setupStore	11	6	31	4	11	21

Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 220 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1422 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1669 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 227 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 119 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 69 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1632 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 49 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 2011 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1671 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1671 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 295 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1652 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 306ms | Sum of p95 exceeds: 639.8ms
Sum of all benchmark exceeds: 945.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: -133 Bytes (0%)
common: 2.71 KiB (0.03%)

…Mask/metamask-extension into feat/preinstall_gator_snaps

metamaskbot · 2025-09-24T16:35:01Z

📊 Page Load Benchmark Results

Current Commit: f9f1a97 | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±73ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 737ms (±70ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±15ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	73ms	1.00s	1.35s	1.28s	1.35s
domContentLoaded	737ms	70ms	694ms	1.02s	952ms	1.02s
firstPaint	77ms	15ms	60ms	212ms	88ms	212ms
firstContentfulPaint	77ms	15ms	60ms	212ms	88ms	212ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T16:35:07Z

Builds ready [f9f1a97]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1106 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1106	994	1454	71	1143	1221
			load	939	831	1222	61	970	1044
			domContentLoaded	928	814	1214	61	961	1030
			domInteractive	18	13	49	9	16	44
			firstPaint	723	171	1059	333	958	1037
			backgroundConnect	186	171	298	20	187	215
			firstReactRender	26	14	52	8	30	42
			getState	13	4	82	12	14	35
			initialActions	4	0	22	4	6	13
			loadScripts	752	643	1035	60	785	860
			setupStore	9	6	25	4	10	17
	Webpack	Home	uiStartup	1145	923	1363	101	1213	1311
			load	954	757	1159	95	1017	1081
			domContentLoaded	949	753	1154	95	1013	1076
			domInteractive	16	12	61	9	14	41
			firstPaint	156	64	409	59	184	265
			backgroundConnect	16	10	35	6	18	29
			firstReactRender	37	33	98	7	37	44
			getState	7	4	20	3	7	12
			initialActions	6	2	19	4	8	15
			loadScripts	946	751	1151	95	1010	1074
			setupStore	9	6	21	2	9	15
Firefox	Browserify	Home	uiStartup	1395	1228	1839	113	1456	1634
			load	1203	1073	1432	81	1268	1341
			domContentLoaded	1202	1072	1432	81	1267	1341
			domInteractive	105	34	350	59	106	245
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	18	146	20	35	79
			firstReactRender	29	24	45	5	31	43
			getState	7	3	87	10	6	17
			initialActions	4	1	16	3	4	9
			loadScripts	1177	1054	1408	80	1242	1315
			setupStore	11	5	101	15	9	39
	Webpack	Home	uiStartup	1596	1376	1905	134	1680	1874
			load	1362	1157	1655	124	1457	1589
			domContentLoaded	1362	1156	1655	124	1457	1588
			domInteractive	103	34	344	62	102	298
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	19	54	6	33	41
			firstReactRender	47	33	60	6	51	58
			getState	6	3	16	2	6	9
			initialActions	3	0	9	1	3	5
			loadScripts	1340	1136	1633	124	1431	1567
			setupStore	12	6	146	20	10	20

Benchmark value 187 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 216 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 35 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 245 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 79 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 298 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 58 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 222ms | Sum of p95 exceeds: 453.8ms
Sum of all benchmark exceeds: 675.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: -1.81 KiB (-0.03%)
common: 2.71 KiB (0.03%)

metamaskbot · 2025-09-24T18:14:39Z

📊 Page Load Benchmark Results

Current Commit: 02859e4 | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±86ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 739ms (±83ms) 🟢 | historical mean value: 739ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±14ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	86ms	1.01s	1.37s	1.34s	1.37s
domContentLoaded	739ms	83ms	696ms	1.05s	1.02s	1.05s
firstPaint	76ms	14ms	56ms	200ms	88ms	200ms
firstContentfulPaint	76ms	14ms	56ms	200ms	88ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T18:14:54Z

Builds ready [02859e4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1236 ± 49 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1236	1111	1397	49	1269	1320
			load	1066	980	1200	46	1096	1143
			domContentLoaded	1060	974	1194	45	1089	1136
			domInteractive	18	14	56	8	17	41
			firstPaint	656	88	1207	427	1073	1129
			backgroundConnect	254	239	274	7	258	266
			firstReactRender	25	17	49	6	28	38
			getState	14	5	37	7	17	31
			initialActions	6	0	77	8	6	15
			loadScripts	812	731	934	45	842	884
			setupStore	10	5	31	4	11	17
	Webpack	Home	uiStartup	1176	921	1914	139	1256	1326
			load	988	754	1678	132	1058	1136
			domContentLoaded	984	751	1674	132	1052	1133
			domInteractive	16	12	51	9	14	42
			firstPaint	167	63	920	99	186	264
			backgroundConnect	16	10	40	6	18	28
			firstReactRender	36	33	48	3	36	44
			getState	6	4	18	2	7	12
			initialActions	6	2	14	4	8	14
			loadScripts	981	749	1664	131	1050	1131
			setupStore	8	6	24	2	9	12
Firefox	Browserify	Home	uiStartup	1372	1174	1677	99	1422	1548
			load	1188	1028	1356	77	1248	1320
			domContentLoaded	1188	1028	1355	77	1248	1319
			domInteractive	96	32	267	43	103	216
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	18	113	17	34	80
			firstReactRender	28	23	59	6	30	42
			getState	6	3	42	5	6	12
			initialActions	5	1	59	8	4	13
			loadScripts	1163	1010	1338	74	1218	1293
			setupStore	12	5	100	14	9	44
	Webpack	Home	uiStartup	1595	1388	2181	172	1704	1922
			load	1358	1172	1670	144	1468	1632
			domContentLoaded	1357	1171	1669	144	1468	1631
			domInteractive	110	32	342	68	100	309
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	20	80	9	35	45
			firstReactRender	47	38	56	4	50	55
			getState	8	3	151	16	6	13
			initialActions	5	1	189	19	4	5
			loadScripts	1335	1148	1651	144	1447	1611
			setupStore	10	6	26	3	10	16

Benchmark value 1236 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 254 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 266 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 216 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 80 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 44 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 309 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 301ms | Sum of p95 exceeds: 489.8ms
Sum of all benchmark exceeds: 790.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: -1.81 KiB (-0.03%)
common: 2.71 KiB (0.04%)

metamaskbot added the team-delegation MetaMask Delegation Team label Sep 23, 2025

github-actions bot added the size-S label Sep 23, 2025

jeffsmale90 force-pushed the feat/preinstall_gator_snaps branch from e56c792 to 44ba350 Compare September 23, 2025 22:27

jeffsmale90 changed the title ~~WIP first try at pre-installing snaps~~ Preinstall EIP-7715 Gator Permissions snaps in Flask Sep 23, 2025

Preinstall gator permissions snaps

1ac2b2d

- set up a new build feature 'gator-permissions' - add 'gator-permissions' to flask build type - add preinstall artifacts to snap constants - add gator permissions snaps to preinstalled snaps constant

jeffsmale90 force-pushed the feat/preinstall_gator_snaps branch from 44ba350 to 1ac2b2d Compare September 23, 2025 22:44

jeffsmale90 changed the title ~~Preinstall EIP-7715 Gator Permissions snaps in Flask~~ feat: preinstall EIP-7715 Gator Permissions snaps in Flask Sep 23, 2025

Mrtenz reviewed Sep 24, 2025

View reviewed changes

MoMannn added 2 commits September 24, 2025 13:55

Update yarn.lock

8d4fd17

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

a129392

…into feat/preinstall_gator_snaps

MoMannn added 5 commits September 24, 2025 14:07

add preistalled snaps to depcheck

7afb79f

dedup

c14ea98

update lavamout policy via auto build

84e9837

update lavamout policy via linux

cea9a62

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

cd246da

…into feat/preinstall_gator_snaps

MoMannn marked this pull request as ready for review September 24, 2025 13:04

MoMannn requested review from a team as code owners September 24, 2025 13:04

This comment was marked as outdated.

Sign in to view

MoMannn added 2 commits September 24, 2025 15:41

feature gate PREINSTALLED_SNAPS

b2120b6

Update e2e test to use gator-permissions-page and temporary remove si…

655cc76

…te permission tests on flask.

github-actions bot added the size-M label Sep 24, 2025

MoMannn requested a review from Mrtenz September 24, 2025 14:31

Mrtenz reviewed Sep 24, 2025

View reviewed changes

test/e2e/flask/multichain-api/evm/wallet_sessionChanged.spec.ts Outdated Show resolved Hide resolved

MoMannn added 3 commits September 24, 2025 17:36

revert permission page tests

2e3df0c

disable gator permission page until its implemented

2d31f79

Merge branch 'main' into feat/preinstall_gator_snaps

4f42907

github-actions bot added size-S and removed size-M labels Sep 24, 2025

MoMannn added 2 commits September 24, 2025 18:07

comment temporarily unused route

230b809

Merge branch 'feat/preinstall_gator_snaps' of https://github.com/Meta…

f9f1a97

…Mask/metamask-extension into feat/preinstall_gator_snaps

MoMannn requested a review from Mrtenz September 24, 2025 16:40

Mrtenz approved these changes Sep 24, 2025

View reviewed changes

MoMannn approved these changes Sep 24, 2025

View reviewed changes

Merge branch 'main' into feat/preinstall_gator_snaps

02859e4

jeffsmale90 enabled auto-merge September 24, 2025 17:51

jeffsmale90 disabled auto-merge September 24, 2025 18:37

jeffsmale90 added this pull request to the merge queue Sep 24, 2025

Merged via the queue into main with commit 0a2c425 Sep 24, 2025
149 checks passed

jeffsmale90 deleted the feat/preinstall_gator_snaps branch September 24, 2025 19:07

github-actions bot locked and limited conversation to collaborators Sep 24, 2025

metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Sep 24, 2025

feat: preinstall EIP-7715 Gator Permissions snaps in Flask #36230

feat: preinstall EIP-7715 Gator Permissions snaps in Flask #36230

Uh oh!

Conversation

jeffsmale90 commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

metamaskbot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

Mrtenz Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

jeffsmale90 Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Mrtenz Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MoMannn commented Sep 24, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

jeffsmale90 commented Sep 23, 2025 •

edited

Loading

metamaskbot commented Sep 23, 2025 •

edited

Loading

socket-security bot commented Sep 24, 2025 •

edited

Loading

socket-security bot commented Sep 24, 2025 •

edited

Loading