Skip to content

Conversation

@gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Sep 15, 2025

Description

The purpose of this PR is to rename release branches from Version-vx.y.z format into release/x.y.z, in order to align with metamtask-mobile repo format.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Sep 15, 2025
cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: e67ca50 | Date: 9/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±71ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 743ms (±70ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±10ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 71ms 1.02s 1.34s 1.27s 1.34s
domContentLoaded 743ms 70ms 704ms 1.02s 953ms 1.02s
firstPaint 78ms 10ms 60ms 160ms 88ms 160ms
firstContentfulPaint 78ms 10ms 60ms 160ms 88ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [e67ca50]
UI Startup Metrics (1249 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1249111514077012881392
load108196212496911161227
domContentLoaded107495512446811091216
domInteractive18135471740
firstPaint59974122843810861179
backgroundConnect2492372818254260
firstReactRender2618154142839
getState1353271729
initialActions61709613
loadScripts832701101168869976
setupStore1062531016
WebpackHomeuiStartup20931532263726122682520
load16751240212220018131936
domContentLoaded16631229211720118081930
domInteractive181285121552
firstPaint1696946467193280
backgroundConnect3516366473365
firstReactRender89373396489287
getState2953336915288
initialActions9228228718
loadScripts16591227210620018041927
setupStore2863076316241
FirefoxBrowserifyHomeuiStartup14051178193212414561668
load1212103115848612741354
domContentLoaded1211103115848612741354
domInteractive1003232549103233
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3619127223795
firstReactRender29226063137
getState9219821617
initialActions5115416314
loadScripts1184101514968012371334
setupStore94578828
WebpackHomeuiStartup16141358213515817011901
load13821153170013014721610
domContentLoaded13821153170013014721609
domInteractive1013331257100293
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect30185473548
firstReactRender45376144853
getState7216016610
initialActions512002036
loadScripts13601136167913014501587
setupStore95304917
Benchmark value 1249 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1082 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1075 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 249 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 833 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1393 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1227 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1217 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 261 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 977 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2521 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 288 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 18 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 241 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1668 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 233 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 95 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1383 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1361 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 340ms | Sum of p95 exceeds: 968.8ms
Sum of all benchmark exceeds: 1308.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: f5ddefb | Date: 9/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±70ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 733ms (±67ms) 🟢 | historical mean value: 737ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 70ms 1.01s 1.32s 1.25s 1.32s
domContentLoaded 733ms 67ms 700ms 998ms 929ms 998ms
firstPaint 76ms 11ms 60ms 172ms 84ms 172ms
firstContentfulPaint 76ms 11ms 60ms 172ms 84ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [f5ddefb]
UI Startup Metrics (1261 ± 83 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1261110015448312941389
load109496713747811371209
domContentLoaded108794913667811301203
domInteractive18135671739
firstPaint63486138045211041181
backgroundConnect2512382737254264
firstReactRender26195762838
getState1457791528
initialActions40153510
loadScripts843717111676887949
setupStore952631114
WebpackHomeuiStartup20211490264524321652426
load16141199204418317051883
domContentLoaded16041188202818516991878
domInteractive171282111441
firstPaint1666840656189274
backgroundConnect3313352453054
firstReactRender99373468292323
getState2942936714269
initialActions62203613
loadScripts16001186201618416971874
setupStore246315531635
FirefoxBrowserifyHomeuiStartup13891193192211914441654
load1204104915018612581341
domContentLoaded1204104915018612581341
domInteractive1033329455109239
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3519114193695
firstReactRender28225653036
getState738811620
initialActions509312316
loadScripts1177103014338112351314
setupStore11420221741
WebpackHomeuiStartup15811374197013116731807
load13631167165612314501579
domContentLoaded13631167165512214501579
domInteractive1043239763100285
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect30204363640
firstReactRender44365854753
getState6322369
initialActions3038438
loadScripts13411139163612414321553
setupStore85243813
Benchmark value 1262 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1094 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1087 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 251 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 843 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1389 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1209 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1203 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 950 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 269 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 239 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 95 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 41 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 285 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 378ms | Sum of p95 exceeds: 647.8ms
Sum of all benchmark exceeds: 1025.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

semver-version: ${{ inputs.semver-version }}
previous-version-ref: ${{ needs.resolve-previous-ref.outputs.previous_ref }}
github-tools-version: 6090afa85c94a6b64a79e992d94b11610d02181a
github-tools-version: 8144a84f14b3ecf704846ef3569937df85ad9291
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to include changes of this PR: MetaMask/github-tools#125

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: fcc7c19 | Date: 9/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 738ms (±68ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 71ms 1.01s 1.33s 1.26s 1.33s
domContentLoaded 738ms 68ms 704ms 1.01s 942ms 1.01s
firstPaint 77ms 11ms 60ms 176ms 88ms 176ms
firstContentfulPaint 77ms 11ms 60ms 176ms 88ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [fcc7c19]
UI Startup Metrics (1255 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1255110115286812971358
load109096512896411341203
domContentLoaded108395812836311241194
domInteractive1913124121738
firstPaint66873121243911001176
backgroundConnect2502382757254262
firstReactRender25185562538
getState1457791729
initialActions50738513
loadScripts840725103062885952
setupStore962831014
WebpackHomeuiStartup19631480248825521042429
load15771188202320017021874
domContentLoaded15661183201020216921859
domInteractive171287131452
firstPaint1646239767185295
backgroundConnect3415364472955
firstReactRender87373456981321
getState3043206813275
initialActions9228228621
loadScripts15621181200020116901847
setupStore236305531432
FirefoxBrowserifyHomeuiStartup14751294193111115271739
load1277113816438313351408
domContentLoaded1276113716438313351408
domInteractive1103624945119223
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3821107173883
firstReactRender30255863242
getState73949611
initialActions51446417
loadScripts1247111716208113051358
setupStore10510412930
WebpackHomeuiStartup16151404220616416992028
load13801194170312814831580
domContentLoaded13801194170312814831580
domInteractive1043230755100279
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3320198193745
firstReactRender43375644650
getState8315721612
initialActions6119521314
loadScripts13571176166612814591560
setupStore11517318934
Benchmark value 1255 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1091 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1084 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 251 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 841 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1203 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1194 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 952 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 21 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1475 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1277 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1277 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 39 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1247 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1739 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 223 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 83 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 17 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1381 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 2028 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 279 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 534ms | Sum of p95 exceeds: 760.8ms
Sum of all benchmark exceeds: 1294.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@gauthierpetetin gauthierpetetin added this pull request to the merge queue Sep 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 15, 2025
@gauthierpetetin gauthierpetetin added this pull request to the merge queue Sep 15, 2025
Merged via the queue into main with commit a0fa665 Sep 15, 2025
146 checks passed
@gauthierpetetin gauthierpetetin deleted the release-branch-renaming branch September 15, 2025 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
@metamaskbot metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

extension-delivery release-13.5.0 Issue or pull request that will be included in release 13.5.0 size-S team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants