-
Notifications
You must be signed in to change notification settings - Fork 5.2k
chore: bridge tx detail layout fix and unit tests #33860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+735
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (3 files, +735 -4)
|
Builds ready [d4eb2f2]
UI Startup Metrics (1219 ± 55 ms)
Benchmark value 2598 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 413 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1977 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1361 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1950 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 286 exceeds gate value 156 for firefox webpack home p95 domInteractive Sum of mean exceeds: 15ms | Sum of p95 exceeds: 354ms Sum of all benchmark exceeds: 369ms Bundle size diffs
|
Builds ready [6e3d43c]
UI Startup Metrics (1185 ± 75 ms)
Benchmark value 266 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2562 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 405 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1417 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1241 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1949 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 262 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 35 exceeds gate value 32 for firefox webpack home p95 getState Sum of mean exceeds: 55ms | Sum of p95 exceeds: 280ms Sum of all benchmark exceeds: 335ms Bundle size diffs
|
ejwessel
approved these changes
Jun 24, 2025
ghgoodreau
approved these changes
Jun 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.23.0
Issue or pull request that will be included in release 12.23.0
team-swaps-and-bridge
For issues with Swaps or Bridging
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the hardcoded widths for the tx detail modal's columns, which was causing labels to wrap. Also adding unit test coverage for bridge transaction details component
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist