Skip to content

chore: bridge tx detail layout fix and unit tests #33860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jun 24, 2025

Description

Replaces the hardcoded widths for the tx detail modal's columns, which was causing labels to wrap. Also adding unit test coverage for bridge transaction details component

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. View a Bridge tx
  2. verify that tx detail labels don't wrap to the next line

Screenshots/Recordings

Before

Screenshot 2025-06-23 at 10 10 24 PM

After

Screenshot 2025-06-23 at 10 09 54 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Jun 24, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (3 files, +735 -4)
  • 📁 test/
    • 📁 data/
      • 📁 bridge/
        • 📄 mock-bridge-transaction-details.json +475 -0
  • 📁 ui/
    • 📁 pages/
      • 📁 bridge/
        • 📁 transaction-details/
          • 📄 transaction-detail-row.tsx +9 -3
          • 📄 transaction-details.test.tsx +251 -1

@metamaskbot
Copy link
Collaborator

Builds ready [d4eb2f2]
UI Startup Metrics (1219 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1219112114045512551306
load105495912435310881131
domContentLoaded104795212395310811124
domInteractive18147281737
firstPaint70781121141810781116
backgroundConnect74264711
firstReactRender21174242130
getState1463172028
initialActions001001
loadScripts80071097651830878
setupStore85263817
WebpackHomeuiStartup21771658267822323112598
load16601264215119217691991
domContentLoaded16541256214619217611987
domInteractive1910116191472
firstPaint1646256771182299
backgroundConnect20104162331
firstReactRender24590468123383413
getState1144271227
initialActions315134
loadScripts16511254213519017601977
setupStore217316431829
FirefoxBrowserifyHomeuiStartup13561198171611213961631
load1194106815458812251386
domContentLoaded1194106815458812241385
domInteractive1073650456119163
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113119122136
firstReactRender24213532431
getState1058913924
initialActions001001
loadScripts1175105114638312051363
setupStore84809724
WebpackHomeuiStartup15931374214715616751950
load13791198178613214701634
domContentLoaded13781197178613214691633
domInteractive96314826791286
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21154452233
firstReactRender42335044449
getState1174561125
initialActions002111
loadScripts13601179176713214511609
setupStore85364817
Benchmark value 245 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2598 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 413 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1977 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1361 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1950 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 286 exceeds gate value 156 for firefox webpack home p95 domInteractive
Sum of mean exceeds: 15ms | Sum of p95 exceeds: 354ms
Sum of all benchmark exceeds: 369ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 65 Bytes (0%)
  • common: 0 Bytes (0%)

@micaelae micaelae changed the title fix: prevent wrapping tx detail labels add bridge tx detail unit tests fix: prevent wrapping tx detail labels Jun 24, 2025
@micaelae micaelae changed the title fix: prevent wrapping tx detail labels test: bridge tx detail unit tests Jun 24, 2025
@micaelae micaelae changed the title test: bridge tx detail unit tests chore: bridge tx detail layout fix and unit tests Jun 24, 2025
@micaelae micaelae marked this pull request as ready for review June 24, 2025 14:48
@micaelae micaelae requested a review from a team as a code owner June 24, 2025 14:48
@metamaskbot
Copy link
Collaborator

Builds ready [6e3d43c]
UI Startup Metrics (1185 ± 75 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1185108116307512241292
load101988214107510701117
domContentLoaded101387814067510641110
domInteractive17136571636
firstPaint616143115440010231107
backgroundConnect7425379
firstReactRender2217133122131
getState1363271927
initialActions001001
loadScripts809675119774857905
setupStore95254822
WebpackHomeuiStartup21821652266719522732561
load16571240202916817191951
domContentLoaded16511236201916717151945
domInteractive171176141460
firstPaint1626671475177274
backgroundConnect20103662333
firstReactRender26588440121385405
getState1153251319
initialActions316134
loadScripts16491234200916517141944
setupStore167158151824
FirefoxBrowserifyHomeuiStartup14161226178111114681652
load1241108215318712961399
domContentLoaded1241108215318712961399
domInteractive1153534542131177
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413140172253
firstReactRender25215742530
getState11410513929
initialActions001001
loadScripts1222106315078612741386
setupStore949913721
WebpackHomeuiStartup15791391205016316741949
load13601196176713414691634
domContentLoaded13591195176713414691633
domInteractive88333525485262
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22155362332
firstReactRender41335144447
getState1475691335
initialActions101111
loadScripts13411172174913414521608
setupStore10511312828
Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 266 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2562 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 405 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1417 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1241 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1949 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 262 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 35 exceeds gate value 32 for firefox webpack home p95 getState
Sum of mean exceeds: 55ms | Sum of p95 exceeds: 280ms
Sum of all benchmark exceeds: 335ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 65 Bytes (0%)
  • common: 0 Bytes (0%)

@micaelae micaelae enabled auto-merge June 24, 2025 15:43
@micaelae micaelae added this pull request to the merge queue Jun 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2025
@micaelae micaelae added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit 642648a Jun 24, 2025
145 checks passed
@micaelae micaelae deleted the mms2660-tx-detail-layout-and-tests branch June 24, 2025 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
@metamaskbot metamaskbot added the release-12.23.0 Issue or pull request that will be included in release 12.23.0 label Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.23.0 Issue or pull request that will be included in release 12.23.0 team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants