-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: hides fromtoken from the dotokenpicker #33857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ghgoodreau
wants to merge
1
commit into
main
Choose a base branch
from
MMS-2643-from-and-to-addrs-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+21
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (1 files, +21 -12)
|
Builds ready [59ffda2]
UI Startup Metrics (1310 ± 83 ms)
Benchmark value 1311 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1123 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1116 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 855 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1457 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1294 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1287 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1271 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 1005 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 26 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 253 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2640 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 280 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 46 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1698 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1462 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1461 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1441 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2071 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1693 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1693 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 310 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 35 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1673 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 572ms | Sum of p95 exceeds: 1203ms Sum of all benchmark exceeds: 1775ms Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist