feat: dapp scanning enabled on transactions and signatures

[imblue-dabadee]

Description

Currently, we only have dapp scanning enabled when the user connects to a dapp. However, there is a possibility the user may not ever see the trust signal for the URL in a confirmation window (see here for an elaborated explanation). Having it enabled here reduces that possibility.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [d163cc0]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1218 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1218	1108	1504	64	1248	1345
			load	1053	953	1343	60	1077	1167
			domContentLoaded	1047	949	1339	60	1071	1160
			domInteractive	18	14	41	6	17	34
			firstPaint	685	84	1349	426	1060	1125
			backgroundConnect	7	4	23	2	7	9
			firstReactRender	23	16	55	7	23	39
			getState	12	6	32	7	17	28
			initialActions	0	0	1	0	0	1
			loadScripts	798	705	957	53	819	909
			setupStore	8	5	21	3	8	18
	Webpack	Home	uiStartup	2292	1736	2988	240	2426	2695
			load	1743	1295	2271	205	1848	2128
			domContentLoaded	1737	1290	2252	203	1841	2123
			domInteractive	18	12	89	14	14	57
			firstPaint	176	64	430	69	199	318
			backgroundConnect	24	10	248	24	26	45
			firstReactRender	247	90	426	118	376	411
			getState	12	4	34	6	15	26
			initialActions	3	1	6	1	3	5
			loadScripts	1733	1288	2240	201	1838	2111
			setupStore	23	7	326	43	21	36
Firefox	Browserify	Home	uiStartup	1376	1229	1698	110	1432	1633
			load	1210	1074	1413	84	1277	1365
			domContentLoaded	1209	1073	1412	84	1277	1365
			domInteractive	116	37	346	57	119	313
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	13	141	18	22	51
			firstReactRender	24	21	56	4	24	31
			getState	11	5	133	18	9	30
			initialActions	0	0	1	0	0	1
			loadScripts	1189	1061	1398	83	1263	1343
			setupStore	7	4	31	4	7	14
	Webpack	Home	uiStartup	1587	1380	2124	157	1684	1965
			load	1369	1194	1806	131	1472	1601
			domContentLoaded	1369	1193	1806	131	1472	1601
			domInteractive	88	30	295	44	91	144
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	16	49	5	23	35
			firstReactRender	41	32	54	4	44	48
			getState	13	6	111	15	11	31
			initialActions	0	0	2	1	1	1
			loadScripts	1350	1173	1785	131	1455	1575
			setupStore	9	5	55	7	8	20

Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2292 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1744 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1737 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 248 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 1734 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2696 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2128 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2124 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 411 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2112 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 313 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 30 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1965 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Sum of mean exceeds: 225ms | Sum of p95 exceeds: 798ms
Sum of all benchmark exceeds: 1023ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 196 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)

[AugmentedMode]

LGTM