Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Jun 10, 2025

Description

See changelog for details:

## [22.0.2]

### Fixed

- Fixed serialized keyring comparison when establishing whether a vault update is needed ([#5928](https://github.com/MetaMask/core/pull/5928))
  - The vault update was being skipped when a keyring class returns an object shallow copy through `.serialize()`.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Pair new Lattice device
  2. Check the pairing step works as expected, and that a new Lattice
    account has been added

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. fd2d065

…o `^22.0.2` (#33513)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
See changelog for details:

```markdown
## [22.0.2]

### Fixed

- Fixed serialized keyring comparison when establishing whether a vault update is needed ([#5928](MetaMask/core#5928))
  - The vault update was being skipped when a keyring class returns an object shallow copy through `.serialize()`.

```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/33513?quickstart=1)

## **Related issues**

* Fixes: #33232

## **Manual testing steps**

1. Pair new Lattice device
2. Check the pairing step works as expected, and that a new Lattice
account has been added

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Jun 10, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​keyring-controller@​22.0.1 ⏵ 22.0.2961007699 +1100

View full report

@DDDDDanica DDDDDanica merged commit 9516a8b into Version-v12.20.0 Jun 10, 2025
279 of 280 checks passed
@DDDDDanica DDDDDanica deleted the runway-cherry-pick-12.20.0-1749569033 branch June 10, 2025 15:54
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [91b3317]
UI Startup Metrics (1251 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1251111414206712941376
load107194712386411171182
domContentLoaded106394412306511121176
domInteractive17133541731
firstPaint697106123743010931160
backgroundConnect94356828
firstReactRender20164042126
getState1463472029
initialActions001001
loadScripts849732101564899954
setupStore85314815
WebpackHomeuiStartup21791789259021223322537
load16941389205917018101967
domContentLoaded16871384205416918041957
domInteractive161175111346
firstPaint1596434556181273
backgroundConnect2496492940
firstReactRender16744361116304349
getState244333551660
initialActions318136
loadScripts16841383205216718031953
setupStore277311512262
FirefoxBrowserifyHomeuiStartup13711159198614214531629
load12031037160510512641431
domContentLoaded12031037160510512641431
domInteractive973920529107159
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21146482237
firstReactRender24204842432
getState15548152919
initialActions002001
loadScripts11841024158410312451413
setupStore9420420712
WebpackHomeuiStartup15501350213714616481800
load13441170189114014401586
domContentLoaded13441169189014014401586
domInteractive78381611886103
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21144662234
firstReactRender41275544347
getState95305926
initialActions001011
loadScripts13251155186814014221561
setupStore85304819
Benchmark value 1251 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1071 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 849 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1376 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 28 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 954 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2537 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 48ms | Sum of p95 exceeds: 118ms
Sum of all benchmark exceeds: 166ms

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants