-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore(runway): cherry-pick fd2d065 #33566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DDDDDanica
merged 1 commit into
Version-v12.20.0
from
runway-cherry-pick-12.20.0-1749569033
Jun 10, 2025
Merged
chore(runway): cherry-pick fd2d065 #33566
DDDDDanica
merged 1 commit into
Version-v12.20.0
from
runway-cherry-pick-12.20.0-1749569033
Jun 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o `^22.0.2` (#33513) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> See changelog for details: ```markdown ## [22.0.2] ### Fixed - Fixed serialized keyring comparison when establishing whether a vault update is needed ([#5928](MetaMask/core#5928)) - The vault update was being skipped when a keyring class returns an object shallow copy through `.serialize()`. ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/33513?quickstart=1) ## **Related issues** * Fixes: #33232 ## **Manual testing steps** 1. Pair new Lattice device 2. Check the pairing step works as expected, and that a new Lattice account has been added ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
14 tasks
Collaborator
Builds ready [91b3317]
UI Startup Metrics (1251 ± 67 ms)
Benchmark value 1071 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 849 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1376 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 28 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 954 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2537 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 48ms | Sum of p95 exceeds: 118ms Sum of all benchmark exceeds: 166ms |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metamask/keyring-controllerto^22.0.2(fix: bump@metamask/keyring-controllerto^22.0.2cp-12.20.0 #33513)Description
See changelog for details:
Related issues
Manual testing steps
account has been added
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. fd2d065