Skip to content

Conversation

@alucardzom
Copy link
Contributor

@alucardzom alucardzom commented Jun 10, 2025

Description

This PR aims to unify the release branch naming conventions between the extension and mobile projects, and to prepare the onboard of the stable branch instead of using master.
To achieve this, we have updated relevant workflows and scripts to ensure compatibility with the new naming standard.

Key Changes

  • Workflow and Script Updates:

      Modified workflows and scripts to support the unified branch naming convention.
      Ensured compatibility with both the current naming convention and the new one.
    
  • Backward Compatibility:

      Maintained retrocompatibility to ensure the existing workflows continue to function seamlessly during the transition.
      No interruptions or disruptions to the release process are expected.
    

Impact

These changes will streamline the release process across projects, improve consistency, and reduce potential confusion caused by differing branch naming conventions.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

https://github.com/MetaMask/MetaMask-planning/issues/4858

Manual testing steps'

Screenshots/Recordings

Current execution:
image

Updated workflow:
image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

For unifiying the release branch naming between extension and mobile, we
must upgrade some workflows and scripts to make it compatible.

We also keep the retrocompatibility between the current workflow, and
the new one, ensuring the process works smoothly and without
interruptions.
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 10, 2025
@alucardzom alucardzom added the team-extension-platform Extension Platform team label Jun 10, 2025
@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 10, 2025
@metamaskbot metamaskbot added the team-dev-ops DevOps team label Jun 10, 2025
@alucardzom
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@alucardzom alucardzom removed the team-extension-platform Extension Platform team label Jun 10, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [dc8d22a]
UI Startup Metrics (1208 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1208109113936612461349
load104795011936310901178
domContentLoaded104093511886410831172
domInteractive16133341528
firstPaint797139119338210591156
backgroundConnect84385824
firstReactRender21166172235
getState1463671929
initialActions001001
loadScripts79769494363835923
setupStore85243814
WebpackHomeuiStartup20851647279323222152499
load16331296200617417421900
domContentLoaded16271292199217317331893
domInteractive15114981342
firstPaint1765968285207297
backgroundConnect21105492340
firstReactRender13343371108143348
getState143309301232
initialActions318135
loadScripts16241291198117117271889
setupStore4263188422306
FirefoxBrowserifyHomeuiStartup13951176191412714451596
load1225104616069612911391
domContentLoaded1225104616069612911391
domInteractive1063437844118176
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2513125162455
firstReactRender25205762532
getState12523327930
initialActions001001
loadScripts1203103215809712671378
setupStore11421928712
WebpackHomeuiStartup15521367223113116281787
load13441180165511214131565
domContentLoaded13431180165411214131565
domInteractive76321451883109
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2416255242242
firstReactRender41285644346
getState95919927
initialActions002111
loadScripts13251166163311213961549
setupStore96808819
Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 42 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2500 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 306 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 30 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 17ms | Sum of p95 exceeds: 300ms
Sum of all benchmark exceeds: 317ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [8ef8ad7]
UI Startup Metrics (1203 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1203108813436212451308
load104493311906210921144
domContentLoaded103892811846110861137
domInteractive16134651630
firstPaint662127116642310531131
backgroundConnect74263710
firstReactRender19162722024
getState1554172028
initialActions001001
loadScripts79769194161845895
setupStore85182814
WebpackHomeuiStartup20991588258824022612484
load16271220198318617581900
domContentLoaded16201216197418417501891
domInteractive15115291341
firstPaint1586235155186274
backgroundConnect2310108122740
firstReactRender12644444101124346
getState184347451526
initialActions317135
loadScripts16171215196318317471880
setupStore5373289722313
FirefoxBrowserifyHomeuiStartup1348119317239413991549
load1193105814188512431365
domContentLoaded1193105814188512421365
domInteractive953518328110149
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211487102144
firstReactRender23205752327
getState9516917811
initialActions002001
loadScripts1174104113938412281337
setupStore9414716625
WebpackHomeuiStartup16111383231314716911884
load13891196198912914891573
domContentLoaded13891196198812914881573
domInteractive77311531984119
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2716451432449
firstReactRender43345344550
getState1053361028
initialActions102111
loadScripts13651178164011614691549
setupStore11525225918
Benchmark value 53 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2484 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 313 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1390 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1390 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1366 exceeds gate value 1360 for firefox webpack home mean loadScripts
Sum of mean exceeds: 55ms | Sum of p95 exceeds: 278ms
Sum of all benchmark exceeds: 333ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -22.62 KiB (-0.43%)
  • ui: 530 Bytes (0.01%)
  • common: 6.65 KiB (0.08%)

Also pin github tools to an specific version for the release process
@alucardzom alucardzom marked this pull request as ready for review June 11, 2025 10:56
@alucardzom alucardzom requested review from a team and Gudahtt June 11, 2025 11:05
@metamaskbot
Copy link
Collaborator

Builds ready [a09dc87]
UI Startup Metrics (1235 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1235109415197012891336
load106894713196611101167
domContentLoaded106094313116611031161
domInteractive17137371630
firstPaint78882131641611021165
backgroundConnect94466924
firstReactRender22164562237
getState1563582030
initialActions001000
loadScripts817699106064862912
setupStore95264916
WebpackHomeuiStartup20811654255322822172474
load16241286194918217681903
domContentLoaded16181283194118017651883
domInteractive15115171336
firstPaint1616262375180264
backgroundConnect21106582540
firstReactRender12344361102109338
getState155312311227
initialActions613083034
loadScripts16151281193917917631873
setupStore52732310017315
FirefoxBrowserifyHomeuiStartup1346117816708913811532
load1187105914077212181360
domContentLoaded1187105814077212181360
domInteractive963618923106135
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313152192248
firstReactRender24206162430
getState11418325814
initialActions001001
loadScripts1166103413866811991313
setupStore74376713
WebpackHomeuiStartup15531376200212216461765
load13441180159110914361551
domContentLoaded13431180159110914361551
domInteractive76311461983117
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22164162337
firstReactRender42325244447
getState105668929
initialActions102111
loadScripts13241163157310914161528
setupStore95739812
Benchmark value 1235 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 52 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2474 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 315 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 26ms | Sum of p95 exceeds: 276ms
Sum of all benchmark exceeds: 302ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Since release numbers are release/x.y.z
jake-perkins
jake-perkins previously approved these changes Jun 11, 2025
@Gudahtt
Copy link
Member

Gudahtt commented Jun 13, 2025

To clarify the intended scope here, is it correct that this is not intended to change any of the branch names that we actively use? Just to update reactive workflows so that they don't require updates later when the branch name does change?

I still see many references to master in scripts and docs, I wasn't sure if they were intentionally skipped or not.

@Gudahtt
Copy link
Member

Gudahtt commented Jun 13, 2025

There are more references to the Version-vX.Y.Z pattern in close-release-bug-report-issue and publish-prerelease.yml

To make it compatible with the release/x.y.z branch naming
@metamaskbot
Copy link
Collaborator

Builds ready [6b00dea]
UI Startup Metrics (1192 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1192109115166312351288
load102794012665510591111
domContentLoaded102193612505410541104
domInteractive18135071640
firstPaint660137114640510251094
backgroundConnect73162811
firstReactRender20154051934
getState1564492230
initialActions50276817
loadScripts776690100053808855
setupStore84264815
WebpackHomeuiStartup22331675319424023372673
load16561239230718917501989
domContentLoaded16491235228918817461973
domInteractive191398161562
firstPaint1606231959194303
backgroundConnect3110450502944
firstReactRender25687413120376401
getState195347372034
initialActions11227627927
loadScripts16461234227618617451962
setupStore227328392146
FirefoxBrowserifyHomeuiStartup14221228193214414851756
load1234107215479912951423
domContentLoaded1234107215479912951423
domInteractive1163450381123305
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2414100142358
firstReactRender25207672532
getState14599181043
initialActions407711215
loadScripts1214105715319712761406
setupStore12421528749
WebpackHomeuiStartup16871443252822317512131
load14101211198815514971739
domContentLoaded14091210198715514961739
domInteractive101505616796280
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2515141142546
firstReactRender58448876267
getState217270421362
initialActions7122022719
loadScripts13891194196615314761697
setupStore18628442940
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2234 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 256 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2674 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 27 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1423 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1756 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 305 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 43 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 49 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1688 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1410 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1410 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 22 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1390 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2131 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 280 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 62 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1697 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 40 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 311ms | Sum of p95 exceeds: 1172.8ms
Sum of all benchmark exceeds: 1483.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 7.09 KiB (0.13%)
  • ui: 14.66 KiB (0.2%)
  • common: 36.06 KiB (0.42%)

cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

Builds ready [c59ae7c]
UI Startup Metrics (1233 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1233110614286012641362
load106394912475810971179
domContentLoaded105694512415810891172
domInteractive18135471838
firstPaint699158125742010741174
backgroundConnect2582402939263273
firstReactRender20143852031
getState11480121230
initialActions30174214
loadScripts80470396956838920
setupStore74314715
WebpackHomeuiStartup23141870276518924172683
load17551342207517018592017
domContentLoaded17491338206216918532010
domInteractive181375131557
firstPaint1616337468198300
backgroundConnect241169102945
firstReactRender22689471112352395
getState154201261425
initialActions13227936736
loadScripts17451336204916818491997
setupStore227317402049
FirefoxBrowserifyHomeuiStartup13901169203016214601692
load11991039148610312611389
domContentLoaded11991039148610312601389
domInteractive1133553791102344
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2513165222455
firstReactRender23194032431
getState12220929676
initialActions4018719212
loadScripts11801026147010212441367
setupStore12322527661
WebpackHomeuiStartup17261494275720717822095
load14421247204813515271689
domContentLoaded14421246204813515261688
domInteractive98614195399200
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2817152182861
firstReactRender584211796169
getState1023791134
initialActions6010212319
loadScripts14201229201413315071641
setupStore17523837897
Benchmark value 258 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 274 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2314 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1755 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1749 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 14 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1745 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2683 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2010 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 36 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1997 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1692 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 344 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 76 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 61 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1727 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1443 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1442 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1420 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2095 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1689 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1688 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 200 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1641 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 97 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 856ms | Sum of p95 exceeds: 1252.8ms
Sum of all benchmark exceeds: 2108.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

Builds ready [63e4649]
UI Startup Metrics (1258 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1258113415336412971368
load107998613155511151159
domContentLoaded107197813075611101153
domInteractive18135081642
firstPaint670137118643410831133
backgroundConnect2101952398213227
firstReactRender20145052136
getState1134591530
initialActions30225216
loadScripts868778109755906949
setupStore74243711
WebpackHomeuiStartup22881809282116323992500
load17871352229517618902104
domContentLoaded17811346227117518852089
domInteractive1912123191460
firstPaint1656452479198345
backgroundConnect4393867030268
firstReactRender1858745581233349
getState153263301323
initialActions72517724
loadScripts17741342225917218742084
setupStore185254331635
FirefoxBrowserifyHomeuiStartup14851288214713815231802
load1282109516368613301454
domContentLoaded1282109516368613291454
domInteractive1083634161111307
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect271492142660
firstReactRender27206582854
getState113159191337
initialActions6018419416
loadScripts1259108116138413081420
setupStore11317521751
WebpackHomeuiStartup17411435249019918492179
load14721220188314115701761
domContentLoaded14711219188314115691761
domInteractive101354176293267
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3117245253165
firstReactRender51416665561
getState103199211023
initialActions8121529414
loadScripts14461198185213415461707
setupStore154231331331
Benchmark value 1259 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1079 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1072 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 868 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 949 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2289 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1788 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1781 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 44 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 1774 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2500 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2105 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2089 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 346 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 269 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 24 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2085 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1485 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1283 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1283 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1260 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1802 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 307 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 51 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1742 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1472 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1472 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1447 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2179 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1761 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1761 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 267 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1707 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 1249ms | Sum of p95 exceeds: 1750.8ms
Sum of all benchmark exceeds: 2999.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 38 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 21, 2025
cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

Builds ready [3afb402]
UI Startup Metrics (1242 ± 51 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1242112214245112751328
load106392712865010981143
domContentLoaded105592212805110911135
domInteractive18135181639
firstPaint68775114642610651119
backgroundConnect2091962689211226
firstReactRender2214161152335
getState124112131430
initialActions30305316
loadScripts853719107552889940
setupStore74172712
WebpackHomeuiStartup23421823268116824492548
load18231346218618819342136
domContentLoaded18141341217918819192131
domInteractive2113202251572
firstPaint176631944199193320
backgroundConnect379417623248
firstReactRender1988941384244381
getState1033051220
initialActions10217427619
loadScripts18101338216918819172128
setupStore1363561625
FirefoxBrowserifyHomeuiStartup15131323204213615601808
load1304115816088813491508
domContentLoaded1303115816078813491508
domInteractive1103647166109300
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect271672112847
firstReactRender28206693060
getState182190399169
initialActions6018024213
loadScripts1281113915838713271478
setupStore13429632742
WebpackHomeuiStartup17521478344926118392198
load14791277199116315871866
domContentLoaded14791277199116315871866
domInteractive103343837492319
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect411513761352961
firstReactRender51416965463
getState122229231328
initialActions7021023424
loadScripts14571257196016015581835
setupStore16424941844
Benchmark value 1242 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 210 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 854 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2342 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1824 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1815 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1810 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2548 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2136 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2132 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 381 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 19 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2129 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1514 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1304 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1304 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 18 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1281 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1808 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1508 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1508 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 300 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 60 exceeds gate value 55 for firefox browserify home p95 firstReactRender
Benchmark value 169 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1478 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 42 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1752 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1480 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1479 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1457 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2198 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1866 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1866 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 319 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 24 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1835 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 44 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 1507ms | Sum of p95 exceeds: 2311.8ms
Sum of all benchmark exceeds: 3818.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 38 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 21, 2025
@HowardBraham HowardBraham changed the title feat(gh-actions): unify version release workflows ci(gh-actions): unify version release workflows Jul 21, 2025
@HowardBraham HowardBraham added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jul 21, 2025
Copy link
Contributor

@gauthierpetetin gauthierpetetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes, it's great to see we're aligning Extension and Mobile branch naming!
I just have a few non-blocking questions/comments:

-  check-pr-max-lines
- auto-update-pr-targeting-release.yml
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Workflow Fails When PR Targets Stable Branch

The publish-prerelease.yml workflow's script for finding associated PRs hardcodes base: 'master' in its GitHub API call. As release/ branches can now target the stable branch, this prevents the script from finding PRs that target stable. Consequently, the prerelease publishing workflow will fail or skip steps for releases targeting stable.

.github/workflows/publish-prerelease.yml#L43-L46

repo: context.repo.repo,
head: `${context.repo.owner}:${process.env.BRANCH}`,
base: 'master',
});

Fix in Cursor Fix in Web

Copy link
Contributor

@gauthierpetetin gauthierpetetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [24d6dae]
UI Startup Metrics (1269 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1269112114686013061370
load108597812355311261175
domContentLoaded107897412305411211168
domInteractive18134781639
firstPaint66396117543610911143
backgroundConnect2111972518213230
firstReactRender2315177172334
getState113112141025
initialActions5010211715
loadScripts874775102253916961
setupStore74183713
WebpackHomeuiStartup24971925307418525702894
load19911425253418220692372
domContentLoaded19831421250818020612362
domInteractive2613257401672
firstPaint17863676103203380
backgroundConnect56123017737275
firstReactRender1649236161197304
getState2542445317236
initialActions72397724
loadScripts19731418249517220502261
setupStore177215211931
FirefoxBrowserifyHomeuiStartup14591256218613315301634
load1257111015028013171406
domContentLoaded1257111015028013171406
domInteractive96343284798224
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3016106163164
firstReactRender25205042733
getState925891129
initialActions30225315
loadScripts1232109114307712851386
setupStore14429232860
WebpackHomeuiStartup18221595220114919562074
load15381319187813216371781
domContentLoaded15381318187813216361781
domInteractive1083435258106285
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect322179133863
firstReactRender55437265965
getState133126171537
initialActions619311521
loadScripts15121297185513116081746
setupStore13513620946
Benchmark value 1269 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1086 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1078 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 874 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1370 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 230 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 961 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2498 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1992 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1983 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 26 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 56 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 1973 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2895 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2372 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2362 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 380 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 276 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 236 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 24 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2262 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1459 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1258 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1258 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1232 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 224 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 60 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1823 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1539 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1538 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 56 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1513 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2074 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1781 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1781 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 285 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 63 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1746 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 46 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 2298ms | Sum of p95 exceeds: 2765.8ms
Sum of all benchmark exceeds: 5063.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 45.9 KiB (0.85%)
  • ui: 438 Bytes (0.01%)
  • common: -24.08 KiB (-0.28%)

@alucardzom alucardzom added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit 45e8b2f Jul 30, 2025
273 of 275 checks passed
@alucardzom alucardzom deleted the ale/unify-release-branch-naming branch July 30, 2025 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2025
@metamaskbot metamaskbot added the release-13.1.0 Issue or pull request that will be included in release 13.1.0 label Jul 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.1.0 Issue or pull request that will be included in release 13.1.0 team-dev-ops DevOps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants