-
Notifications
You must be signed in to change notification settings - Fork 5.4k
ci(gh-actions): unify version release workflows #33555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For unifiying the release branch naming between extension and mobile, we must upgrade some workflows and scripts to make it compatible. We also keep the retrocompatibility between the current workflow, and the new one, ensuring the process works smoothly and without interruptions.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
Builds ready [dc8d22a]
UI Startup Metrics (1208 ± 66 ms)
Benchmark value 42 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2500 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 306 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 30 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 17ms | Sum of p95 exceeds: 300ms Sum of all benchmark exceeds: 317ms Bundle size diffs
|
Builds ready [8ef8ad7]
UI Startup Metrics (1203 ± 62 ms)
Benchmark value 2484 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 313 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1390 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1390 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1366 exceeds gate value 1360 for firefox webpack home mean loadScripts Sum of mean exceeds: 55ms | Sum of p95 exceeds: 278ms Sum of all benchmark exceeds: 333ms Bundle size diffs [🚀 Bundle size reduced!]
|
Also pin github tools to an specific version for the release process
Builds ready [a09dc87]
UI Startup Metrics (1235 ± 70 ms)
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 52 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2474 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 315 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 26ms | Sum of p95 exceeds: 276ms Sum of all benchmark exceeds: 302ms Bundle size diffs
|
Since release numbers are release/x.y.z
|
To clarify the intended scope here, is it correct that this is not intended to change any of the branch names that we actively use? Just to update reactive workflows so that they don't require updates later when the branch name does change? I still see many references to |
|
There are more references to the |
To make it compatible with the release/x.y.z branch naming
Builds ready [6b00dea]
UI Startup Metrics (1192 ± 63 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2234 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 256 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2674 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 27 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1423 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1756 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 305 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 43 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 49 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1688 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1410 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1410 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 22 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1390 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2131 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 280 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 62 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1697 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 40 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 311ms | Sum of p95 exceeds: 1172.8ms Sum of all benchmark exceeds: 1483.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [c59ae7c]
UI Startup Metrics (1233 ± 60 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 274 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2314 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1755 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1749 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 14 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1745 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2683 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2010 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1997 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1692 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 344 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 76 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 61 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1727 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1443 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1442 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1420 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2095 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1689 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1688 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 200 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1641 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 97 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 856ms | Sum of p95 exceeds: 1252.8ms Sum of all benchmark exceeds: 2108.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [63e4649]
UI Startup Metrics (1258 ± 64 ms)
Benchmark value 1079 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1072 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 868 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 949 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2289 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1788 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1781 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 44 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1774 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2500 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2105 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2089 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 346 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 269 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 24 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2085 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1485 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1283 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1283 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1260 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1802 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 307 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 51 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1742 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1472 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1472 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1447 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2179 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1761 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1761 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 267 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1707 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1249ms | Sum of p95 exceeds: 1750.8ms Sum of all benchmark exceeds: 2999.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [3afb402]
UI Startup Metrics (1242 ± 51 ms)
Benchmark value 210 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 854 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2342 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1824 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1815 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1810 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2548 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2136 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2132 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 381 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 19 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2129 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1514 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1304 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1304 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 18 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1281 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1808 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1508 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1508 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 300 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 60 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 169 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1478 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 42 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1752 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1480 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1479 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1457 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2198 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1866 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1866 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 319 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 24 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1835 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 44 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1507ms | Sum of p95 exceeds: 2311.8ms Sum of all benchmark exceeds: 3818.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes, it's great to see we're aligning Extension and Mobile branch naming!
I just have a few non-blocking questions/comments:
- What is the exact scope of this PR, is it the entire .github folder? If yes, we could also update the following files:
- .github/CONTRIBUTING.md, where
masteris mentioned - .github/workflows/check-pr-max-lines.yml where
masterandVersion-vare mentioned - .github/workflows/auto-update-pr-targeting-release.yml where
Version-vis mentioned
- .github/CONTRIBUTING.md, where
- Will we do the same changes on the metamask-mobile repo?
- Is the ultimate goal, once all Github actions are identical on metamask-extension and metamask-mobile repos, to move them to github-tools repo, where we store all Github action shared between the two repos.
- Once we proceed with branch renaming, could you please let me know such that I update all Zapier automations? (documented on metamask-zaps repo)
- check-pr-max-lines - auto-update-pr-targeting-release.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Workflow Fails When PR Targets Stable Branch
The publish-prerelease.yml workflow's script for finding associated PRs hardcodes base: 'master' in its GitHub API call. As release/ branches can now target the stable branch, this prevents the script from finding PRs that target stable. Consequently, the prerelease publishing workflow will fail or skip steps for releases targeting stable.
.github/workflows/publish-prerelease.yml#L43-L46
metamask-extension/.github/workflows/publish-prerelease.yml
Lines 43 to 46 in 24d6dae
| repo: context.repo.repo, | |
| head: `${context.repo.owner}:${process.env.BRANCH}`, | |
| base: 'master', | |
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [24d6dae]
UI Startup Metrics (1269 ± 60 ms)
Benchmark value 1086 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1078 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 874 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1370 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 230 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 961 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2498 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1992 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1983 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 26 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 56 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1973 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2895 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2372 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2362 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 380 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 276 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 236 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 24 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2262 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1459 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1258 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1258 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1232 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 224 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 60 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1823 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1539 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1538 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 56 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1513 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2074 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1781 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1781 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 285 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 63 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1746 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 46 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2298ms | Sum of p95 exceeds: 2765.8ms Sum of all benchmark exceeds: 5063.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR aims to unify the release branch naming conventions between the extension and mobile projects, and to prepare the onboard of the
stablebranch instead of usingmaster.To achieve this, we have updated relevant workflows and scripts to ensure compatibility with the new naming standard.
Key Changes
Workflow and Script Updates:
Backward Compatibility:
Impact
These changes will streamline the release process across projects, improve consistency, and reduce potential confusion caused by differing branch naming conventions.
Changelog
CHANGELOG entry: null
Related issues
https://github.com/MetaMask/MetaMask-planning/issues/4858
Manual testing steps'
Screenshots/Recordings
Current execution:

Updated workflow:

Pre-merge author checklist
Pre-merge reviewer checklist