-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: New SRP confirm UI #33290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: New SRP confirm UI #33290
+399
−272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/srp-flow-confirm
- remove unused css - align modal center
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux (5 files, +363 -164)
|
Builds ready [b095803]
UI Startup Metrics (1213 ± 64 ms)
Benchmark value 43 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2476 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 304 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1675 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1674 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 1654 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 16ms | Sum of p95 exceeds: 339ms Sum of all benchmark exceeds: 355ms |
Builds ready [aa991ae]
UI Startup Metrics (1219 ± 69 ms)
Benchmark value 41 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2531 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 242 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 274 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Sum of mean exceeds: 14ms | Sum of p95 exceeds: 339ms Sum of all benchmark exceeds: 353ms |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New SRP confirm UI
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist