Skip to content

feat: New SRP confirm UI #33290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 31, 2025
Merged

Conversation

lionellbriones
Copy link

@lionellbriones lionellbriones commented May 29, 2025

Description

New SRP confirm UI

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@lionellbriones lionellbriones requested a review from a team as a code owner May 29, 2025 17:09
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-web3auth prs related to web3auth team label May 29, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented May 29, 2025

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux (5 files, +363 -164)
  • 📁 ui/
    • 📁 pages/
      • 📁 onboarding-flow/
        • 📁 recovery-phrase/
          • 📄 confirm-recovery-phrase.js +159 -87
          • 📄 confirm-recovery-phrase.test.js +46 -31
          • 📄 confirm-srp-modal.stories.tsx +61 -0
          • 📄 confirm-srp-modal.tsx +97 -0
          • 📄 index.scss +0 -46

@metamaskbot
Copy link
Collaborator

Builds ready [b095803]
UI Startup Metrics (1213 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1213109613576412651318
load104593511626011001147
domContentLoaded103791411536110941142
domInteractive1713113111631
firstPaint683103116142410571147
backgroundConnect94305925
firstReactRender20155562027
getState1463672026
initialActions001001
loadScripts79768791259849899
setupStore85192811
WebpackHomeuiStartup20901705255521522432476
load16171301192415117171866
domContentLoaded16101295191414917101856
domInteractive15114581343
firstPaint1746345375216334
backgroundConnect22986102738
firstReactRender1344335897157327
getState144319311319
initialActions316135
loadScripts16071294190314817081845
setupStore4273108119304
FirefoxBrowserifyHomeuiStartup13491149174513514061630
load11921024158712512561478
domContentLoaded11921024158712512551477
domInteractive993725233110166
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413222232152
firstReactRender24206472331
getState11316819837
initialActions001001
loadScripts1170991156412312371457
setupStore9418219630
WebpackHomeuiStartup15601330215617016551922
load13501154187315714471675
domContentLoaded13501153187215714461674
domInteractive81502332387112
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22159192441
firstReactRender41285654451
getState12426426929
initialActions001011
loadScripts13321140185515514301654
setupStore85243813
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 43 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2476 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 304 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1675 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1674 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 1654 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 339ms
Sum of all benchmark exceeds: 355ms

@lionellbriones lionellbriones changed the title Feat: New SRP confirm UI feat: New SRP confirm UI May 30, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [aa991ae]
UI Startup Metrics (1219 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1219109214426912651345
load105593212606511001180
domContentLoaded104892412546510921172
domInteractive181396101633
firstPaint793133120439210931136
backgroundConnect85244823
firstReactRender21154652132
getState1563772029
initialActions001001
loadScripts80969499063853919
setupStore85263812
WebpackHomeuiStartup21711714262722923532531
load16791335200617618231939
domContentLoaded16691331199617418101930
domInteractive161160101344
firstPaint1796454380211324
backgroundConnect329344462954
firstReactRender14844392112301335
getState2653166313242
initialActions318135
loadScripts16651329198417318071919
setupStore4073187721274
FirefoxBrowserifyHomeuiStartup13321143171111814031555
load11781015151210812491416
domContentLoaded11781015151210812491415
domInteractive963923531114150
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113110132036
firstReactRender25207382451
getState10420620812
initialActions001001
loadScripts11601002147710712291395
setupStore64213610
WebpackHomeuiStartup15491358204314316411858
load13351166180913414221580
domContentLoaded13351166180813414221580
domInteractive83482673184145
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22156392346
firstReactRender41275254451
getState94315922
initialActions102111
loadScripts13161151179013414001563
setupStore11524325825
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 41 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2531 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 242 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 274 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Sum of mean exceeds: 14ms | Sum of p95 exceeds: 339ms
Sum of all benchmark exceeds: 353ms

@lionellbriones lionellbriones merged commit 6fb7163 into feat/srp-flow-review May 31, 2025
97 of 150 checks passed
@lionellbriones lionellbriones deleted the feat/srp-flow-confirm branch May 31, 2025 03:21
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-web3auth prs related to web3auth team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants