-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: New metametrics design #33286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lionellbriones
wants to merge
31
commits into
feat/srp-flow-secure-your-wallet
Choose a base branch
from
feat/srp-flow-metametrics
base: feat/srp-flow-secure-your-wallet
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: New metametrics design #33286
lionellbriones
wants to merge
31
commits into
feat/srp-flow-secure-your-wallet
from
feat/srp-flow-metametrics
+199
−304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feat/srp-flow-metametrics
…' into feat/srp-flow-metametrics
…' into feat/srp-flow-metametrics
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux (4 files, +192 -195)
|
Builds ready [7f96db4]
UI Startup Metrics (1219 ± 60 ms)
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 36 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2484 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 294 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 1676 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1434 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1434 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1413 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 1995 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1782 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1782 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 56 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 1763 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 239ms | Sum of p95 exceeds: 719ms Sum of all benchmark exceeds: 958ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…et' into feat/srp-flow-metametrics
Builds ready [41e113c]
UI Startup Metrics (1241 ± 70 ms)
Benchmark value 1074 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1066 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1209 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1204 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1216 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 955 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 36 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2546 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 235 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 298 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1945 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1679 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1679 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1660 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 24ms | Sum of p95 exceeds: 548ms Sum of all benchmark exceeds: 572ms |
Builds ready [415fca8]
UI Startup Metrics (1297 ± 81 ms)
Benchmark value 1118 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1109 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 874 exceeds gate value 800 for chrome browserify home mean firstPaint Benchmark value 11 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 852 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1453 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1257 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1249 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1256 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 30 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 999 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 47 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2514 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 309 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1965 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1724 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1724 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 1706 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 281ms | Sum of p95 exceeds: 917ms Sum of all benchmark exceeds: 1198ms |
…o feat/srp-flow-metametrics
Builds ready [a4a1d79]
UI Startup Metrics (1215 ± 67 ms)
Benchmark value 46 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 302 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Sum of mean exceeds: 24ms | Sum of p95 exceeds: 244ms Sum of all benchmark exceeds: 268ms |
Builds ready [7db9f0c]
UI Startup Metrics (1206 ± 57 ms)
Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 49 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 50 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1712 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1711 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 1691 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 25ms | Sum of p95 exceeds: 438ms Sum of all benchmark exceeds: 463ms |
Builds ready [799a2c6]
UI Startup Metrics (1223 ± 76 ms)
Benchmark value 2227 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 56 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2610 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 301 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1663 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1515 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1514 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 1492 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 2015 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1785 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1785 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 1769 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 64ms | Sum of p95 exceeds: 927ms Sum of all benchmark exceeds: 991ms |
Builds ready [1f920f5]
UI Startup Metrics (1197 ± 69 ms)
Benchmark value 49 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2467 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 303 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 157 exceeds gate value 156 for firefox webpack home p95 domInteractive Sum of mean exceeds: 24ms | Sum of p95 exceeds: 273ms Sum of all benchmark exceeds: 297ms |
…et' into feat/srp-flow-metametrics
Builds ready [8fdd607]
UI Startup Metrics (1205 ± 69 ms)
Benchmark value 41 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2458 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 304 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1992 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1710 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1710 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 1689 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 17ms | Sum of p95 exceeds: 468ms Sum of all benchmark exceeds: 485ms |
chaitanyapotti
approved these changes
May 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated metametrics UI
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist