-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: base account details #33277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hmalik88
wants to merge
7
commits into
main
Choose a base branch
from
hm/mul-169
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: base account details #33277
+240
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (5 files, +231 -0)
|
Builds ready [04332d3]
UI Startup Metrics (1230 ± 67 ms)
Benchmark value 2226 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1728 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1720 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1716 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 38 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2588 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 277 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 93ms | Sum of p95 exceeds: 355ms Sum of all benchmark exceeds: 448ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [4d9f80d]
UI Startup Metrics (1225 ± 61 ms)
Benchmark value 43 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 301 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1659 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1415 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1414 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1390 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2045 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1738 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1717 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 170ms | Sum of p95 exceeds: 601ms Sum of all benchmark exceeds: 771ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [e33a8b4]
UI Startup Metrics (1185 ± 72 ms)
Benchmark value 45 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2484 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 300 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1959 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1696 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 16ms | Sum of p95 exceeds: 469ms Sum of all benchmark exceeds: 485ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist