Skip to content

feat: base account details #33277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: base account details #33277

wants to merge 7 commits into from

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented May 29, 2025

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change?
  2. What is the improvement/solution?

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label May 29, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented May 29, 2025

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (5 files, +231 -0)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain-accounts/
        • 📁 account-details-row/
          • 📄 account-details-row.tsx +35 -0
          • 📄 index.ts +1 -0
        • 📁 base-account-details/
          • 📄 base-account-details.tsx +134 -0
        • 📁 edit-account-name-modal/
          • 📄 edit-account-name-modal.tsx +60 -0
          • 📄 index.ts +1 -0

@metamaskbot
Copy link
Collaborator

Builds ready [04332d3]
UI Startup Metrics (1230 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1230110313716712801345
load106494212206811101175
domContentLoaded105793712146811041169
domInteractive16133341630
firstPaint763130122142210941172
backgroundConnect94336826
firstReactRender20164232025
getState1463171928
initialActions001001
loadScripts81670097168863929
setupStore75152810
WebpackHomeuiStartup22261809270221023602588
load17281404210116018431987
domContentLoaded17201400208715618361972
domInteractive161272101343
firstPaint1716632961203298
backgroundConnect2610163173050
firstReactRender17444378117307357
getState165349341630
initialActions612412446
loadScripts17161398207515518321961
setupStore3773177123277
FirefoxBrowserifyHomeuiStartup13341153175711714001570
load11851022159511612521432
domContentLoaded11851022159511612511432
domInteractive1033227436117168
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20137282040
firstReactRender24205862428
getState74383810
initialActions002001
loadScripts11671009158011612381411
setupStore74799613
WebpackHomeuiStartup15331346198512416131749
load13281165161511214211532
domContentLoaded13281164161511214201532
domInteractive79491381887123
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21157682130
firstReactRender40285144347
getState10417317920
initialActions001011
loadScripts13091149159711214051510
setupStore10525925815
Benchmark value 27 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2226 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1728 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1720 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1716 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 38 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2588 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 277 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 93ms | Sum of p95 exceeds: 355ms
Sum of all benchmark exceeds: 448ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.12 KiB (0.08%)
  • ui: 6.58 KiB (0.09%)
  • common: 46.58 KiB (0.57%)

@metamaskbot
Copy link
Collaborator

Builds ready [4d9f80d]
UI Startup Metrics (1225 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1225111214136112631341
load105794412496010921168
domContentLoaded105093612406010881161
domInteractive16133641627
firstPaint738165124941110811150
backgroundConnect84365822
firstReactRender20164452029
getState1464882030
initialActions001001
loadScripts80970799760849921
setupStore85172811
WebpackHomeuiStartup20761701254420422372429
load16111331196914817161847
domContentLoaded16051327196014717101836
domInteractive15116091342
firstPaint184651713170207291
backgroundConnect2295372535
firstReactRender1304337099141341
getState144305301324
initialActions318135
loadScripts16011326194914517071826
setupStore4273108219301
FirefoxBrowserifyHomeuiStartup13481174184512413931608
load1194992153310812541437
domContentLoaded1194992153210812531436
domInteractive944117222105128
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213302292126
firstReactRender25205992453
getState9416817815
initialActions001001
loadScripts1174978151110712341415
setupStore64385610
WebpackHomeuiStartup16581432219217817682045
load14141220189015614801739
domContentLoaded14141219189015614791738
domInteractive79371752086125
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2817262252750
firstReactRender46335844953
getState185243331434
initialActions102111
loadScripts13891202187215114591717
setupStore146237311029
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 43 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 301 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1659 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1415 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1414 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1390 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2045 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1738 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1717 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 170ms | Sum of p95 exceeds: 601ms
Sum of all benchmark exceeds: 771ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 139 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [e33a8b4]
UI Startup Metrics (1185 ± 72 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1185107214197212371333
load102891412416810781163
domContentLoaded102190912336810731156
domInteractive16139691529
firstPaint709157117439910381138
backgroundConnect84365821
firstReactRender20164152033
getState1464482026
initialActions002001
loadScripts78468197367835926
setupStore84243814
WebpackHomeuiStartup21031663254522122482483
load16201225195516817371871
domContentLoaded16131217194616717301855
domInteractive151160101342
firstPaint1676530256204279
backgroundConnect2910420522540
firstReactRender14143354106258337
getState164304341428
initialActions315135
loadScripts16101213193616517261844
setupStore4573108320300
FirefoxBrowserifyHomeuiStartup13331160187311513721559
load11851011173911812391424
domContentLoaded11851011173811812381424
domInteractive973817826110149
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2212105132152
firstReactRender23205762328
getState74353810
initialActions002001
loadScripts1166993172011712221404
setupStore74727611
WebpackHomeuiStartup15551360212716616531959
load13471179187414714231715
domContentLoaded13471179187314714231715
domInteractive80412793285119
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2415214202441
firstReactRender41275444349
getState11522522924
initialActions002111
loadScripts13261164185214414051696
setupStore84555810
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 45 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2484 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 300 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1959 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1696 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 469ms
Sum of all benchmark exceeds: 485ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 264 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants