-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: New create password design #33263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lionellbriones
wants to merge
32
commits into
feat/srp-flow-header
Choose a base branch
from
feat/srp-flow-create-password
base: feat/srp-flow-header
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: New create password design #33263
lionellbriones
wants to merge
32
commits into
feat/srp-flow-header
from
feat/srp-flow-create-password
+337
−631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/srp-flow-create-password
…srp-flow-create-password
…srp-flow-create-password
- style fixes
- toggle password button stop propagating
…srp-flow-create-password
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [e18dfcd]
UI Startup Metrics (1224 ± 87 ms)
Benchmark value 1203 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1197 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1190 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 959 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 56 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2459 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 28ms | Sum of p95 exceeds: 330ms Sum of all benchmark exceeds: 358ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +1 -0)
🎨 @MetaMask/design-system-engineers (1 files, +1 -0)
🖥️ @MetaMask/wallet-ux (4 files, +286 -412)
|
Builds ready [c90969a]
UI Startup Metrics (1204 ± 64 ms)
Benchmark value 34 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2512 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 302 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1496 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1496 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 5ms | Sum of p95 exceeds: 303ms Sum of all benchmark exceeds: 308ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [0a031af]
UI Startup Metrics (1213 ± 61 ms)
Benchmark value 2202 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 42 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2539 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 310 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 24ms | Sum of p95 exceeds: 338ms Sum of all benchmark exceeds: 362ms |
… into feat/srp-flow-create-password
Builds ready [0f8123c]
UI Startup Metrics (1234 ± 60 ms)
Benchmark value 50 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 301 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 1682 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1682 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 1663 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 24ms | Sum of p95 exceeds: 324ms Sum of all benchmark exceeds: 348ms |
Builds ready [d78c51f]
UI Startup Metrics (1201 ± 68 ms)
Benchmark value 2277 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1783 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1773 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1769 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 37 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2636 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2054 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2037 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 2026 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 316 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1680 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1680 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1661 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 306ms | Sum of p95 exceeds: 624ms Sum of all benchmark exceeds: 930ms |
Builds ready [6329c75]
UI Startup Metrics (1205 ± 68 ms)
Benchmark value 53 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2463 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 305 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1676 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1675 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1658 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 25ms | Sum of p95 exceeds: 313ms Sum of all benchmark exceeds: 338ms |
Builds ready [f4b7299]
UI Startup Metrics (1239 ± 68 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 61 exceeds gate value 45 for chrome browserify home p95 firstReactRender Benchmark value 44 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2506 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 315 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 23ms | Sum of p95 exceeds: 332ms Sum of all benchmark exceeds: 355ms |
chaitanyapotti
approved these changes
May 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update onboarding create password page
create-password.mov
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist