Skip to content

feat: New create password design #33263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: feat/srp-flow-header
Choose a base branch
from

Conversation

lionellbriones
Copy link

@lionellbriones lionellbriones commented May 29, 2025

Description

Update onboarding create password page

create-password.mov

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

lionellbriones and others added 22 commits May 10, 2025 00:09
- toggle password button stop propagating
@lionellbriones lionellbriones requested review from a team as code owners May 29, 2025 06:22
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-web3auth prs related to web3auth team label May 29, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [e18dfcd]
UI Startup Metrics (1224 ± 87 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1224108715308712811374
load106293612948311231203
domContentLoaded105492512828311171196
domInteractive16133751628
firstPaint76682126141410921189
backgroundConnect94577922
firstReactRender19153832025
getState1464871926
initialActions001001
loadScripts815675102983872958
setupStore75152812
WebpackHomeuiStartup21011669258821822392459
load16151308198515917311869
domContentLoaded16081304197115817241860
domInteractive15116691339
firstPaint1576232362182287
backgroundConnect22115682637
firstReactRender15143469116306339
getState1256581425
initialActions315135
loadScripts16051302196015617231850
setupStore55631310021308
FirefoxBrowserifyHomeuiStartup13511163168812114351614
load11921015152811012651437
domContentLoaded11911015152711012651437
domInteractive963520632107168
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313132152253
firstReactRender24205742428
getState10418318828
initialActions001001
loadScripts1172992151411012411422
setupStore9421021620
WebpackHomeuiStartup15021320197013515901818
load12921145162811913521528
domContentLoaded12911144162811913521527
domInteractive77332873081101
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22155572240
firstReactRender40276454349
getState95356929
initialActions002111
loadScripts12731129161311913271508
setupStore13523932834
Benchmark value 1374 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1203 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1197 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1190 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 959 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 56 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2459 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 28ms | Sum of p95 exceeds: 330ms
Sum of all benchmark exceeds: 358ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -272 Bytes (0%)
  • ui: 15.12 KiB (0.21%)
  • common: 5.35 KiB (0.07%)

@lionellbriones lionellbriones changed the base branch from main to feat/srp-flow-header May 29, 2025 09:04
@metamaskbot
Copy link
Collaborator

metamaskbot commented May 29, 2025

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (1 files, +1 -0)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 confirmation/
          • 📁 templates/
            • 📁 __snapshots__/
              • 📄 create-named-snap-account.test.js.snap +1 -0

🎨 @MetaMask/design-system-engineers (1 files, +1 -0)
  • 📁 ui/
    • 📁 components/
      • 📁 component-library/
        • 📁 form-text-field/
          • 📄 form-text-field.tsx +1 -0

🖥️ @MetaMask/wallet-ux (4 files, +286 -412)
  • 📁 ui/
    • 📁 pages/
      • 📁 onboarding-flow/
        • 📁 create-password/
          • 📁 __snapshots__/
            • 📄 create-password.test.js.snap +129 -121
            • 📄 create-password.js +105 -214
            • 📄 create-password.test.js +52 -44
            • 📄 index.scss +0 -33

@metamaskbot
Copy link
Collaborator

Builds ready [c90969a]
UI Startup Metrics (1204 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1204109614336412561311
load103994612345910801139
domContentLoaded103294012286010701129
domInteractive16134251530
firstPaint73790119040810571135
backgroundConnect84345823
firstReactRender20155972034
getState1353071827
initialActions001001
loadScripts79270197058828893
setupStore85132812
WebpackHomeuiStartup21691729262321623172512
load16841337202516117781924
domContentLoaded16771333201816017701914
domInteractive161272111350
firstPaint1616237763200278
backgroundConnect24115893042
firstReactRender16244361113306343
getState194349471626
initialActions612862846
loadScripts16741332200715817681906
setupStore3473347022302
FirefoxBrowserifyHomeuiStartup12991130185214013271628
load11551006170013411811496
domContentLoaded11541005170013411811496
domInteractive88341612196131
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2112204202130
firstReactRender24205572449
getState7436489
initialActions002001
loadScripts1136992167612911671473
setupStore5417268
WebpackHomeuiStartup15141311208614515751811
load13071144168912713931535
domContentLoaded13071143168812613921534
domInteractive79491732286130
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect221599112143
firstReactRender40275244249
getState93325926
initialActions002111
loadScripts12891128167112513761513
setupStore12523429829
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 34 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2512 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 302 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1496 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1496 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 5ms | Sum of p95 exceeds: 303ms
Sum of all benchmark exceeds: 308ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 11.54 KiB (0.16%)
  • common: 180 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [0a031af]
UI Startup Metrics (1213 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1213108713996112541299
load105393812426211011151
domContentLoaded104592612366310921146
domInteractive17137781630
firstPaint798132124438810911146
backgroundConnect94476823
firstReactRender19153532023
getState1352961727
initialActions003001
loadScripts80669699762853901
setupStore75172811
WebpackHomeuiStartup22011749267021223472538
load16911326207516418011954
domContentLoaded16831317205916317931944
domInteractive161278121349
firstPaint1676449977179331
backgroundConnect3310422513061
firstReactRender15544386109281346
getState245356591657
initialActions319146
loadScripts16801314204816117901934
setupStore4263157724310
FirefoxBrowserifyHomeuiStartup13011142180212513611581
load1156993148811612181445
domContentLoaded1156993148811612181444
domInteractive993746650112169
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2012188181932
firstReactRender22205232327
getState10416617826
initialActions007101
loadScripts1137980147111112011392
setupStore74798613
WebpackHomeuiStartup15431357220314116221826
load13371168191913514201598
domContentLoaded13371168191913514191598
domInteractive82383163983112
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2415246232240
firstReactRender41284944447
getState95336931
initialActions002111
loadScripts13161144190213514021580
setupStore85586819
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2202 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 42 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2539 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 310 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 24ms | Sum of p95 exceeds: 338ms
Sum of all benchmark exceeds: 362ms

@metamaskbot
Copy link
Collaborator

Builds ready [0f8123c]
UI Startup Metrics (1234 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1234111413826012781332
load106795112356111101174
domContentLoaded105994712296111031159
domInteractive17144651729
firstPaint751147119241210841155
backgroundConnect94517827
firstReactRender20163332126
getState1563872126
initialActions001001
loadScripts81570898158859912
setupStore85212812
WebpackHomeuiStartup20771673252320122202382
load15921191191215617151817
domContentLoaded15871184190215617071813
domInteractive15116891240
firstPaint1746136967230309
backgroundConnect319438612635
firstReactRender13241390103140339
getState1042641217
initialActions315134
loadScripts15831179189115417021812
setupStore4963079318301
FirefoxBrowserifyHomeuiStartup13351170180012813991589
load11821033153311812501422
domContentLoaded11821033153211712501422
domInteractive963836941103166
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413235242150
firstReactRender24205472452
getState10421521811
initialActions002001
loadScripts11601014150711112321370
setupStore6425268
WebpackHomeuiStartup15621376213215916411914
load13371187190914913741682
domContentLoaded13361186190914913731682
domInteractive80351572187138
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect241583112345
firstReactRender42286154552
getState125227221030
initialActions102111
loadScripts13181171188814913561663
setupStore13525133826
Benchmark value 27 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 50 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 301 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 1682 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1682 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 1663 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 24ms | Sum of p95 exceeds: 324ms
Sum of all benchmark exceeds: 348ms

@metamaskbot
Copy link
Collaborator

Builds ready [d78c51f]
UI Startup Metrics (1201 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1201110314596812491320
load103790711696110791137
domContentLoaded102989911636110741132
domInteractive16133751631
firstPaint770129117839210691127
backgroundConnect94456926
firstReactRender2215114102134
getState1463372029
initialActions001000
loadScripts79065292260834894
setupStore85223815
WebpackHomeuiStartup22761775267620924352636
load17821348219218118982054
domContentLoaded17731344213717618922037
domInteractive16126491445
firstPaint1756846266208286
backgroundConnect3111333403249
firstReactRender16145352115307342
getState225312491450
initialActions317136
loadScripts17691342213517518902026
setupStore3773217324316
FirefoxBrowserifyHomeuiStartup13491158174712514231603
load11901013154111312641448
domContentLoaded11891012154111312641448
domInteractive923516625105140
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313177182346
firstReactRender25206382551
getState85273810
initialActions001001
loadScripts11691003152211012391393
setupStore8411513621
WebpackHomeuiStartup15641342220516516251903
load13501165195215614251680
domContentLoaded13491164195215614241680
domInteractive81352812684126
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2515216212343
firstReactRender41295244449
getState105397930
initialActions002111
loadScripts13281149193515514021661
setupStore10513013822
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2277 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1783 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1773 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1769 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 37 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2636 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2054 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2037 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 2026 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 316 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1680 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1680 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1661 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 306ms | Sum of p95 exceeds: 624ms
Sum of all benchmark exceeds: 930ms

@lwin-kyaw lwin-kyaw requested a review from a team as a code owner May 29, 2025 17:09
@metamaskbot
Copy link
Collaborator

Builds ready [6329c75]
UI Startup Metrics (1205 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1205108414346812481321
load104291212046510951151
domContentLoaded103489811996610861145
domInteractive17139691631
firstPaint73178115940810591150
backgroundConnect94275923
firstReactRender2115115112028
getState1555381928
initialActions001001
loadScripts79565994865847908
setupStore85222813
WebpackHomeuiStartup20831693257822322492463
load16071316198915917211878
domContentLoaded16011312198015817161870
domInteractive15116291342
firstPaint1606234962200282
backgroundConnect21104672535
firstReactRender12843447104128344
getState1133751323
initialActions315135
loadScripts15971310196915617141859
setupStore5273399721305
FirefoxBrowserifyHomeuiStartup13421144186413413861624
load1185996170711312441395
domContentLoaded1185996170711312441395
domInteractive97342973999165
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413228242058
firstReactRender23205742328
getState11520826810
initialActions001001
loadScripts1165981169211012181364
setupStore8417317612
WebpackHomeuiStartup15581332251619616451893
load13451148217817914451676
domContentLoaded13451148217817914441675
domInteractive77541591881122
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2415297282341
firstReactRender41345244447
getState10412112923
initialActions101011
loadScripts13241130192516914271658
setupStore85344817
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 53 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2463 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 305 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1676 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1675 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1658 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 25ms | Sum of p95 exceeds: 313ms
Sum of all benchmark exceeds: 338ms

@lionellbriones lionellbriones changed the title Feat: New create password design feat: New create password design May 30, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [f4b7299]
UI Startup Metrics (1239 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1239110714316812931335
load106590912167211211175
domContentLoaded105790312057311151169
domInteractive17133751630
firstPaint77794118340811021162
backgroundConnect94295924
firstReactRender2316142162161
getState1454371929
initialActions001001
loadScripts81065296273867925
setupStore85243816
WebpackHomeuiStartup21121703253422422872505
load16331333194317017491910
domContentLoaded16271329193416817421901
domInteractive15115891343
firstPaint1776170481214293
backgroundConnect22105682637
firstReactRender14042368112302341
getState174337431426
initialActions512572535
loadScripts16241328192316617401892
setupStore4473268719315
FirefoxBrowserifyHomeuiStartup13541164186912614201545
load11951029174211112691351
domContentLoaded11941029174111112681351
domInteractive1013820032113172
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413114172355
firstReactRender24205752429
getState84374814
initialActions001001
loadScripts11741008172611212471331
setupStore10419521735
WebpackHomeuiStartup15511339204315016061918
load13321161181312914151599
domContentLoaded13321161181312914151598
domInteractive79343183281146
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect241481102545
firstReactRender42285544449
getState145206221030
initialActions102111
loadScripts13111144179012813831568
setupStore95616818
Benchmark value 1239 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 61 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 44 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2506 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 315 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 23ms | Sum of p95 exceeds: 332ms
Sum of all benchmark exceeds: 355ms

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-onboarding team-web3auth prs related to web3auth team
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

4 participants