fix: adds 'auto' button for solana dynamic slippage, persists choice across sessions #33254

ghgoodreau · 2025-05-28T23:50:47Z

Description

Sets Solana slippage to 'Auto' in the UI to match with the dynamic slippage that is set by default.
Adds last selected Solana swaps slippage to preferences, so slippage is retained in history instead of resetting to dynamic each time. This is kept separate from EVM slippage.
Adds selectors to make setting and fetching this straightforward

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-05-28T23:51:00Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-05-28T23:52:47Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (3 files, +143 -26)

📁 ui/
- 📁 ducks/
  - 📁 bridge/
    - 📄 selectors.ts +38 -0
- 📁 pages/
  - 📁 bridge/
    - 📁 prepare/
      - 📄 bridge-transaction-settings-modal.tsx +90 -23
      - 📄 prepare-bridge-page.tsx +15 -3

metamaskbot · 2025-05-29T00:20:17Z

Builds ready [f3900fd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1235 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1235	1096	1389	72	1293	1336
			load	1073	943	1191	68	1129	1169
			domContentLoaded	1065	935	1181	70	1124	1162
			domInteractive	16	13	36	4	16	28
			firstPaint	805	98	1189	411	1127	1169
			backgroundConnect	9	4	33	6	8	25
			firstReactRender	20	15	47	5	20	32
			getState	14	5	31	6	20	26
			initialActions	0	0	1	0	0	1
			loadScripts	825	699	936	68	887	915
			setupStore	7	5	19	2	8	11
	Webpack	Home	uiStartup	2154	1709	2655	217	2312	2531
			load	1668	1329	2040	166	1784	1928
			domContentLoaded	1658	1325	2029	163	1778	1918
			domInteractive	16	12	59	10	13	47
			firstPaint	171	65	349	60	208	305
			backgroundConnect	29	10	339	45	27	42
			firstReactRender	153	43	339	106	297	328
			getState	24	4	331	60	15	44
			initialActions	6	1	271	27	3	5
			loadScripts	1655	1323	2018	161	1776	1908
			setupStore	27	6	316	55	20	30
Firefox	Browserify	Home	uiStartup	1312	1147	1760	126	1365	1601
			load	1163	1009	1602	119	1214	1428
			domContentLoaded	1163	1008	1602	119	1214	1427
			domInteractive	96	37	366	43	100	176
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	234	22	20	39
			firstReactRender	24	20	61	7	24	50
			getState	7	4	34	4	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1144	995	1585	116	1198	1382
			setupStore	7	4	34	5	6	15
	Webpack	Home	uiStartup	1553	1371	2045	141	1644	1881
			load	1344	1185	1786	135	1420	1671
			domContentLoaded	1343	1185	1786	135	1420	1670
			domInteractive	82	59	239	24	85	132
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	44	5	24	34
			firstReactRender	41	27	51	4	43	47
			getState	8	4	30	4	9	11
			initialActions	1	0	2	1	1	1
			loadScripts	1325	1168	1768	135	1404	1657
			setupStore	8	5	36	4	8	15

Benchmark value 1236 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1074 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1066 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 805 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2531 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1671 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1670 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1657 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 19ms | Sum of p95 exceeds: 133ms
Sum of all benchmark exceeds: 152ms

Bundle size diffs

background: 0 Bytes (0%)
ui: 838 Bytes (0.01%)
common: 0 Bytes (0%)

metamaskbot · 2025-05-29T20:16:58Z

Builds ready [d7e8387]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 94 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1239	1115	1886	94	1291	1383
			load	1069	942	1656	89	1108	1200
			domContentLoaded	1061	934	1649	90	1102	1188
			domInteractive	18	14	104	10	16	31
			firstPaint	777	165	1657	413	1095	1177
			backgroundConnect	9	4	28	5	9	26
			firstReactRender	20	16	32	3	21	25
			getState	15	6	48	8	21	28
			initialActions	0	0	1	0	0	1
			loadScripts	819	681	1408	89	861	936
			setupStore	8	5	18	2	8	12
	Webpack	Home	uiStartup	2162	1729	2590	217	2316	2549
			load	1676	1331	2133	166	1776	1956
			domContentLoaded	1667	1328	2002	159	1769	1942
			domInteractive	16	11	68	12	13	52
			firstPaint	164	65	319	56	191	276
			backgroundConnect	26	9	252	28	26	48
			firstReactRender	147	44	374	108	292	332
			getState	12	4	37	7	14	30
			initialActions	3	1	8	1	3	5
			loadScripts	1663	1326	2000	158	1764	1932
			setupStore	41	7	319	81	21	304
Firefox	Browserify	Home	uiStartup	1308	1105	1846	138	1355	1625
			load	1161	984	1693	130	1217	1458
			domContentLoaded	1161	984	1692	130	1217	1458
			domInteractive	92	42	279	31	99	133
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	79	9	22	40
			firstReactRender	23	20	56	6	22	26
			getState	9	4	191	19	8	15
			initialActions	0	0	1	0	0	1
			loadScripts	1143	972	1667	128	1189	1437
			setupStore	8	4	58	8	7	32
	Webpack	Home	uiStartup	1463	1305	1871	118	1543	1707
			load	1274	1137	1653	109	1348	1493
			domContentLoaded	1274	1136	1653	109	1347	1492
			domInteractive	73	34	286	31	74	112
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	15	50	6	20	34
			firstReactRender	38	25	53	5	41	47
			getState	10	4	178	17	8	20
			initialActions	1	0	1	0	1	1
			loadScripts	1256	1120	1638	108	1331	1468
			setupStore	7	5	31	3	8	9

Benchmark value 1239 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1383 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1201 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1188 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 42 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2549 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 304 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 384ms
Sum of all benchmark exceeds: 400ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 791 Bytes (0.01%)
ui: 7.4 KiB (0.1%)
common: 39.5 KiB (0.49%)

metamaskbot · 2025-05-29T22:27:15Z

Builds ready [e1b2561]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1232 ± 77 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1232	1089	1410	77	1287	1374
			load	1069	936	1231	74	1121	1205
			domContentLoaded	1062	931	1222	74	1113	1195
			domInteractive	17	13	99	10	16	31
			firstPaint	789	163	1212	406	1089	1174
			backgroundConnect	9	4	32	5	8	21
			firstReactRender	20	15	45	4	21	26
			getState	14	5	34	7	18	28
			initialActions	0	0	1	0	0	0
			loadScripts	823	692	978	72	868	953
			setupStore	7	5	14	2	8	11
	Webpack	Home	uiStartup	2105	1690	2497	228	2256	2472
			load	1637	1296	1928	170	1762	1889
			domContentLoaded	1631	1293	1920	169	1755	1879
			domInteractive	15	11	63	10	13	43
			firstPaint	170	67	356	58	204	281
			backgroundConnect	22	10	53	7	26	34
			firstReactRender	121	43	347	94	127	328
			getState	11	4	41	7	12	27
			initialActions	5	1	242	24	3	4
			loadScripts	1628	1291	1908	168	1752	1868
			setupStore	38	7	308	78	18	300
Firefox	Browserify	Home	uiStartup	1350	1150	1825	127	1413	1630
			load	1197	1020	1520	112	1278	1429
			domContentLoaded	1197	1019	1520	112	1278	1429
			domInteractive	101	36	442	48	108	142
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	196	20	20	42
			firstReactRender	25	20	65	8	24	52
			getState	8	4	65	7	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1176	1009	1504	109	1242	1376
			setupStore	9	4	190	20	6	18
	Webpack	Home	uiStartup	1511	1331	1862	122	1580	1763
			load	1308	1157	1647	106	1383	1510
			domContentLoaded	1308	1157	1647	106	1382	1510
			domInteractive	79	44	335	31	82	121
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	85	10	22	34
			firstReactRender	40	27	49	4	42	47
			getState	11	5	228	23	8	30
			initialActions	0	0	1	0	1	1
			loadScripts	1289	1142	1627	106	1366	1492
			setupStore	8	5	31	4	8	11

Benchmark value 1062 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1375 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1206 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1196 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 39 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2472 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 300 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 10ms | Sum of p95 exceeds: 311ms
Sum of all benchmark exceeds: 321ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 791 Bytes (0.01%)
ui: 7.4 KiB (0.1%)
common: 39.5 KiB (0.49%)

fix: auto button for solana swaps v1

f3900fd

metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label May 28, 2025

feat: dynamic slippage solana persistence

d7e8387

fix: tests

e1b2561

ghgoodreau marked this pull request as ready for review May 29, 2025 23:12

ghgoodreau requested a review from a team as a code owner May 29, 2025 23:12

ghgoodreau changed the title ~~fix: auto button for solana swaps slippage~~ fix: adds 'auto' button for solana dynamic slippage, persists choice across sessions May 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: adds 'auto' button for solana dynamic slippage, persists choice across sessions #33254

fix: adds 'auto' button for solana dynamic slippage, persists choice across sessions #33254

Uh oh!

ghgoodreau commented May 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

metamaskbot commented May 28, 2025 •

edited

Loading

Uh oh!

metamaskbot commented May 29, 2025

Uh oh!

metamaskbot commented May 29, 2025

Uh oh!

metamaskbot commented May 29, 2025

Uh oh!

Uh oh!

fix: adds 'auto' button for solana dynamic slippage, persists choice across sessions #33254

Are you sure you want to change the base?

fix: adds 'auto' button for solana dynamic slippage, persists choice across sessions #33254

Uh oh!

Conversation

ghgoodreau commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

metamaskbot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented May 29, 2025

Uh oh!

metamaskbot commented May 29, 2025

Uh oh!

metamaskbot commented May 29, 2025

Uh oh!

Uh oh!

ghgoodreau commented May 28, 2025 •

edited

Loading

metamaskbot commented May 28, 2025 •

edited

Loading