feat: Solana Wallet Standard #31705

baptiste-marchand · 2025-04-08T13:20:05Z

Description

This PR implements Solana Wallet Standard using script injection, enabling users use MetaMask on Solana dApps.

The communication between the dApp and MetaMask uses the Multichain API.

Related issues

Fixes:

Manual testing steps

Run yarn then yarn start:flask
If you already have a local Flask extension installed, then first uninstall it from chrome://extensions
Install the built flask build by loading dist/chrome and setup a Solana account
Go to any Solana Wallet Standard compatible app, such as Wallet Standard Demo or https://jup.ag/
Connect with MetaMask
Try the features proposed by the dApp

Screenshots/Recordings

MetaMask icon is the first one (the 2nd being Solflare):

Connection modal:

When connected:

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** This link was pointing to a dead site, this fixes it to point to the correct URL. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29733?quickstart=1) ## **Related issues** N/A ## **Manual testing steps** 1. Go to https://github.com/MetaMask/metamask-extension/blob/develop/docs/README.md 2. Click the link to Developer Docs ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2025-04-08T13:21:05Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub ↗.

	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@solana/wallet-standard-chains@1.1.1
	@solana/wallet-standard-features@1.3.0
	@wallet-standard/wallet@1.1.0
	@wallet-standard/base@1.1.0
	@wallet-standard/features@1.1.0
	@metamask/solana-wallet-standard@0.1.1
	@metamask/multichain-api-client@0.1.1

View full report ↗

socket-security · 2025-04-08T13:21:07Z

All alerts resolved. Learn more about Socket for GitHub ↗

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

@wallet-standard/base@1.1.0
@wallet-standard/features@1.1.0
@wallet-standard/wallet@1.1.0
@solana/wallet-standard-features@1.3.0
@solana/wallet-standard-chains@1.1.1
@metamask/multichain-api-client@0.1.1
@metamask/solana-wallet-standard@0.1.1

View full report ↗

github-actions · 2025-04-08T13:22:04Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

baptiste-marchand · 2025-04-08T14:45:12Z

I have read the CLA Document and I hereby sign the CLA

app/scripts/inpage.js

adonesky1

LGTM. Tested on both Beta and Flask!

app/scripts/inpage.js

…call

metamaskbot · 2025-04-09T23:47:50Z

Builds ready [4f0e9db]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1238 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1238	1119	1455	65	1285	1351
			load	1085	979	1266	58	1143	984
			domContentLoaded	1079	975	1261	57	1142	991
			domInteractive	17	13	53	6	17	31
			firstPaint	792	83	1272	421	229	300
			backgroundConnect	7	4	12	1	7	10
			firstReactRender	19	14	37	4	20	27
			getState	13	5	40	8	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	834	739	998	55	866	928
			setupStore	8	5	32	3	7	8
	Webpack	Home	uiStartup	2139	1694	2584	206	2286	2428
			load	1699	1307	2252	176	1793	2004
			domContentLoaded	1692	1304	2245	174	1788	1988
			domInteractive	17	12	63	11	14	53
			firstPaint	162	67	435	62	241	79
			backgroundConnect	30	10	250	32	31	57
			firstReactRender	164	53	371	109	62	97
			getState	13	3	191	19	6	9
			initialActions	3	1	6	1	3	5
			loadScripts	1687	1303	2213	169	1786	1959
			setupStore	22	6	239	33	6	9
Firefox	Browserify	Home	uiStartup	1360	1165	1768	113	1411	1619
			load	1220	1039	1639	114	1282	1454
			domContentLoaded	1220	1039	1638	114	1282	1454
			domInteractive	105	40	270	37	89	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	92	11	20	48
			firstReactRender	22	19	58	5	22	26
			getState	7	4	37	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1201	1023	1619	116	1267	1439
			setupStore	6	4	23	2	6	7
	Webpack	Home	uiStartup	1522	1349	1751	98	1602	1693
			load	1316	1154	1531	92	1384	1466
			domContentLoaded	1316	1153	1530	92	1384	1465
			domInteractive	100	64	244	26	91	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	45	7	23	43
			firstReactRender	34	29	61	6	36	47
			getState	9	4	55	7	8	9
			initialActions	0	0	2	1	1	1
			loadScripts	1297	1138	1515	92	1362	1448
			setupStore	9	5	31	5	7	8

…allet-standard

adonesky1 · 2025-04-10T14:23:35Z

@metamaskbot update-policies

adonesky1 · 2025-04-10T14:29:40Z

@SocketSecurity ignore-all

yarn.lock

metamaskbot · 2025-04-10T15:13:05Z

Policy update failed. You can review the logs or retry the policy update here

metamaskbot · 2025-04-10T16:06:07Z

Builds ready [7a538dd]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1205 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1205	1101	1451	63	1250	1295
			load	1058	962	1262	52	1133	993
			domContentLoaded	1052	958	1243	51	1129	990
			domInteractive	17	13	63	7	16	29
			firstPaint	704	82	1137	421	240	987
			backgroundConnect	7	4	20	2	7	8
			firstReactRender	21	15	45	7	20	38
			getState	13	4	55	9	7	9
			initialActions	0	0	4	0	0	1
			loadScripts	813	724	995	49	844	889
			setupStore	7	5	15	2	7	8
	Webpack	Home	uiStartup	2125	1766	2666	194	2249	2437
			load	1669	1349	2273	161	1743	1977
			domContentLoaded	1661	1345	2264	158	1739	1971
			domInteractive	16	12	63	9	14	42
			firstPaint	161	65	351	60	239	81
			backgroundConnect	26	9	132	19	28	9
			firstReactRender	158	52	361	104	65	93
			getState	17	3	300	41	7	9
			initialActions	3	1	5	1	3	4
			loadScripts	1657	1344	2236	155	1737	1944
			setupStore	26	6	247	45	247	9
Firefox	Browserify	Home	uiStartup	1373	1195	1798	122	1418	1680
			load	1232	1039	1674	124	1274	1502
			domContentLoaded	1231	1039	1673	124	1274	1502
			domInteractive	103	39	338	37	88	95
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	58	8	21	46
			firstReactRender	22	19	60	6	22	28
			getState	8	4	37	4	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1213	1023	1659	125	1260	1487
			setupStore	6	4	36	5	6	7
	Webpack	Home	uiStartup	1564	1394	2070	146	1633	1905
			load	1349	1209	1824	127	1414	1630
			domContentLoaded	1348	1209	1823	127	1414	1629
			domInteractive	95	41	179	25	88	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	85	12	24	42
			firstReactRender	35	28	55	5	36	48
			getState	10	4	35	6	8	9
			initialActions	1	0	2	1	1	1
			loadScripts	1329	1194	1801	126	1395	1612
			setupStore	9	5	46	6	8	9

baptiste-marchand force-pushed the bm/solana-wallet-standard branch from dd6d8fe to 611ced3 Compare April 8, 2025 14:54

baptiste-marchand changed the base branch from main to sip-26 April 8, 2025 14:54

jiexi reviewed Apr 9, 2025

View reviewed changes

app/scripts/inpage.js Show resolved Hide resolved

Base automatically changed from sip-26 to main April 9, 2025 20:52

baptiste-marchand added 3 commits April 9, 2025 16:27

Feat: Solana Wallet Standard

10d1ccb

Add Wallet Standard to flask builds

f92d089

Bump multichain-api-client & solana-wallet-standard

e107b4b

adonesky1 force-pushed the bm/solana-wallet-standard branch from 961c77e to 589013f Compare April 9, 2025 21:32

move solana-wallet-standard registration behind MULTICHAIN_API env var

da55096

adonesky1 force-pushed the bm/solana-wallet-standard branch from 589013f to da55096 Compare April 9, 2025 21:36

add comment

aa84240

adonesky1 added team-wallet-api-platform team-be labels Apr 9, 2025

adonesky1 changed the title ~~Feat: Solana Wallet Standard~~ feat: Solana Wallet Standard Apr 9, 2025

adonesky1 marked this pull request as ready for review April 9, 2025 21:52

adonesky1 added 2 commits April 9, 2025 16:57

revert build flags

cf63eeb

dedupe

6afddc8

adonesky1 previously approved these changes Apr 9, 2025

View reviewed changes

jiexi reviewed Apr 9, 2025

View reviewed changes

app/scripts/inpage.js Outdated Show resolved Hide resolved

move solana wallet-standard registration to after initializeProvider …

4f0e9db

…call

adonesky1 dismissed their stale review via 4f0e9db April 9, 2025 23:06

adonesky1 previously approved these changes Apr 9, 2025

View reviewed changes

Merge branch 'main', remote-tracking branch 'origin' into ad/solana-w…

5824c8c

…allet-standard

adonesky1 dismissed their stale review via 5824c8c April 10, 2025 14:05

adonesky1 previously approved these changes Apr 10, 2025

View reviewed changes

update policy files

cc34851

adonesky1 dismissed their stale review via cc34851 April 10, 2025 14:28

adonesky1 requested review from a team as code owners April 10, 2025 14:28

include lavamoat build policy file?

2f38e00

adonesky1 reviewed Apr 10, 2025

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

adonesky1 added 2 commits April 10, 2025 09:45

update/revert yarn.lock?

e480695

revert lavamoat policy files

1d9922c

adonesky1 force-pushed the bm/solana-wallet-standard branch from 0bd40d1 to 1d9922c Compare April 10, 2025 14:52

adonesky1 approved these changes Apr 10, 2025

View reviewed changes

Merge branch 'main' into bm/solana-wallet-standard

7a538dd

jiexi approved these changes Apr 10, 2025

View reviewed changes

adonesky1 enabled auto-merge April 10, 2025 15:11

adonesky1 added this pull request to the merge queue Apr 10, 2025

Merged via the queue into main with commit 58752f1 Apr 10, 2025
164 of 166 checks passed

adonesky1 deleted the bm/solana-wallet-standard branch April 10, 2025 18:43

github-actions bot locked and limited conversation to collaborators Apr 10, 2025

metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Solana Wallet Standard #31705

feat: Solana Wallet Standard #31705

Uh oh!

baptiste-marchand commented Apr 8, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Apr 8, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Apr 8, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 8, 2025 •

edited

Loading

Uh oh!

baptiste-marchand commented Apr 8, 2025

Uh oh!

Uh oh!

adonesky1 left a comment

Uh oh!

Uh oh!

metamaskbot commented Apr 9, 2025

Uh oh!

adonesky1 commented Apr 10, 2025

Uh oh!

adonesky1 commented Apr 10, 2025

Uh oh!

Uh oh!

metamaskbot commented Apr 10, 2025

Uh oh!

metamaskbot commented Apr 10, 2025

Uh oh!

Uh oh!

Uh oh!

feat: Solana Wallet Standard #31705

feat: Solana Wallet Standard #31705

Uh oh!

Conversation

baptiste-marchand commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

socket-security bot commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baptiste-marchand commented Apr 8, 2025

Uh oh!

Uh oh!

adonesky1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbot commented Apr 9, 2025

Uh oh!

adonesky1 commented Apr 10, 2025

Uh oh!

adonesky1 commented Apr 10, 2025

Uh oh!

Uh oh!

metamaskbot commented Apr 10, 2025

Uh oh!

metamaskbot commented Apr 10, 2025

Uh oh!

Uh oh!

Uh oh!

baptiste-marchand commented Apr 8, 2025 •

edited

Loading

socket-security bot commented Apr 8, 2025 •

edited

Loading

socket-security bot commented Apr 8, 2025 •

edited

Loading

github-actions bot commented Apr 8, 2025 •

edited

Loading